Bug 1828892 - Add qemu-img compare task to verify disk copy
Summary: Add qemu-img compare task to verify disk copy
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-ansible-collection
Classification: oVirt
Component: hosted-engine-setup
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.4.1
: 1.1.5
Assignee: Asaf Rachmani
QA Contact: Nikolai Sednev
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-28 14:26 UTC by Sandro Bonazzola
Modified: 2020-08-17 09:10 UTC (History)
3 users (show)

Fixed In Version: ovirt-ansible-hosted-engine-setup-1.1.5
Doc Type: Enhancement
Doc Text:
The current release adds a compare task to debug mode. The compare task verifies that an image was copied successfully to the storage domain.
Clone Of:
Environment:
Last Closed: 2020-08-05 06:25:03 UTC
oVirt Team: Integration
Embargoed:
sbonazzo: ovirt-4.4?
sbonazzo: devel_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github oVirt ovirt-ansible-hosted-engine-setup pull 324 0 None closed storage: Verify copy of VM disk 2020-08-17 06:25:04 UTC

Description Sandro Bonazzola 2020-04-28 14:26:11 UTC
Nir Soffer from storage team reviewed the storage related tasks in hosted engine deployment and suggests to add a verification step:

Added compare task after the disk copy task:
"/usr/share/ansible/roles/ovirt.hosted-engine-setup/tasks/create_target_vm/03_hosted_engine_final_tasks.yml"

  - name: Verify copy of VM disk
    command: qemu-img compare {{ local_vm_disk_path }} {{ he_virtio_disk_path }}
    environment: "{{ he_cmd_lang }}"
    become: true
    become_user: vdsm
    become_method: sudo
    changed_when: true

Comment 3 Nikolai Sednev 2020-07-13 11:00:06 UTC
Forth to https://bugzilla.redhat.com/show_bug.cgi?id=1828888#c14, moving to verified.

/usr/share/ansible/roles/ovirt.hosted-engine-setup/tasks/create_target_vm/03_hosted_engine_final_tasks.yml 
- name: Verify copy of VM disk
    command: qemu-img compare {{ local_vm_disk_path }} {{ he_virtio_disk_path }}
    environment: "{{ he_cmd_lang }}"
    become: true
    become_user: vdsm
    become_method: sudo
    changed_when: true
    when: he_debug_mode|bool

Works for me on these components:
Software Version:4.4.1.8-0.7.el8ev
ovirt-ansible-hosted-engine-setup-1.1.5-1.el8ev.noarch
rhvm-appliance-4.4-20200604.0.el8ev.x86_64
ovirt-hosted-engine-setup-2.4.5-1.el8ev.noarch
ovirt-hosted-engine-ha-2.4.4-1.el8ev.noarch
Red Hat Enterprise Linux release 8.2 (Ootpa)
Linux 4.18.0-193.13.1.el8_2.x86_64 #1 SMP Tue Jul 7 14:03:09 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux


Deployed on NFS and iSCSI successfully.

Comment 4 Sandro Bonazzola 2020-08-05 06:25:03 UTC
This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.