Bug 1828993 - Affinity Modal needs refinement
Summary: Affinity Modal needs refinement
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.5.0
Assignee: Gilad Lekner
QA Contact: Radim Hrazdil
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-28 17:14 UTC by Matt
Modified: 2023-09-14 05:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:32:29 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 5249 0 None closed Bug 1828993: Affinity Modal needs refinement 2020-11-06 03:34:20 UTC
Github openshift console pull 5487 0 None closed Bug 1828993: Add divider line befor field selectors 2020-11-06 03:34:21 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:32:47 UTC

Description Matt 2020-04-28 17:14:31 UTC
Description of problem:
The affinity modal has some ux/ui bugs that should be addressed.
We need to align with what we have in the design here:
https://github.com/openshift/openshift-origin-design/pull/383

Empty state should be updated to align with design

When workload labels fields are missing text should read "missing fields in workload labels"

When changes are made action should be "Save" instead of "Apply" (aligns with OCP)

Move "Add affinity rule" to match designs

Provide Affinity rule description according to design

How reproducible:
Very

Steps to Reproduce:
1. Look at Affinity modal via VM details tab

Comment 5 Radim Hrazdil 2020-05-14 11:25:56 UTC
When compared with https://user-images.githubusercontent.com/287880/81417619-d57e6480-9121-11ea-8cae-a1e960514868.png, 
I'm missing horizontal separator line between Node labels and Node fields. It know this is very nit picky, but when working with the dialog, I find it quite difficult to distinguish which Key Values belong to labels and which to fields.

In my opinion, the font size od the titles Node labels and Node fields is too small, so it doesn't look like two separate groups. Additionally, the Key, Operator, Value strings are IMO too far from their related elements.
But since this aspect follows the design in https://github.com/openshift/openshift-origin-design/pull/383#discussion_r422187098, I'd like to ask @Matt for his opinion.

Comment 7 Radim Hrazdil 2020-05-20 06:03:01 UTC
Verified that the separator bar is added and description is provided for both section.

Comment 8 errata-xmlrpc 2020-07-13 17:32:29 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409

Comment 9 Red Hat Bugzilla 2023-09-14 05:55:53 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.