Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1829284

Summary:	RHOSP13 - VxFlex OS volumes are not properly created from snapshot therefore can not be used
Product:	Red Hat OpenStack	Reporter:	Ivan Pchelintsev <Ivan.Pchelintsev>
Component:	openstack-cinder	Assignee:	Alan Bishop <abishop>
Status:	CLOSED ERRATA	QA Contact:	Tzach Shefi <tshefi>
Severity:	medium	Docs Contact:	Chuck Copello <ccopello>
Priority:	medium
Version:	13.0 (Queens)	CC:	abishop, arkady_kanevsky, gcharot, jamsmith, kholtz, kurt_hey, ltoscano, morazi, rajini.karthik, Sam.Wan, vladislav.belogrudov
Target Milestone:	z12	Keywords:	OtherQA, Triaged, ZStream
Target Release:	13.0 (Queens)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-cinder-12.0.10-8.el7ost	Doc Type:	Bug Fix
Doc Text:	This update correctly associates a cinder volume with its corresponding VxFlex OS volume, so that when you delete a volume, the corresponding backend volume is also deleted. Previously, deletion of a cinder volume did not trigger deletion of the corresponding VxFlex OS volume.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-06-24 11:51:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ivan Pchelintsev 2020-04-29 10:39:09 UTC

Description of problem:
Volume on VxFlex OS array not removed when it's deleted from cinder if it's craeted from a snapshot.


Steps to Reproduce:
1. create a volume for test:
openstack volume create --type vxflexos1 --size 16 testvol 
2. create a snapshot of the volume: 
openstack volume snapshot create --volume testvol testvol_snap
3. restore the snapshot to a new volume:
openstack volume create --snapshot testvol_snap --size 16 vol_from_snap
4. delete the volume restored from snapshot
openstack volume delete vol_from_snap
5. delete the snapshot:
openstack volume snapshot delete testvol_snap
6. delete the original volume:
openstack volume delete testvol


Actual results:
The volume restored from snapshot is still on the array.

Expected results:
The volume restored from snapshot should not be presented on the array.

Comment 1 Ivan Pchelintsev 2020-04-29 10:46:43 UTC

This bug is fixed by
https://github.com/ivanpch/cinder/commit/42f3b668fbac55a64e56e776f4ef3a039840dd33

Comment 2 Luigi Toscano 2020-04-29 14:16:52 UTC

(In reply to Ivan Pchelintsev from comment #1)
> This bug is fixed by
> https://github.com/ivanpch/cinder/commit/
> 42f3b668fbac55a64e56e776f4ef3a039840dd33

In fact it is a follow-up to the backport tracked by https://bugzilla.redhat.com/show_bug.cgi?id=1777366 . The corresponding upstream stable/queens code contains the return, as well as the newer branches.

Just a question: from The bug title it seems that the volumes are not working, but from the description I understand it's just a removal problem. Should the title be tuned a bit? I guess it changes also the impact of the issue.

Comment 3 Vladislav Belogrudov 2020-04-29 16:21:10 UTC

(In reply to Luigi Toscano from comment #2)
> (In reply to Ivan Pchelintsev from comment #1)
> > This bug is fixed by
> > https://github.com/ivanpch/cinder/commit/
> > 42f3b668fbac55a64e56e776f4ef3a039840dd33
> 
> In fact it is a follow-up to the backport tracked by
> https://bugzilla.redhat.com/show_bug.cgi?id=1777366 . The corresponding
> upstream stable/queens code contains the return, as well as the newer
> branches.
> 
> Just a question: from The bug title it seems that the volumes are not
> working, but from the description I understand it's just a removal problem.
> Should the title be tuned a bit? I guess it changes also the impact of the
> issue.


You are right, it's a follow up of the 1777366, the return statement was lost in backport and that led to the erroneous behavior. 

The volume is created but we don't return model update with proper VxFlex OS volume id and cannot reference to it afterwards. So the title of the bug is correct - such volume is unusable after creation from a snap.

Comment 4 Ivan Pchelintsev 2020-04-29 16:37:02 UTC

(In reply to Luigi Toscano from comment #2)
> (In reply to Ivan Pchelintsev from comment #1)
> > This bug is fixed by
> > https://github.com/ivanpch/cinder/commit/
> > 42f3b668fbac55a64e56e776f4ef3a039840dd33
> 
> In fact it is a follow-up to the backport tracked by
> https://bugzilla.redhat.com/show_bug.cgi?id=1777366 . The corresponding
> upstream stable/queens code contains the return, as well as the newer
> branches.
> 
> Just a question: from The bug title it seems that the volumes are not
> working, but from the description I understand it's just a removal problem.
> Should the title be tuned a bit? I guess it changes also the impact of the
> issue.

Driver was backported without return statement.
The fix mentioned in my comment was done just today.
Other questions were answered by Vladislav Belogrudov in the previous comment.

Comment 12 errata-xmlrpc 2020-06-24 11:51:47 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2722