Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1829697

Summary:	Stop using deprecated "migrate_set_speed" QMP command
Product:	Red Hat Enterprise Linux Advanced Virtualization	Reporter:	Li Xiaohui <xiaohli>
Component:	qemu-kvm	Assignee:	Jiri Herrmann <jherrman>
qemu-kvm sub component:	Live Migration	QA Contact:	Virtualization Bugs <virt-bugs>
Status:	CLOSED UPSTREAM	Docs Contact:
Severity:	unspecified
Priority:	unspecified	CC:	chhu, ehabkost, fjin, hhan, lizhu, lmen, pkrempa, virt-maint, xuzhang
Version:	8.2	Keywords:	TestOnly
Target Milestone:	rc
Target Release:	8.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1829545	Environment:
Last Closed:	2020-07-07 00:35:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1829545
Bug Blocks:

Description Li Xiaohui 2020-04-30 06:43:07 UTC

+++ This bug was initially created as a clone of Bug #1829545 +++

Description of problem:
"migrate_set_speed" is deprecated since qemu-2.8 and should be replaced by 'migrate-set-parameters". Libvirt still uses it in qemuDomainMigrateSetMaxSpeed (non-postcopy case), qemuMigrationSrcRun (always), qemuMigrationSrcToFile (always).

When fixing this, please also adjust the test case to mark the command as okay to be removed.

Comment 5 Eduardo Habkost 2020-06-15 18:12:35 UTC

I've just noticed we already have a libvirt BZ for this (bug 1829545), and this BZ description is 100% identical to the description fo that bug.  What is the purpose of this BZ?

Comment 6 Li Xiaohui 2020-06-16 02:07:14 UTC

(In reply to Eduardo Habkost from comment #5)
> I've just noticed we already have a libvirt BZ for this (bug 1829545), and
> this BZ description is 100% identical to the description fo that bug.  What
> is the purpose of this BZ?

This bz just be tracked on qemu side. 
I think we need update besides libvirt side, also need from qemu, so clone bz from libvirt.

Comment 7 Eduardo Habkost 2020-06-17 22:39:23 UTC

The summary and description of the BZ doesn't mention anything that needs to be done on the QEMU side.  QEMU itself is not a user of QMP commands.

If there's any task to be done on the QEMU side, please explain what needs to be done so we can change the BZ summary and description accordingly.  If there's no task to be done, I will close this BZ.

Comment 8 Li Xiaohui 2020-06-18 08:50:27 UTC

(In reply to Eduardo Habkost from comment #7)
> The summary and description of the BZ doesn't mention anything that needs to
> be done on the QEMU side.  QEMU itself is not a user of QMP commands.
> 
> If there's any task to be done on the QEMU side, please explain what needs
> to be done so we can change the BZ summary and description accordingly.  If
> there's no task to be done, I will close this BZ.

Yes, we want to document in qemu that these commands are deprecated on rhel8.3-av when related libvirt bz(Bug #1829545) fixed

Comment 10 Eduardo Habkost 2020-07-06 18:41:14 UTC

(In reply to Li Xiaohui from comment #8)
> (In reply to Eduardo Habkost from comment #7)
> > The summary and description of the BZ doesn't mention anything that needs to
> > be done on the QEMU side.  QEMU itself is not a user of QMP commands.
> > 
> > If there's any task to be done on the QEMU side, please explain what needs
> > to be done so we can change the BZ summary and description accordingly.  If
> > there's no task to be done, I will close this BZ.
> 
> Yes, we want to document in qemu that these commands are deprecated on
> rhel8.3-av when related libvirt bz(Bug #1829545) fixed

The QEMU documentation already indicates that migrate_set_speed is deprecated: https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#index-migrate_005fset_005fspeed

There's no customer documentation for QMP commands, so I still don't understand what needs to be done for this BZ.  Please clarify which documentation needs to be updated.

Comment 11 Li Xiaohui 2020-07-07 00:31:50 UTC

(In reply to Eduardo Habkost from comment #10)
> (In reply to Li Xiaohui from comment #8)
> > (In reply to Eduardo Habkost from comment #7)
> > > The summary and description of the BZ doesn't mention anything that needs to
> > > be done on the QEMU side.  QEMU itself is not a user of QMP commands.
> > > 
> > > If there's any task to be done on the QEMU side, please explain what needs
> > > to be done so we can change the BZ summary and description accordingly.  If
> > > there's no task to be done, I will close this BZ.
> > 
> > Yes, we want to document in qemu that these commands are deprecated on
> > rhel8.3-av when related libvirt bz(Bug #1829545) fixed
> 
> The QEMU documentation already indicates that migrate_set_speed is
> deprecated:
> https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#index-
> migrate_005fset_005fspeed
> 
> There's no customer documentation for QMP commands, so I still don't
> understand what needs to be done for this BZ.  Please clarify which
> documentation needs to be updated.

Thanks, having seen the QEMU documentation.
I'm ok to close this bz.