Bug 1830549 - A quick patch for xfce4-cpufreq-plugin broke it
Summary: A quick patch for xfce4-cpufreq-plugin broke it
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: xfce4-cpufreq-plugin
Version: 32
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1830261
TreeView+ depends on / blocked
 
Reported: 2020-05-02 17:10 UTC by Artem S. Tashkinov
Modified: 2020-05-03 08:05 UTC (History)
12 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-05-02 17:34:42 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Artem S. Tashkinov 2020-05-02 17:10:24 UTC
Looks like someone applied a patch to make xfce4-cpufreq-plugin build under GCC 10 and it broke the package completely. It crashes immediately.

The patch is:

sed -i 's/CpuFreqPlugin \*cpuFreq/extern CpuFreqPlugin \*cpuFreq/' panel-plugin/xfce4-cpufreq-plugin.h

I'm filing this bug report under GCC (that's NOT a mistake) because the xfce4-cpufreq-plugin maintainer is seemingly MIA.

I believe Fedora GCC maintainers can figure out why the patch is wrong and how to fix the package properly.

Please don't let it linger for half a year as it too often happens. I'm not a C programmer, so I have no idea why the patch doesn't work and how to fix it.

Comment 1 Artem S. Tashkinov 2020-05-02 17:12:04 UTC
I tried CC'ing Mukundan Ragavan who wrote a patch but he's not registered here.

Comment 2 Artem S. Tashkinov 2020-05-02 17:14:27 UTC
Upstream has no patches for the issue: https://gitlab.xfce.org/panel-plugins/xfce4-cpufreq-plugin The code was last updated in 2019.

Comment 3 Artem S. Tashkinov 2020-05-02 17:34:42 UTC
Mukundan Ragavan has resurfaced. Closing. Sorry for the noise.

Comment 4 Raphael Groner 2020-05-02 18:14:09 UTC
Someone should fix the proposed patch and send to upstream.

Comment 5 Jonathan Wakely 2020-05-03 08:05:48 UTC
(In reply to Artem S. Tashkinov from comment #0)
> I'm filing this bug report under GCC (that's NOT a mistake) because the
> xfce4-cpufreq-plugin maintainer is seemingly MIA.
> 
> I believe Fedora GCC maintainers can figure out why the patch is wrong and
> how to fix the package properly.

Wouldn't it have been better to ask for help on the devel@ mailing list instead of filing a bug under the wrong component?

"This isn't a GCC bug but I want GCC maintainers to fix it for me" is not how bug reports work.


Note You need to log in before you can comment on or make changes to this bug.