Bug 1830705 - Last modified value is 'Jan 1, 1970' for disks other then OVF
Summary: Last modified value is 'Jan 1, 1970' for disks other then OVF
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.4.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.4.1
: 4.4.1.5
Assignee: Ahmad Khiet
QA Contact: Evelina Shames
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-03 10:49 UTC by Evelina Shames
Modified: 2020-07-08 08:27 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.4.1.5
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-08 08:27:37 UTC
oVirt Team: Storage
Embargoed:
pm-rhel: ovirt-4.4+

Attachments (Terms of Use)
screenshot (298.79 KB, image/png)
2020-05-03 10:49 UTC, Evelina Shames 		no flags Details
epoch_volume_info_vdsm (50.54 KB, image/png)
2020-05-03 15:50 UTC, Ahmad Khiet 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 109696 0 master MERGED core: drop mtime from GetVolumeInfoVDSCommand 2021-01-28 11:17:58 UTC

Description Evelina Shames 2020-05-03 10:49:06 UTC 
Created attachment 1684420 [details]
screenshot

Description of problem:
When adding a new disk, at some point, the Last Modified date changes to Jan 1, 1970, 2:00:00 AM.

Version-Release number of selected component (if applicable):
Engine-4.4.0-0.33.master.el8ev

How reproducible:
100%

Steps to Reproduce:
1.Add new disk
2.At some point, the Last Modified date changes to Jan 1, 1970, 2:00:00 AM.

Actual results:
The Last Modified date is not the real date.

Expected results:
The Last Modified date should be the real date


Additional info:
Screenshot attached.
Comment 2 Ahmad Khiet 2020-05-03 15:50:30 UTC 
Created attachment 1684462 [details]
epoch_volume_info_vdsm
Comment 3 Amit Bawer 2020-05-21 07:44:37 UTC 
The MTIME field is deprecated for a while now, only kept as zero for not breaking compatibility with older format versions (v4).

commit b44f2920fbe818167d1efd390af87e8608f74cbb
Author: Denis Chaplygin <dchaplyg>
Date:   Wed Jan 23 15:20:18 2019 +0100

    storage: Dropped MTIME field from VolumeMetadata
    
    This field was never used, so we are dropping it in v5 storage domain
    format.
    
    We still have to handle it for v4 domains, as metadata reading procedure
    expects that field to be available. Because of that, for v4 domains a
    constant value "0" will be reported.
    
    Change-Id: I5699364de777b1196378a5fd764cf9ab2cc9f691
    Bug-Url: https://bugzilla.redhat.com/1592916
    Signed-off-by: Denis Chaplygin <dchaplyg>


This is also stated on the API:

    VolumeInfoResponse: &VolumeInfoResponse
        added: '3.1'
        description: Information about a Volume.
        name: VolumeInfoResponse
        properties:
        ...

        -   description: The Volume modification time (deprecated)
            name: mtime
            type: uint


I'd suggest to use engine operation time for this field display and ignore the 0 place-holder value returned from volume info response.
Comment 4 Eyal Shenitzky 2020-05-21 08:24:38 UTC 
Thanks for the input Amit.

Moving back to Ahmad.
Comment 5 Evelina Shames 2020-07-05 08:33:31 UTC 
Verified on engine-4.4.1.7-0.3.el8ev
Comment 6 Sandro Bonazzola 2020-07-08 08:27:37 UTC 
This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.