Bug 1830954 - python-typing-extensions fails to build with Python 3.9: test_repr fails
Summary: python-typing-extensions fails to build with Python 3.9: test_repr fails
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-typing-extensions
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Jonny Heggheim
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-05-04 12:11 UTC by Miro Hrončok
Modified: 2020-05-28 14:38 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-28 14:38:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2020-05-04 12:11:56 UTC
python-typing-extensions fails to build with Python 3.9.0a6.

+ /usr/bin/python3 src_py3/test_typing_extensions.py
................F...............................................................s.....s..........s.....................s..
======================================================================
FAIL: test_repr (__main__.AnnotatedTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/typing_extensions-3.7.4.2/src_py3/test_typing_extensions.py", line 1591, in test_repr
    self.assertEqual(
AssertionError: 'typing.Annotated[int, 4, 5]' != 'typing_extensions.Annotated[int, 4, 5]'
- typing.Annotated[int, 4, 5]
+ typing_extensions.Annotated[int, 4, 5]
?       +++++++++++


----------------------------------------------------------------------
Ran 122 tests in 0.076s

FAILED (failures=1, skipped=4)

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01365614-python-typing-extensions/

For all our attempts to build python-typing-extensions with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-typing-extensions/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2020-05-25 13:02:24 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 2 Lumír Balhar 2020-05-26 12:39:44 UTC
This is currently blocking builds of these packages:

dnf repoquery --repo=rawhide{,-source} --source --whatrequires python3-typing-extensions
matrix-synapse-1.13.0-1.fc33.src.rpm
python-injector-0.18.3-1.fc32.src.rpm
python-molten-0.7.4-2.fc32.src.rpm
python-signedjson-1.1.1-1.fc33.src.rpm
python-trezor-0.11.5-2.fc32.src.rpm
python-typing-inspect-0.5.0-2.fc32.src.rpm
python3-mypy-0.770-1.fc33.src.rpm

Comment 3 Miro Hrončok 2020-05-28 08:43:45 UTC
$ repoquery --repo=rawhide{,-source} --whatrequires python3-typing-extensions --recursive
gst-0:0.7.2-1.fc33.noarch
gwe-0:0.14.1-2.fc33.noarch
home-assistant-cli-0:0.9.1-1.fc33.src
matrix-synapse-0:1.13.0-1.fc33.noarch
matrix-synapse-0:1.13.0-1.fc33.src
python-injector-0:0.18.3-1.fc32.src
python-josepy-0:1.3.0-1.fc32.src
python-molten-0:0.7.4-2.fc32.src
python-pydantic-0:1.3-4.fc32.src
python-pydocstyle-0:5.0.1-2.fc32.src
python-signedjson-0:1.1.1-1.fc33.src
python-typing-inspect-0:0.5.0-2.fc32.src
python-ufoLib2-0:0.7.1-2.fc33.src
python3-injector-0:0.18.3-1.fc32.noarch
python3-molten-0:0.7.4-2.fc32.noarch
python3-mypy-0:0.770-1.fc33.noarch
python3-mypy-0:0.770-1.fc33.src
python3-signedjson-0:1.1.1-1.fc33.noarch
python3-trezor-0:0.11.5-2.fc32.noarch
python3-typing-inspect-0:0.5.0-2.fc32.noarch
thonny-0:3.2.7-2.fc32.noarch

Lumír, can you look into the fix please?

Comment 4 Lumír Balhar 2020-05-28 11:47:25 UTC
Proposed solution: https://src.fedoraproject.org/rpms/python-typing-extensions/pull-request/1

Comment 5 Jonny Heggheim 2020-05-28 14:38:51 UTC
(In reply to Lumír Balhar from comment #4)
> Proposed solution:
> https://src.fedoraproject.org/rpms/python-typing-extensions/pull-request/1

Thanks, merged and rebuilt on f33-python: https://koji.fedoraproject.org/koji/taskinfo?taskID=45102471


Note You need to log in before you can comment on or make changes to this bug.