Red Hat Bugzilla – Bug 183097
Review Request: rogue - text-based adventure game
Last modified: 2007-11-30 17:11:25 EST
Spec Name or Url: http://www.kobold.org/~wart/fedora/rogue.spec SRPM Name or Url: http://www.kobold.org/~wart/fedora/rogue-5.4.2-1.src.rpm Description: Before DOOM, there were the Dungeons of DOOM. This is the game that started an entire genre.
rogue is setgid 'games' so that everyone who runs the game can write to the high score file. This causes rpmlint to complain: E: rogue non-standard-dir-perm /var/games/roguelike 0775 E: rogue non-standard-executable-perm /usr/bin/rogue 02755 I am inclined to ignore this.
Good: - rpmlint checks return: E: rogue non-standard-dir-perm /var/games/roguelike 0775 E: rogue non-standard-executable-perm /usr/bin/rogue 02755 ignored as per comment 1. - package meets naming guidelines - package meets packaging guidelines - license (BSD) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file - runs :) APPROVED
Imported and built. Thanks!
Assigning to me.
Package Change Request ====================== Package Name: rogue New Branches: F-8
cvs done.