Red Hat Bugzilla – Bug 183112
PATCH: sound does not work on PPC
Last modified: 2013-07-02 19:14:24 EDT
I'm the maintainer of several allegro using packages in extras, as I'm currently working on a new package about which I had some doubts if it would work on PPC I asked on the list if some PPC users could test it. one PPC user was kind enough todo so. This tested resulted in the finding of a endianness bug in allegro. More specificly in the digital audio alsa driver of allegro, which is the default driver used by allegro, thus an error in this driver normally results in no sound being available at all. The tester didn't have any sound with lacewing, overgod and the game he was testing for me. The attached patch fixes this endianness bug in allegro. The problem is that it first sets format to NE (Native Endian)* and then checks if format is either 8 bit or LE (Little Endian) which although it works fine on LE machines will of course fail on BE. * unless 8 bit sound has been specified in allegrorc .
Created attachment 125276 [details] PATCH fixing sound on PPC
p.s. I also send this upstream.
p.s. 2 Since I'm currently doing a lot of packaging / development with allegro it might be an idea if we experimented with shared package maintainer ship. This concept has been mentioned on f-e-l some times before, but has afaik never been tried. This would reduce work for both of us, since before I send any patches to you I first do a local testbuild in a local modified version of the cvs devel-branch, so it is less work for me if they turn out ok to fix the release, add a changelog entry to the spec and push the changes then it is to explain the patch in bugzilla, and it would save you the time of downloading, reviewing and integrating the patches. If you agree, then I'll add myself to the allegro bugs CC-list in owners.list, and we must find a way to not step on each others toes (cvs-conflicts) while working on allegro. This could be a simple as sending a mail when you start working (basicly an advisory lock :) and sending another one when done.
I have nothing against cooperation so I like the idea of shared maintainership. The most of the patches related to allegro come from you anyway, so feel free to add yourself to owners.list ;)
Will do, to avoid collisions, shall I commit and push this and the lib64 patch or will you?
Yes, feel free to do it. I'll try to look at bug 183033 at the time.
Committed to CVS and build requested
Hmm, guess it would have been better to not tag and build concidering you're progressing nicely on bug 183033, I'll try to think of things like this the next time.