spec: https://svgames.pl/fedora/luv-icon-theme-0.4.9.31-1.20200504git6f0fb464/luv-icon-theme.spec srpm: https://svgames.pl/fedora/luv-icon-theme-0.4.9.31-1.20200504git6f0fb464/luv-icon-theme-0.4.9.31-1.20200504git6f0fb464.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=44115739 Description: Lüv is the spiritual successor to Flattr, a flat but complex icon theme. It also comes with 6 different wallpapers to use alongside the icons. Fedora Account System Username: suve
- Remove these: luv-icon-theme.noarch: E: zero-length /usr/share/icons/Luv/actions/24/dummy.txt luv-icon-theme.noarch: E: zero-length /usr/share/icons/Luv/actions/symbolic/dummy.txt luv-icon-theme.noarch: E: zero-length /usr/share/icons/Luv/status/24/dummy.txt - Remove the executable bits of these and send a patch upstream: luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/16/qbittorrent.svg luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/22/qbittorrent-tray.svg luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/32/qbittorrent.svg luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/48/qbittorrent.svg luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/64/qbittorrent.svg - You need to own these: [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/icons/Luv/status, /usr/share/icons/Luv/mimetypes, /usr/share/icons/Luv/emblems, /usr/share/icons/Luv/devices, /usr/share/icons/Luv/places, /usr/share/icons/Luv/actions, /usr/share/icons/Luv/categories, /usr/share/icons/Luv/emotes, /usr/share/icons/Luv/apps Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Creative Commons Attribution- ShareAlike 4.0 International License". 1845 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/luv-icon-theme/review-luv-icon- theme/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/icons/Luv/status, /usr/share/icons/Luv/mimetypes, /usr/share/icons/Luv/emblems, /usr/share/icons/Luv/devices, /usr/share/icons/Luv/places, /usr/share/icons/Luv/actions, /usr/share/icons/Luv/categories, /usr/share/icons/Luv/emotes, /usr/share/icons/Luv/apps [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in luv- wallpapers [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: luv-icon-theme-0.4.9.31-1.20200504git6f0fb464.fc33.noarch.rpm luv-wallpapers-0.4.9.31-1.20200504git6f0fb464.fc33.noarch.rpm luv-icon-theme-0.4.9.31-1.20200504git6f0fb464.fc33.src.rpm luv-icon-theme.noarch: W: spelling-error %description -l en_US Lüv -> Lav luv-icon-theme.noarch: W: no-documentation luv-icon-theme.noarch: E: zero-length /usr/share/icons/Luv/actions/24/dummy.txt luv-icon-theme.noarch: E: zero-length /usr/share/icons/Luv/actions/symbolic/dummy.txt luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/16/qbittorrent.svg luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/22/qbittorrent-tray.svg luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/32/qbittorrent.svg luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/48/qbittorrent.svg luv-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Luv/apps/64/qbittorrent.svg luv-icon-theme.noarch: E: zero-length /usr/share/icons/Luv/status/24/dummy.txt luv-wallpapers.noarch: W: no-documentation luv-icon-theme.src: W: spelling-error %description -l en_US Lüv -> Lav 3 packages and 0 specfiles checked; 8 errors, 4 warnings.
Thanks for the review. Addressed the issues and updated to latest git snapshot. spec: https://svgames.pl/fedora/luv-icon-theme-0.4.9.31-2.20200623git42387fe9/luv-icon-theme.spec srpm: https://svgames.pl/fedora/luv-icon-theme-0.4.9.31-2.20200623git42387fe9/luv-icon-theme-0.4.9.31-2.20200623git42387fe9.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=46053355
As for executable bits being present on icon files, here's a pull request submitted upstream: https://github.com/Nitrux/luv-icon-theme/pull/223
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/luv-icon-theme
FEDORA-2020-3ab9d76046 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-3ab9d76046
FEDORA-2020-34281d4c2f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-34281d4c2f
FEDORA-2020-3ab9d76046 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-3ab9d76046 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-3ab9d76046 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-34281d4c2f has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-34281d4c2f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-34281d4c2f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-3ab9d76046 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-34281d4c2f has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.