Spec URL: https://copr-be.cloud.fedoraproject.org/results/snecker/python-typeguard/fedora-rawhide-x86_64/01369129-python-typeguard/python-typeguard.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/snecker/python-typeguard/fedora-rawhide-x86_64/01369129-python-typeguard/python-typeguard-2.7.1-1.fc33.src.rpm Description: Run-time type checker for Python Fedora Account System Username:snecker
Copr repo: https://copr.fedorainfracloud.org/coprs/snecker/python-typeguard Github Spec URL for copr repo: https://github.com/snecklifter/python-typeguard
This is a requirement for the latest python-tenacity versions: https://kojipkgs.fedoraproject.org//work/tasks/9973/44159973/build.log
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 - %{?python_enable_dependency_generator} can be removed, the dependency generator is enabled by default - Remove "%global common_desc" this is a superfluous variable. Place the content directly in the "Summery:" tag and re-use %{summary} later - Upstream has a test suite. This means switching to the upstream source from GItHub. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 30 files have unknown license. Detailed output of licensecheck in /home/fab/Documents/repos/reviews/1832392-python- typeguard/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [-]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-typeguard-2.7.1-1.fc33.noarch.rpm python-typeguard-2.7.1-1.fc33.src.rpm python3-typeguard.noarch: E: zero-length /usr/lib/python3.8/site-packages/typeguard/py.typed 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. python3-typeguard.noarch: W: invalid-url URL: https://github.com/agronholm/typeguard <urlopen error [Errno -2] Name or service not known> python3-typeguard.noarch: E: zero-length /usr/lib/python3.8/site-packages/typeguard/py.typed 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Source checksums ---------------- https://pypi.io/packages/source/t/typeguard/typeguard-2.7.1.tar.gz : CHECKSUM(SHA256) this package : 2d545c71e9439c21bcd7c28f5f55b3606e6106f7031ab58375656a1aed483ef2 CHECKSUM(SHA256) upstream package : 2d545c71e9439c21bcd7c28f5f55b3606e6106f7031ab58375656a1aed483ef2 Requires -------- python3-typeguard (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-typeguard: python-typeguard python3-typeguard python3.8-typeguard python3.8dist(typeguard) python3dist(typeguard) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1832392 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: SugarActivity, PHP, fonts, R, Haskell, Java, C/C++, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review Fabian. (In reply to Fabian Affolter from comment #3) > Issues: > ======= > - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files > Note: Package contains %{pythonX_site(lib|arch)}/* in %files > See: https://pagure.io/packaging-committee/issue/782 Fixed. > - %{?python_enable_dependency_generator} can be removed, the dependency > generator is enabled by default Fixed. > - Remove "%global common_desc" this is a superfluous variable. Place the > content directly in the "Summery:" tag and re-use %{summary} later Fixed. > - Upstream has a test suite. This means switching to the upstream source > from GItHub. Can you clarify as this is included and is being run? + /usr/bin/python3 -m pytest ==================================================================================================================================================== test session starts ===================================================================================================================================================== platform linux -- Python 3.8.2, pytest-4.6.9, py-1.8.0, pluggy-0.13.0 rootdir: /home/chribrow/rpmbuild/BUILD/typeguard-2.7.1, inifile: setup.cfg, testpaths: tests plugins: typeguard-2.7.1, cov-2.8.1 collected 213 items tests/test_importhook.py ............... [ 7%] tests/test_typeguard.py ................................................................................................................................................................................... [ 91%] tests/test_typeguard_py36.py ........... [ 96%] tests/test_typeguard_py38.py ........ [100%] ----------- coverage: platform linux, python 3.8.2-final-0 ----------- Name Stmts Miss Cover Missing ---------------------------------------------------------- typeguard/__init__.py 536 183 66% 1-83, 102, 106-131, 157, 164, 169, 190, 196, 201, 215, 229, 236-237, 241-242, 277, 291, 312, 325, 337, 350, 367-368, 383, 393, 396, 413, 433, 436, 471, 477, 479, 482-486, 495-500, 507-542, 560, 574, 578, 580, 610, 626-627, 640, 658-659, 675-676, 685-688, 691-700, 716-717, 725-728, 731-740, 751-761, 839-875, 879, 890-903, 918-921, 925-938, 954, 969, 973 typeguard/importhook.py 93 34 63% 1-13, 17, 21-22, 25, 41, 50, 69-70, 79, 85-96, 100, 107-109, 120-124, 127, 130, 133, 136-140, 159 typeguard/pytest_plugin.py 9 7 22% 1-11, 14-15 ---------------------------------------------------------- TOTAL 638 224 65% ================================================================================================================================================= 213 passed in 1.04 seconds =================================================================================================================================================
Hmmm, I was looking at a different spec file when I was talking about the unit tests perhaps. My bad. Could you please upload the new spec file (aka Release: 2%{?dist})? Thanks
(In reply to Fabian Affolter from comment #5) > Could you please upload the new spec file (aka Release: 2%{?dist})? Thanks Done!
Submitted a scratch build but Koji is unwell at the moment it seems: OSError: [Errno 30] Read-only file system: '/var/tmp/koji/tasks/9906/45069906'
Can you make the updated files available?
(In reply to Fabian Affolter from comment #8) > Can you make the updated files available? They were updated at the original location: https://github.com/snecklifter/python-typeguard and at copr repo: https://copr.fedorainfracloud.org/coprs/snecker/python-typeguard I have also started another scratch build FWIW: https://koji.fedoraproject.org/koji/taskinfo?taskID=46085897
(In reply to Christopher Brown from comment #9) > I have also started another scratch build FWIW: > > https://koji.fedoraproject.org/koji/taskinfo?taskID=46085897 which has failed so am re-trying with 2.9.1, cancelling NEEDINFO
Built fine against F32 with python 3.8 https://koji.fedoraproject.org/koji/taskinfo?taskID=46086263 Upstream don't appear to be testing with python 3.9 yet. Thoughts?
(In reply to Christopher Brown from comment #11) > Built fine against F32 with python 3.8 > > https://koji.fedoraproject.org/koji/taskinfo?taskID=46086263 > > Upstream don't appear to be testing with python 3.9 yet. > Thoughts? Add a condition to limit the tests to Python 3.8. You have to remove the all *.egg stuff in %prep.
Latest release is 2.9.1
(In reply to Fabian Affolter from comment #12) > (In reply to Christopher Brown from comment #11) > > Built fine against F32 with python 3.8 > > > > https://koji.fedoraproject.org/koji/taskinfo?taskID=46086263 > > > > Upstream don't appear to be testing with python 3.9 yet. > > Thoughts? > > Add a condition to limit the tests to Python 3.8. Done. > You have to remove the all *.egg stuff in %prep. Done and built 2.9.1 https://github.com/snecklifter/python-typeguard/blob/master/python-typeguard.spec https://copr.fedorainfracloud.org/coprs/snecker/python-typeguard/build/1518718/
Hi Fabian, Anything else need doing here?
Comments addressed, package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-typeguard