Bug 183255 - Review Request: xscreensaver
Summary: Review Request: xscreensaver
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Thorsten Leemhuis (ignored mailbox)
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-02-27 20:07 UTC by Ray Strode [halfline]
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-02-27 20:31:32 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ray Strode [halfline] 2006-02-27 20:07:27 UTC
Spec Name or Url: http://people.freedesktop.org/~halfline/xscreensaver.spec
SRPM Name or Url: http://people.freedesktop.org/~halfline/xscreensaver-4.24-2.src.rpm
Description: This is the xscreensaver package being moved from core.

Comment 1 Warren Togami 2006-02-27 20:19:05 UTC
(not a complete review, just a comment)

%define default_text %{_datadir}/doc/fedora-release-4/RELEASE-NOTES
This will change of course change in FC5.


Comment 2 Warren Togami 2006-02-27 20:24:19 UTC
I guess I read through the entire spec anyway, and the rest of it looks fine. 
Just fix the above problem and it is APPROVED.  Proceed to edit the owners list,
cvs-import your package, make tag and make build.


Comment 3 Ray Strode [halfline] 2006-02-27 20:31:32 UTC
So we decided to keep this in Core until FC6.

Comment 4 Warren Togami 2006-02-27 20:38:51 UTC
NEEDSWORK
actually, there are a few more things that should be cleared up

[warren@caprica tmp]$ rpmlint xscreensaver-4.24-2.src.rpm
W: xscreensaver buildprereq-use bc, pam-devel
E: xscreensaver broken-syntax-in-scriptlet-requires BuildPrereq: bc, pam-devel
W: xscreensaver buildprereq-use libX11-devel, libXScrnSaver-devel, libXext-devel
E: xscreensaver broken-syntax-in-scriptlet-requires BuildPrereq: libX11-devel,
libXScrnSaver-devel, libXext-devel
W: xscreensaver buildprereq-use libXinerama-devel
E: xscreensaver broken-syntax-in-scriptlet-requires BuildPrereq: libXinerama-devel
W: xscreensaver buildprereq-use xorg-x11-proto-devel
E: xscreensaver broken-syntax-in-scriptlet-requires BuildPrereq:
xorg-x11-proto-devel
W: xscreensaver buildprereq-use gtk2-devel libglade2-devel
E: xscreensaver broken-syntax-in-scriptlet-requires BuildPrereq: gtk2-devel
libglade2-devel

All of the above makes little sense to me and might not be actual problems. 
Anybody else know what this means?

W: xscreensaver patch-not-applied Patch2:
xscreensaver-4.21-dont-ping-if-not-root.patch
W: xscreensaver patch-not-applied Patch4: xscreensaver-4.22-fix-man-pages.patch

If patches are not applied, usually this indicates it should be cleaned from the
spec?  (There are some weird exceptions to this like within gaim.)

Then there's some build failure, it could be more missing BuildReq's.  This will
fail in Extras buildsys where it might not fail in Core beehive.

gcc -pedantic -Wall -Wstrict-prototypes -Wnested-externs -std=c89
-U__STRICT_ANSI__ -c -I. -I../../driver -I../../driver/../utils -I.. 
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/libglade-2.0 
 -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  
-I/usr/include -DHACK_CONFIGURATION_PATH='"/usr/share/xscreensaver/config"'
-DHAVE_CONFIG_H -DDEFAULT_ICONDIR='"/usr/share/xscreensaver/glade"' -O2 -g -pipe
-Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables  \
  ../../driver/demo-Gtk-conf.c
In file included from /usr/include/gtk-2.0/gtk/gtkactiongroup.h:34,
                 from /usr/include/gtk-2.0/gtk/gtk.h:38,
                 from ../../driver/demo-Gtk-conf.c:63:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:50: warning: function declaration
isn't a prototype
gcc -pedantic -Wall -Wstrict-prototypes -Wnested-externs -std=c89
-U__STRICT_ANSI__ -L/usr/lib -o xscreensaver-demo-Gtk prefs.o dpms.o remote.o
exec.o ../utils/resources.o ../utils/usleep.o ../utils/visual.o demo-Gtk.o
demo-Gtk-conf.o    \
-Wl,--export-dynamic -lglade-2.0 -lgtk-x11-2.0 -lxml2 -lz -lgdk-x11-2.0
-latk-1.0 -lpangocairo-1.0 -lpango-1.0 -lcairo -lgdk_pixbuf_xlib-2.0
-lgdk_pixbuf-2.0 -lm -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0   
-lgdk_pixbuf_xlib-2.0 -lgdk_pixbuf-2.0 -lm -lgobject-2.0 -lgmodule-2.0 -ldl
-lglib-2.0     -lSM -lICE \
-lXt -lX11  -lXinerama -lXext
demo-Gtk.o: In function `demo_ehandler':../../driver/demo-Gtk.c:4330: undefined
reference to `XmuPrintDefaultErrorMessage'
collect2: ld returned 1 exit status
make[1]: *** [xscreensaver-demo-Gtk] Error 1
make[1]: Leaving directory
`/home/builder6/rpmbuild/BUILD/xscreensaver-4.24/i686-redhat-linux-gnu/driver'
make: *** [default] Error 5
error: Bad exit status from /var/tmp/rpm-tmp.53103 (%build)


Comment 5 Warren Togami 2006-02-27 21:01:40 UTC
BuildRequires: libXmu-devel


Comment 6 Ville Skyttä 2006-02-27 21:09:56 UTC
Warren, you noticed comment 3 and CLOSED WONTFIX, right?


Note You need to log in before you can comment on or make changes to this bug.