Description of problem: engine-backup calls tar in several different places/flows. In some of them, if tar emits errors, they are not logged to engine-backup's log, thus make it hard to diagnose failures, unless the user made sure to copy the errors from the terminal. Version-Release number of selected component (if applicable): Forever How reproducible: Always Steps to Reproduce: 1. Run engine-backup with a too-small /tmp 2. 3. Actual results: Fails, but log does not show why Expected results: Fails, with the error in the log Additional info: I never got actual reports from users requesting this to be fixed, but it recently failed in our CI, and it's not clear why, thus opening this bug. Already pushed a patch to log the specific place that failed in CI, will amend the patch later to log all such places in the code.
Verified on: ovirt-engine-4.3.10.3-0.1.master.el7.noarch Steps: 1. mounted a logical volume in /tmp 2. # engine-backup --file=engine.backup 3. # fallocate -l X /tmp/fake.file <--------- X being a value to almost fill the /tmp unit fully 4. # engine-backup --mode=restore --file=engine.backup --log=backup.log 5. # grep tar backup.log Results: backup restore failed, tar errors found in backup.log
4.3.10 was released