Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1832707

Summary: Errors from tar are not logged
Product: [oVirt] ovirt-engine Reporter: Yedidyah Bar David <didi>
Component: Backup-Restore.EngineAssignee: Yedidyah Bar David <didi>
Status: CLOSED CURRENTRELEASE QA Contact: Guilherme Santos <gdeolive>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 4.3.0CC: bugs, mtessun
Target Milestone: ovirt-4.3.10Flags: pm-rhel: ovirt-4.3+
pm-rhel: exception+
mtessun: planning_ack+
sbonazzo: devel_ack+
lleistne: testing_ack+
Target Release: 4.3.10.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.10.3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-10 10:57:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yedidyah Bar David 2020-05-07 06:46:38 UTC 
Description of problem:

engine-backup calls tar in several different places/flows. In some of them, if tar emits errors, they are not logged to engine-backup's log, thus make it hard to diagnose failures, unless the user made sure to copy the errors from the terminal.

Version-Release number of selected component (if applicable):
Forever

How reproducible:
Always

Steps to Reproduce:
1. Run engine-backup with a too-small /tmp
2.
3.

Actual results:
Fails, but log does not show why

Expected results:
Fails, with the error in the log

Additional info:
I never got actual reports from users requesting this to be fixed, but it recently failed in our CI, and it's not clear why, thus opening this bug. Already pushed a patch to log the specific place that failed in CI, will amend the patch later to log all such places in the code.
Comment 1 Guilherme Santos 2020-05-19 13:51:22 UTC 
Verified on:
ovirt-engine-4.3.10.3-0.1.master.el7.noarch

Steps:
1. mounted a logical volume in /tmp
2. # engine-backup --file=engine.backup
3. # fallocate -l X /tmp/fake.file  <--------- X being a value to almost fill the /tmp unit fully
4. # engine-backup --mode=restore --file=engine.backup --log=backup.log
5. # grep tar backup.log

Results:
backup restore failed, tar errors found in backup.log
Comment 2 Michal Skrivanek 2020-06-10 10:57:06 UTC 
4.3.10 was released