Bug 1832889 - [VMWare] Upgrade from OCS 4.4 to OCS 4.5 does not upgrade osd pods
Summary: [VMWare] Upgrade from OCS 4.4 to OCS 4.5 does not upgrade osd pods
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenShift Container Storage
Classification: Red Hat Storage
Component: rook
Version: 4.5
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: OCS 4.5.0
Assignee: Travis Nielsen
QA Contact: Elad
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-07 12:46 UTC by Rachael
Modified: 2020-09-23 09:07 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-15 10:16:49 UTC
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github rook rook pull 5524 0 None closed ceph: default the device set template name to data 2020-11-10 23:05:21 UTC
Red Hat Product Errata RHBA-2020:3754 0 None None None 2020-09-15 10:17:21 UTC

Comment 5 Travis Nielsen 2020-05-07 18:09:33 UTC 
There is an issue in the operator related to 4.5. This should not block the 4.4 release as the fix is needed in the 4.5 operator. 

2020-05-07T09:42:22.075116409Z 2020-05-07 09:42:22.075087 E | op-osd: unknown PVC template type "", valid names are "data" for the main OSD block and "metadata" for a metadata device to back the OSD.
2020-05-07T09:42:22.075116409Z 2020-05-07 09:42:22.075108 E | op-osd: unknown PVC template type "", valid names are "data" for the main OSD block and "metadata" for a metadata device to back the OSD.
2020-05-07T09:42:22.075133115Z 2020-05-07 09:42:22.075115 E | op-osd: unknown PVC template type "", valid names are "data" for the main OSD block and "metadata" for a metadata device to back the OSD.

@Seb can you take a look?
Comment 10 Sébastien Han 2020-05-12 08:19:16 UTC 
I wonder why the volumeClaimTemplates has no metadata name this is clearly a problem.
Will look at this.
Comment 11 Travis Nielsen 2020-05-12 20:06:39 UTC 
(In reply to leseb from comment #10)
> I wonder why the volumeClaimTemplates has no metadata name this is clearly a
> problem.
> Will look at this.

I'm assuming the operator should just interpret the empty string as a data template. OCS doesn't currently use metadata templates.
Comment 14 Sébastien Han 2020-05-22 08:57:13 UTC 
Synced with https://github.com/openshift/rook/pull/60
Comment 18 Elad 2020-08-10 16:02:03 UTC 
All pods, including OSD ones, are being upgraded when upgrade OCS 4.4 to 4.5.

oc -n openshift-storage --kubeconfig /home/jenkins/current-cluster-dir/openshift-cluster-dir/auth/kubeconfig get Pod rook-ceph-osd-0-6fd9dbdc46-9pv9j -n openshift-storage -o yaml

All the images: {'container': 'quay.io/rhceph-dev/rhceph@sha256:df67e134c9037707118a8533670b2f77647355a4af2fdc1247d79679cb6bb676', 'osd': 'quay.io/rhceph-dev/rhceph@sha256:df67e134c9037707118a8533670b2f77647355a4af2fdc1247d79679cb6bb676', 'config-init': 'quay.io/rhceph-dev/rook-ceph@sha256:164ff0868bf6d848a45b325a6eb3a2280e8978df69645b1b91d79ecca44da684', 'copy-bins': 'quay.io/rhceph-dev/rook-ceph@sha256:164ff0868bf6d848a45b325a6eb3a2280e8978df69645b1b91d79ecca44da684', 'blkdevmapper': 'quay.io/rhceph-dev/rhceph@sha256:df67e134c9037707118a8533670b2f77647355a4af2fdc1247d79679cb6bb676', 'chown-container-data-dir': 'quay.io/rhceph-dev/rhceph@sha256:df67e134c9037707118a8533670b2f77647355a4af2fdc1247d79679cb6bb676'} were successfully upgraded in: rook-ceph-osd-0-6fd9dbdc46-9pv9j!



===================================
Source OCS version - v4.4.2-510.ci
Target OCS version - 4.5.0-43.ci

OCP version - 4.5.0-0.nightly-2020-08-10-061547
Comment 20 errata-xmlrpc 2020-09-15 10:16:49 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift Container Storage 4.5.0 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3754
Note You need to log in before you can comment on or make changes to this bug.