Red Hat Bugzilla – Bug 183291
Review Request: ipod-sharp
Last modified: 2007-11-30 17:11:25 EST
Spec and SRPM from: http://people.redhat.com/caillon/RPMS/rawhide/banshee/ Description: ipod-sharp provides high-level feature support for Apple's iPod and binds libipoddevice. ipod-sharp is written in C# under Mono.
MD5Sums: 734956f3505f776c6920d4ae687f4bee ipod-sharp-0.5.15.tar.gz Good: * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * Builds fine in Mock (once missing BR (hal-devel) added to spec) * Package installs and uninstalls cleanly on FC5. * Make succeeds even when %{_smp_mflags} is defined Bad: * Missing Build Requirement for hal-devel * Source URL isn't canonical. Should be http://banshee-project.org/files/%{name}/%{name}-%{version}.tar.gz * License is LGPL, not GPL. * Add COPYING file to package. * rpmlint gives the following errors: E: ipod-sharp no-binary E: ipod-sharp only-non-binary-in-usr-lib W: ipod-sharp no-documentation W: ipod-sharp devel-file-in-non-devel-package /usr/lib/pkgconfig/ipod-sharp.pc W: ipod-sharp devel-file-in-non-devel-package /usr/lib/pkgconfig/ipod-sharp-ui.pc Most of these errors can be ignored, or be easily corrected (like adding the COPYING file). You should probably add a -devel sub-package to handle the *.pc files, though. APPROVED, once these items are corrected.
This has been built hasn't it? If so, this bug can be closed.
Yeah, I'm just lazy/forgetful. ;-)