Bug 1832920 - puppet/extraconfig/pre_deploy/per_node.yaml does not work with py3
Summary: puppet/extraconfig/pre_deploy/per_node.yaml does not work with py3
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-heat-templates
Version: 16.0 (Train)
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: rc
: 16.1 (Train on RHEL 8.2)
Assignee: Giulio Fidente
QA Contact: David Rosenfeld
URL:
Whiteboard:
Depends On:
Blocks: 1595325 1715964
TreeView+ depends on / blocked
 
Reported: 2020-05-07 13:37 UTC by Giulio Fidente
Modified: 2023-09-07 23:09 UTC (History)
5 users (show)

Fixed In Version: openstack-tripleo-heat-templates-11.3.2-0.20200530033438.0dfce4e.el8ost
Doc Type: Bug Fix
Doc Text:
Before this update, the `ExtraConfigPre` `per_node` script was not compatible with Python 3. As a result, the overcloud deployment failed at the step `TASK [Run deployment NodeSpecificDeployment]` with the message `SyntaxError: invalid syntax`. + With this update, the `ExtraConfigPre` `per_node` script is compatible with Python 3 and you can provision custom `per_node` hieradata.
Clone Of:
Environment:
Last Closed: 2020-07-29 07:52:21 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1877378 0 None None None 2020-05-07 13:41:28 UTC
OpenStack gerrit 726150 0 None MERGED Make per_node.yaml py3 safe 2020-12-10 18:35:51 UTC
OpenStack gerrit 727869 0 None MERGED Make per_node.yaml py3 safe 2020-12-10 18:35:51 UTC
Red Hat Issue Tracker OSP-28427 0 None None None 2023-09-07 23:09:32 UTC
Red Hat Product Errata RHBA-2020:3148 0 None None None 2020-07-29 07:52:42 UTC

Description Giulio Fidente 2020-05-07 13:37:18 UTC 
Enabling per_node ExtraConfigPre will cause error on deployments because the embedded python code doesn't work with py3

For example:

print json.dumps(cnt.get('4C4C4544-0059-4610-8032-C7C04F584B32', {}))
Comment 5 Alex McLeod 2020-06-16 12:29:51 UTC 
If this bug requires doc text for errata release, please set the 'Doc Type' and provide draft text according to the template in the 'Doc Text' field. The documentation team will review, edit, and approve the text.

If this bug does not require doc text, please set the 'requires_doc_text' flag to '-'.
Comment 7 David Rosenfeld 2020-07-07 22:48:28 UTC 
Verified by creating ceph-osd-config.yaml file that contained:

resource_registry:
  OS::TripleO::CephStorageExtraConfigPre: /usr/share/openstack-tripleo-heat-templates/puppet/extraconfig/pre_deploy/per_node.yaml

and some parameter_defaults.


Added -e /home/stack/templates/ceph-osd-config.yaml to deployment command. After executing deployment the error: 'SyntaxError: invalid syntax' was no longer seen in the step:
TASK [Run deployment NodeSpecificDeployment]
Comment 9 errata-xmlrpc 2020-07-29 07:52:21 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3148
Note You need to log in before you can comment on or make changes to this bug.