Spec URL: https://jjames.fedorapeople.org/ocaml-ppx-compare/ocaml-ppx-compare.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-ppx-compare/ocaml-ppx-compare-0.13.0-1.fc33.src.rpm Fedora Account System Username: jjames Description: Ppx_compare is a ppx rewriter that derives comparison and equality functions from type representations. The scaffolded functions are usually much faster than OCaml's `Pervasives.compare` and `Pervasives.(=)`. Scaffolding functions also give more flexibility by allowing them to be overridden for a specific type, and more safety by making sure that only comparable values are compared.
Hi Jerry, I'll review this now that inline-test has been approved. Could you perhaps review this in return if you have some time please? https://bugzilla.redhat.com/show_bug.cgi?id=1839352 Cheers,
I'm on it!
Looks good. No blockers but a few tiny issues that need double-checking. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ^ False positive. [x]: Requires correct, justified where necessary. ^ Rather long list, but it looks OK. Please do double-check [?]: Latest version is packaged. ^ Uh, upstream just released a new version 2 days ago. https://github.com/janestreet/ppx_compare/releases [?]: Patches link to upstream bugs/comments/lists or are otherwise justified. ^ Should the patch be sent upstream? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 20 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora- reviews/1833475-ocaml-ppx-compare/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. ^ Rather long list, but it looks OK. Please do double-check [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [?]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 133120 bytes in 25 files. ^ Up to you really, it's all in the -devel sub-package so I think it's OK. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). ^ Looks OK. [?]: Package functions as described. ^ Not tested this out. [?]: Latest version is packaged. ^ Uh, upstream just released a new version 2 days ago. https://github.com/janestreet/ppx_compare/releases [x]: Package does not include license text files separate from upstream. [?]: Patches link to upstream bugs/comments/lists or are otherwise justified. ^ Should the patch be sent upstream? [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocaml-ppx-compare-0.13.0-1.fc33.x86_64.rpm ocaml-ppx-compare-devel-0.13.0-1.fc33.x86_64.rpm ocaml-ppx-compare-debuginfo-0.13.0-1.fc33.x86_64.rpm ocaml-ppx-compare-debugsource-0.13.0-1.fc33.x86_64.rpm ocaml-ppx-compare-0.13.0-1.fc33.src.rpm ocaml-ppx-compare.x86_64: W: spelling-error %description -l en_US rewriter -> rewrite, rewrites, re writer ocaml-ppx-compare.x86_64: W: spelling-error %description -l en_US scaffolded -> scaffold ed, scaffold-ed, scaffold ocaml-ppx-compare.src: W: spelling-error %description -l en_US rewriter -> rewrite, rewrites, re writer ocaml-ppx-compare.src: W: spelling-error %description -l en_US scaffolded -> scaffold ed, scaffold-ed, scaffold 5 packages and 0 specfiles checked; 0 errors, 4 warnings. ^ Nothing to see here. Rpmlint (debuginfo) ------------------- Checking: ocaml-ppx-compare-debuginfo-0.13.0-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. ocaml-ppx-compare-devel.x86_64: W: invalid-url URL: https://github.com/janestreet/ppx_compare <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. ocaml-ppx-compare.x86_64: W: spelling-error %description -l en_US rewriter -> rewrite, rewrites, re writer ocaml-ppx-compare.x86_64: W: spelling-error %description -l en_US scaffolded -> scaffold ed, scaffold-ed, scaffold ocaml-ppx-compare.x86_64: W: invalid-url URL: https://github.com/janestreet/ppx_compare <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. ocaml-ppx-compare-debuginfo.x86_64: W: invalid-url URL: https://github.com/janestreet/ppx_compare <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. ocaml-ppx-compare-debugsource.x86_64: W: invalid-url URL: https://github.com/janestreet/ppx_compare <urlopen error [Errno -2] Name or service not known> 4 packages and 0 specfiles checked; 0 errors, 6 warnings. ^ All OK. Nothing to see here. Source checksums ---------------- https://github.com/janestreet/ppx_compare/archive/v0.13.0/ppx_compare-0.13.0.tar.gz : CHECKSUM(SHA256) this package : 21e8abe479fd907cccca2f106a148ed51409a7988e184826bc571101f7cc93ce CHECKSUM(SHA256) upstream package : 21e8abe479fd907cccca2f106a148ed51409a7988e184826bc571101f7cc93ce Requires -------- ocaml-ppx-compare (rpmlib, GLIBC filtered): libc.so.6()(64bit) ocaml(Ast_mapper) ocaml(Asttypes) ocaml(Base) ocaml(Base__) ocaml(Base__Applicative) ocaml(Base__Applicative_intf) ocaml(Base__Array) ocaml(Base__Backtrace) ocaml(Base__Binary_searchable) ocaml(Base__Binary_searchable_intf) ocaml(Base__Blit) ocaml(Base__Blit_intf) ocaml(Base__Bool) ocaml(Base__Buffer) ocaml(Base__Buffer_intf) ocaml(Base__Bytes) ocaml(Base__Bytes_set_primitives) ocaml(Base__Char) ocaml(Base__Comparable) ocaml(Base__Comparable_intf) ocaml(Base__Comparator) ocaml(Base__Comparisons) ocaml(Base__Container) ocaml(Base__Container_intf) ocaml(Base__Equal) ocaml(Base__Error) ocaml(Base__Exn) ocaml(Base__Field) ocaml(Base__Float) ocaml(Base__Floatable) ocaml(Base__Formatter) ocaml(Base__Hash) ocaml(Base__Hash_intf) ocaml(Base__Identifiable) ocaml(Base__Import) ocaml(Base__Import0) ocaml(Base__Indexed_container) ocaml(Base__Indexed_container_intf) ocaml(Base__Info) ocaml(Base__Info_intf) ocaml(Base__Int) ocaml(Base__Int0) ocaml(Base__Int32) ocaml(Base__Int63) ocaml(Base__Int63_emul) ocaml(Base__Int64) ocaml(Base__Int_intf) ocaml(Base__Intable) ocaml(Base__Invariant) ocaml(Base__Invariant_intf) ocaml(Base__Lazy) ocaml(Base__List) ocaml(Base__Maybe_bound) ocaml(Base__Monad) ocaml(Base__Monad_intf) ocaml(Base__Nativeint) ocaml(Base__Option) ocaml(Base__Or_error) ocaml(Base__Ordering) ocaml(Base__Poly0) ocaml(Base__Ppx_compare_lib) ocaml(Base__Ppx_hash_lib) ocaml(Base__Ppx_sexp_conv_lib) ocaml(Base__Pretty_printer) ocaml(Base__Printf) ocaml(Base__Random) ocaml(Base__Ref) ocaml(Base__Result) ocaml(Base__Sequence) ocaml(Base__Sexp) ocaml(Base__Sexp_with_comparable) ocaml(Base__Sexpable) ocaml(Base__Sexplib) ocaml(Base__Sign) ocaml(Base__Sign0) ocaml(Base__Sign_or_nan) ocaml(Base__Source_code_position0) ocaml(Base__Staged) ocaml(Base__String) ocaml(Base__String0) ocaml(Base__Stringable) ocaml(Base__Sys0) ocaml(Base__T) ocaml(Base__Unit) ocaml(Base__Validate) ocaml(Base_internalhash_types) ocaml(Build_path_prefix_map) ocaml(Caml) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalMenhirLib) ocaml(CamlinternalOO) ocaml(Clflags) ocaml(Config) ocaml(Docstrings) ocaml(Lexer) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Migrate_parsetree) ocaml(Migrate_parsetree__) ocaml(Migrate_parsetree__Ast_402) ocaml(Migrate_parsetree__Ast_403) ocaml(Migrate_parsetree__Ast_404) ocaml(Migrate_parsetree__Ast_405) ocaml(Migrate_parsetree__Ast_406) ocaml(Migrate_parsetree__Ast_407) ocaml(Migrate_parsetree__Ast_408) ocaml(Migrate_parsetree__Ast_408_helper) ocaml(Migrate_parsetree__Ast_409) ocaml(Migrate_parsetree__Ast_409_helper) ocaml(Migrate_parsetree__Ast_410) ocaml(Migrate_parsetree__Ast_411) ocaml(Migrate_parsetree__Locations) ocaml(Migrate_parsetree__Migrate_parsetree_compiler_functions) ocaml(Migrate_parsetree__Migrate_parsetree_driver) ocaml(Migrate_parsetree__Migrate_parsetree_versions) ocaml(Migrate_parsetree__Option) ocaml(Migrate_parsetree__Stdlib0) ocaml(Misc) ocaml(Ocaml_common) ocaml(Ocaml_shadow) ocaml(Outcometree) ocaml(Parse) ocaml(Parser) ocaml(Parsetree) ocaml(Ppx_compare_expander) ocaml(Ppx_compare_expander__) ocaml(Ppx_compare_expander__Ppx_compare_expander_intf) ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Context_free) ocaml(Ppxlib__Deriving) ocaml(Ppxlib__Driver) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Extension) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Name) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Lexer_helper) ocaml(Ppxlib_ast__Location_helper) ocaml(Ppxlib_traverse_builtins) ocaml(Profile) ocaml(Sexplib0) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_error) ocaml(Shadow_stdlib) ocaml(Stdio) ocaml(Stdio__) ocaml(Stdio__Import) ocaml(Stdio__In_channel) ocaml(Stdio__Out_channel) ocaml(Stdlib) ocaml(Stdlib__arg) ocaml(Stdlib__array) ocaml(Stdlib__buffer) ocaml(Stdlib__digest) ocaml(Stdlib__format) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__int64) ocaml(Stdlib__lazy) ocaml(Stdlib__lexing) ocaml(Stdlib__list) ocaml(Stdlib__listLabels) ocaml(Stdlib__map) ocaml(Stdlib__moreLabels) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__parsing) ocaml(Stdlib__pervasives) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__seq) ocaml(Stdlib__set) ocaml(Stdlib__stdLabels) ocaml(Stdlib__string) ocaml(Stdlib__stringLabels) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Syntaxerr) ocaml(Type_immediacy) ocaml(Warnings) ocamlx(CamlinternalOO) rtld(GNU_HASH) ocaml-ppx-compare-devel (rpmlib, GLIBC filtered): ocaml(Ast_mapper) ocaml(Asttypes) ocaml(Base) ocaml(Base__) ocaml(Base__Applicative) ocaml(Base__Applicative_intf) ocaml(Base__Array) ocaml(Base__Backtrace) ocaml(Base__Binary_searchable) ocaml(Base__Binary_searchable_intf) ocaml(Base__Blit) ocaml(Base__Blit_intf) ocaml(Base__Bool) ocaml(Base__Buffer) ocaml(Base__Buffer_intf) ocaml(Base__Bytes) ocaml(Base__Bytes_set_primitives) ocaml(Base__Char) ocaml(Base__Comparable) ocaml(Base__Comparable_intf) ocaml(Base__Comparator) ocaml(Base__Comparisons) ocaml(Base__Container) ocaml(Base__Container_intf) ocaml(Base__Equal) ocaml(Base__Error) ocaml(Base__Exn) ocaml(Base__Field) ocaml(Base__Float) ocaml(Base__Floatable) ocaml(Base__Formatter) ocaml(Base__Hash) ocaml(Base__Hash_intf) ocaml(Base__Identifiable) ocaml(Base__Import) ocaml(Base__Import0) ocaml(Base__Indexed_container) ocaml(Base__Indexed_container_intf) ocaml(Base__Info) ocaml(Base__Info_intf) ocaml(Base__Int) ocaml(Base__Int0) ocaml(Base__Int32) ocaml(Base__Int63) ocaml(Base__Int63_emul) ocaml(Base__Int64) ocaml(Base__Int_intf) ocaml(Base__Intable) ocaml(Base__Invariant) ocaml(Base__Invariant_intf) ocaml(Base__Lazy) ocaml(Base__List) ocaml(Base__Maybe_bound) ocaml(Base__Monad) ocaml(Base__Monad_intf) ocaml(Base__Nativeint) ocaml(Base__Option) ocaml(Base__Or_error) ocaml(Base__Ordering) ocaml(Base__Poly0) ocaml(Base__Ppx_compare_lib) ocaml(Base__Ppx_hash_lib) ocaml(Base__Ppx_sexp_conv_lib) ocaml(Base__Pretty_printer) ocaml(Base__Printf) ocaml(Base__Random) ocaml(Base__Ref) ocaml(Base__Result) ocaml(Base__Sequence) ocaml(Base__Sexp) ocaml(Base__Sexp_with_comparable) ocaml(Base__Sexpable) ocaml(Base__Sexplib) ocaml(Base__Sign) ocaml(Base__Sign0) ocaml(Base__Sign_or_nan) ocaml(Base__Source_code_position0) ocaml(Base__Staged) ocaml(Base__String) ocaml(Base__String0) ocaml(Base__Stringable) ocaml(Base__Sys0) ocaml(Base__T) ocaml(Base__Unit) ocaml(Base__Validate) ocaml(Base_internalhash_types) ocaml(Build_path_prefix_map) ocaml(Caml) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalMenhirLib) ocaml(CamlinternalOO) ocaml(Clflags) ocaml(Config) ocaml(Docstrings) ocaml(Lexer) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Migrate_parsetree) ocaml(Migrate_parsetree__) ocaml(Migrate_parsetree__Ast_402) ocaml(Migrate_parsetree__Ast_403) ocaml(Migrate_parsetree__Ast_404) ocaml(Migrate_parsetree__Ast_405) ocaml(Migrate_parsetree__Ast_406) ocaml(Migrate_parsetree__Ast_407) ocaml(Migrate_parsetree__Ast_408) ocaml(Migrate_parsetree__Ast_408_helper) ocaml(Migrate_parsetree__Ast_409) ocaml(Migrate_parsetree__Ast_409_helper) ocaml(Migrate_parsetree__Ast_410) ocaml(Migrate_parsetree__Ast_411) ocaml(Migrate_parsetree__Locations) ocaml(Migrate_parsetree__Migrate_parsetree_compiler_functions) ocaml(Migrate_parsetree__Migrate_parsetree_driver) ocaml(Migrate_parsetree__Migrate_parsetree_versions) ocaml(Migrate_parsetree__Option) ocaml(Migrate_parsetree__Stdlib0) ocaml(Misc) ocaml(Ocaml_common) ocaml(Ocaml_shadow) ocaml(Outcometree) ocaml(Parse) ocaml(Parser) ocaml(Parsetree) ocaml(Ppx_compare_expander) ocaml(Ppx_compare_expander__) ocaml(Ppx_compare_expander__Ppx_compare_expander_intf) ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Context_free) ocaml(Ppxlib__Deriving) ocaml(Ppxlib__Driver) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Extension) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Name) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Lexer_helper) ocaml(Ppxlib_ast__Location_helper) ocaml(Ppxlib_traverse_builtins) ocaml(Profile) ocaml(Sexplib0) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_error) ocaml(Shadow_stdlib) ocaml(Stdio) ocaml(Stdio__) ocaml(Stdio__Import) ocaml(Stdio__In_channel) ocaml(Stdio__Out_channel) ocaml(Stdlib) ocaml(Stdlib__arg) ocaml(Stdlib__array) ocaml(Stdlib__buffer) ocaml(Stdlib__digest) ocaml(Stdlib__format) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__int64) ocaml(Stdlib__lazy) ocaml(Stdlib__lexing) ocaml(Stdlib__list) ocaml(Stdlib__listLabels) ocaml(Stdlib__map) ocaml(Stdlib__moreLabels) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__parsing) ocaml(Stdlib__pervasives) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__seq) ocaml(Stdlib__set) ocaml(Stdlib__stdLabels) ocaml(Stdlib__string) ocaml(Stdlib__stringLabels) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Syntaxerr) ocaml(Type_immediacy) ocaml(Warnings) ocaml-base-devel(x86-64) ocaml-ppx-compare(x86-64) ocaml-ppxlib-devel(x86-64) ocamlx(CamlinternalOO) ocaml-ppx-compare-debuginfo (rpmlib, GLIBC filtered): ocaml-ppx-compare-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-ppx-compare: ocaml(Ppx_compare) ocaml(Ppx_compare_expander) ocaml(Ppx_compare_expander__) ocaml(Ppx_compare_expander__Ppx_compare_expander_intf) ocaml(Ppx_compare_lib) ocaml-ppx-compare ocaml-ppx-compare(x86-64) ocamlx(Ppx_compare) ocamlx(Ppx_compare_expander) ocamlx(Ppx_compare_expander__) ocamlx(Ppx_compare_expander__Ppx_compare_expander_intf) ocamlx(Ppx_compare_lib) ocaml-ppx-compare-devel: ocaml(Ppx_compare) ocaml(Ppx_compare_expander) ocaml(Ppx_compare_expander__) ocaml(Ppx_compare_expander__Ppx_compare_expander_intf) ocaml(Ppx_compare_lib) ocaml-ppx-compare-devel ocaml-ppx-compare-devel(x86-64) ocamlx(Ppx_compare) ocamlx(Ppx_compare_expander) ocamlx(Ppx_compare_expander__) ocamlx(Ppx_compare_expander__Ppx_compare_expander_intf) ocamlx(Ppx_compare_lib) ocaml-ppx-compare-debuginfo: debuginfo(build-id) ocaml-ppx-compare-debuginfo ocaml-ppx-compare-debuginfo(x86-64) ocaml-ppx-compare-debugsource: ocaml-ppx-compare-debugsource ocaml-ppx-compare-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1833475 -o --no-bootstrap-chroot --no-cleanup-after --no-clean --enablerepo=local Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Ocaml, C/C++, Generic Disabled plugins: SugarActivity, Java, Python, PHP, fonts, Haskell, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Ankur Sinha (FranciscoD) from comment #3) > [x]: Requires correct, justified where necessary. > ^ > Rather long list, but it looks OK. Please do double-check Looks okay to me. > [?]: Latest version is packaged. > ^ > Uh, upstream just released a new version 2 days ago. > https://github.com/janestreet/ppx_compare/releases Yes, but we can't use it yet. If you look at the ocaml-ppx* packages we currently have in Fedora, you'll note that several of them are at version 0.13. They share an upstream (Jane Street), and are released together. The 0.14 versions are out, but we'll have to update them all together. I haven't had time to do the mock builds yet to verify that nothing will break. So, for now, we need version 0.13 of this package; it will be updated to 0.14 when all the others are. > [?]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > ^ > Should the patch be sent upstream? No, because another change to dune in the meantime made it unnecessary. I have dropped the patch. New URLs: Spec URL: https://jjames.fedorapeople.org/ocaml-ppx-compare/ocaml-ppx-compare.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-ppx-compare/ocaml-ppx-compare-0.13.0-2.fc33.src.rpm
OK, that looks good! XXX APPROVED XXX
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ppx-compare
FEDORA-2020-d4b6cff531 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d4b6cff531
FEDORA-2020-d4b6cff531 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d4b6cff531 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d4b6cff531 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-d4b6cff531 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.