Bug 1833511 - Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
Summary: Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ryan O'Hara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1331958 (view as bug list)
Depends On:
Blocks: FE-NEEDSPONSOR 1773720
TreeView+ depends on / blocked
 
Reported: 2020-05-08 19:05 UTC by Brandon Perkins
Modified: 2020-08-02 14:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-05 15:29:19 UTC
Type: Bug
Embargoed:
rohara: fedora-review+


Attachments (Terms of Use)

Description Brandon Perkins 2020-05-08 19:05:52 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-dustinkirkland-petname.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-32-x86_64/01373678-golang-github-dustinkirkland-petname/golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc32.src.rpm
Description: petname provides an RFC1178 implementation.

Fedora Account System Username: bdperkin
Note: These are my first packages and I need a sponsor.  The packages include: golang-github-gehirninc-crypt, golang-github-haproxytech-models, golang-github-haproxytech-config-parser, golang-github-haproxytech-client-native, and golang-github-haproxytech-dataplaneapi.
Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-32-x86_64/01373678-golang-github-dustinkirkland-petname/

Comment 2 Brandon Perkins 2020-05-08 22:39:24 UTC
Besides the -devel package being generated and producing a dataplaneapi build, I've also verified the binary and man page shipped with this package:

$ man petname | head
golang-petname(1)                                           golang-petname                                          golang-petname(1)

NAME
       golang-petname  -  utility  to generate "pet names", consisting of a random combination of adverbs, an adjective, and a proper
       name

SYNOPSIS
       golang-petname [-w|--words INT] [-s|--separator STR]

OPTIONS
$ petname
warm-mink
$ petname --words 1
guinea
$ petname --words 3
slowly-helpful-lamb
$ petname --words 4
adversely-painfully-driving-quetzal
$ petname --separator ":"
eternal:insect
$ petname --separator "" --words 3
nationallyelegantstarling

Comment 3 Brandon Perkins 2020-05-08 23:10:28 UTC
In my own review of fedora-review package, I didn't notice much.  There were no failures.

> ===== MUST items =====
> 
> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
>      other legal requirements as defined in the legal section of Packaging
>      Guidelines.

License     : ASL 2.0
$ rpm -qL golang-github-dustinkirkland-petname
/usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE
$ head -5 /usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE

                                 Apache License
                           Version 2.0, January 2004
                        http://www.apache.org/licenses/

> [ ]: License field in the package spec file matches the actual license.

$ licensecheck /usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE
/usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE: *No copyright* Apache License (v2.0)

> [ ]: License file installed when any subpackage combination is installed.

See discussion at https://bugzilla.redhat.com/show_bug.cgi?id=1773720#c10

> [ ]: Package does not own files or directories owned by other packages.
>      Note: Dirs in package are owned also by:
>      /usr/share/gocode/src/github.com

All go packages "own" this directory

> [ ]: %build honors applicable compiler flags or justifies otherwise.
> [ ]: Package contains no bundled libraries without FPC exception.
> [ ]: Changelog in prescribed format.
> [ ]: Sources contain only permissible code or content.

All okay

> [ ]: Package contains desktop file if it is a GUI application.

N/A

> [ ]: Development files must be in a -devel package
> [ ]: Package uses nothing in %doc for runtime.
> [ ]: Package consistently uses macros (instead of hard-coded directory
>      names).
> [ ]: Package is named according to the Package Naming Guidelines.
> [ ]: Package does not generate any conflict.
> [ ]: Package obeys FHS, except libexecdir and /usr/target.
> [ ]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.
> [ ]: Requires correct, justified where necessary.
> [ ]: Spec file is legible and written in American English.

All okay

> [ ]: Package contains systemd file(s) if in need.

N/A

> [ ]: Useful -debuginfo package or justification otherwise.
> [ ]: Package is not known to require an ExcludeArch tag.

Both okay

> [ ]: Large documentation must go in a -doc subpackage. Large could be size
>      (~1MB) or number of files.
>      Note: Documentation size is 40960 bytes in 4 files.

Not needed

> [ ]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
>      one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
>      Note: There are rpmlint messages (see attachment).

Checking: golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

> [x]: If (and only if) the source package includes the text of the
>      license(s) in its own file, then that file, containing the text of the
>      license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package must own all directories that it creates.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package must not depend on deprecated() packages.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>      work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
>      provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
>      %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
> 
> ===== SHOULD items =====
> 
> Generic:
> [ ]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.

$ tar -tvzf SOURCES/golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667.tar.gz golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667/LICENSE
-rw-rw-r-- root/root     11358 2019-11-29 16:52 golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667/LICENSE

> [ ]: Final provides and requires are sane (see attachments).

Okay

> [ ]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
>      github-dustinkirkland-petname-devel

Okay

> [ ]: Package functions as described.

Yes, see comment 2

> [ ]: Latest version is packaged.
> [ ]: Package does not include license text files separate from upstream.
> [ ]: Sources are verified with gpgverify first in %prep if upstream
>      publishes signatures.
>      Note: gpgverify is not used.

All okay

> [ ]: Description and summary sections in the package spec file contains
>      translations for supported Non-English languages, if available.

N/A

> [ ]: %check is present and all tests pass.
> [ ]: Packages should try to preserve timestamps of original installed
>      files.

Both okay

> [x]: Reviewer should test that the package builds in mock.
> [x]: Buildroot is not present
> [x]: Package has no %clean section with rm -rf %{buildroot} (or
>      $RPM_BUILD_ROOT)
> [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
> [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> [x]: Sources can be downloaded from URI in Source: tag
> [x]: SourceX is a working URL.
> [x]: Package should compile and build into binary rpms on all supported
>      architectures.
> [x]: Spec use %global instead of %define unless justified.
> 
> ===== EXTRA items =====
> 
> Generic:
> [x]: Rpmlint is run on debuginfo package(s).
>      Note: No rpmlint messages.
> [x]: Rpmlint is run on all installed packages.
>      Note: There are rpmlint messages (see attachment).
> [x]: Large data in /usr/share should live in a noarch subpackage if package
>      is arched.
> [x]: Spec file according to URL is the same as in SRPM.
> 
> 
> Rpmlint
> -------
> Checking: golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
>           golang-github-dustinkirkland-petname-devel-0-0.1.20200508git8e5a1ed.fc33.noarch.rpm
>           golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
>           golang-github-dustinkirkland-petname-debugsource-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
>           golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc33.src.rpm
> golang-github-dustinkirkland-petname-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dustinkirkland/golang-petname/.goipath
> golang-github-dustinkirkland-petname-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-dustinkirkland-petname.
> 5 packages and 0 specfiles checked; 1 errors, 1 warnings.
> 

All expected

> 
> 
> 
> Rpmlint (debuginfo)
> -------------------
> Checking: golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> 
> 
> 
> 
> Rpmlint (installed packages)
> ----------------------------
> golang-github-dustinkirkland-petname-devel.noarch: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known>
> golang-github-dustinkirkland-petname-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dustinkirkland/golang-petname/.goipath
> golang-github-dustinkirkland-petname-debuginfo.x86_64: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known>
> golang-github-dustinkirkland-petname-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-dustinkirkland-petname.
> golang-github-dustinkirkland-petname-debugsource.x86_64: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known>
> golang-github-dustinkirkland-petname.x86_64: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known>
> 4 packages and 0 specfiles checked; 1 errors, 5 warnings.
> 

All expected

> 
> 
> Source checksums
> ----------------
> https://github.com/dustinkirkland/golang-petname/archive/8e5a1ed0cff0384869564ec1c086c6467a025667/golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667.tar.gz :
>   CHECKSUM(SHA256) this package     : 29550cf760595d7c022cd04facd9ef81261953f53b5d8d18ca6cbe432f92fba3
>   CHECKSUM(SHA256) upstream package : 29550cf760595d7c022cd04facd9ef81261953f53b5d8d18ca6cbe432f92fba3
> 
> 
> Requires
> --------
> golang-github-dustinkirkland-petname (rpmlib, GLIBC filtered):
>     libc.so.6()(64bit)
>     libpthread.so.0()(64bit)
>     rtld(GNU_HASH)
> 
> golang-github-dustinkirkland-petname-devel (rpmlib, GLIBC filtered):
>     go-filesystem
> 
> golang-github-dustinkirkland-petname-debuginfo (rpmlib, GLIBC filtered):
> 
> golang-github-dustinkirkland-petname-debugsource (rpmlib, GLIBC filtered):
> 
> 
> 
> Provides
> --------
> golang-github-dustinkirkland-petname:
>     golang-github-dustinkirkland-petname
>     golang-github-dustinkirkland-petname(x86-64)
> 
> golang-github-dustinkirkland-petname-devel:
>     golang(github.com/dustinkirkland/golang-petname)
>     golang(github.com/dustinkirkland/golang-petname)(commit=8e5a1ed0cff0384869564ec1c086c6467a025667)
>     golang-github-dustinkirkland-petname-devel
>     golang-ipath(github.com/dustinkirkland/golang-petname)
>     golang-ipath(github.com/dustinkirkland/golang-petname)(commit=8e5a1ed0cff0384869564ec1c086c6467a025667)
> 
> golang-github-dustinkirkland-petname-debuginfo:
>     debuginfo(build-id)
>     golang-github-dustinkirkland-petname-debuginfo
>     golang-github-dustinkirkland-petname-debuginfo(x86-64)
> 
> golang-github-dustinkirkland-petname-debugsource:
>     golang-github-dustinkirkland-petname-debugsource
>     golang-github-dustinkirkland-petname-debugsource(x86-64)
> 
> 
> 
> Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
> Command line :/usr/bin/fedora-review -L /home/bperkins/git/haproxytech/RPMS -b 1833511
> Buildroot used: fedora-rawhide-x86_64
> Active plugins: Generic, Shell-api
> Disabled plugins: Haskell, Java, fonts, C/C++, Python, R, Perl, SugarActivity, Ocaml, PHP
> Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
> 
> Built with local dependencies:
>     /home/bperkins/git/haproxytech/RPMS/golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-dustinkirkland-petname-devel-0-0.1.20200508git8e5a1ed.fc33.noarch.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-dustinkirkland-petname-debugsource-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-gehirninc-crypt-devel-0-0.3.20200415gitbb7000b.fc33.noarch.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-client-native-devel-2.0.1-1.fc33.noarch.rpm
>     /home/bperkins/git/haproxytech/RPMS/compat-golang-github-haproxytech-client-native-2-devel-2.0.1-1.fc33.noarch.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-config-parser-devel-2.0.1-1.fc33.noarch.rpm
>     /home/bperkins/git/haproxytech/RPMS/compat-golang-github-haproxytech-config-parser-2-devel-2.0.1-1.fc33.noarch.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-2.0.1-1.fc33.x86_64.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-2.0.1-1.fc33.x86_64.rpm
>     /home/bperkins/git/haproxytech/RPMS/compat-golang-github-haproxytech-dataplaneapi-2-devel-2.0.1-1.fc33.noarch.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-debugsource-2.0.1-1.fc33.x86_64.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-devel-2.0.1-1.fc33.noarch.rpm
>     /home/bperkins/git/haproxytech/RPMS/compat-golang-github-haproxytech-models-2-devel-2.0.1-1.fc33.noarch.rpm
>     /home/bperkins/git/haproxytech/RPMS/golang-github-haproxytech-models-devel-2.0.1-1.fc33.noarch.rpm

Comment 4 Ryan O'Hara 2020-06-01 18:36:57 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Unknown or generated". 1 files have
     unknown license. Detailed output of licensecheck in
     /home/rohara/1833511-golang-github-dustinkirkland-
     petname/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.

All good.

[ ]: Package does not own files or directories owned by other packages.

* snip *

[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.

All good.

[ ]: Package contains desktop file if it is a GUI application.

N/A

[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines

All good.

[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     github-dustinkirkland-petname-devel
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.

All above seem fine. Might want to check if the dataplaneapi packages that depend on this need stricter version requirements

[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.

N/A

[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.

Looks fine.

[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
          golang-github-dustinkirkland-petname-devel-0-0.1.20200508git8e5a1ed.fc33.noarch.rpm
          golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
          golang-github-dustinkirkland-petname-debugsource-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
          golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc33.src.rpm
golang-github-dustinkirkland-petname-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dustinkirkland/golang-petname/.goipath
golang-github-dustinkirkland-petname-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-dustinkirkland-petname.
5 packages and 0 specfiles checked; 1 errors, 1 warnings.

The warning seems normal for golang pacakges. I think we've seen it in all other packages related to this dataplaneapi effort.
The error appears to be complaining about the length of the resulting -debuginfo package name. We've discussed with others to see if this could be avoided, but we're stuck with it. These are OK.


Rpmlint (debuginfo)
-------------------
Checking: golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.

No idea what these means.

perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
golang-github-dustinkirkland-petname-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-dustinkirkland-petname.
golang-github-dustinkirkland-petname-debugsource.x86_64: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
golang-github-dustinkirkland-petname-debuginfo.x86_64: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
golang-github-dustinkirkland-petname.x86_64: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
golang-github-dustinkirkland-petname-devel.noarch: W: invalid-url URL: https://github.com/dustinkirkland/golang-petname <urlopen error [Errno -2] Name or service not known>
golang-github-dustinkirkland-petname-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dustinkirkland/golang-petname/.goipath
4 packages and 0 specfiles checked; 1 errors, 5 warnings.

Same as above, but I am convinced there is a way to fix this invalid-url problem. Again, we're hit this before. Seems ok.

Source checksums
----------------
https://github.com/dustinkirkland/golang-petname/archive/8e5a1ed0cff0384869564ec1c086c6467a025667/golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667.tar.gz :
  CHECKSUM(SHA256) this package     : 29550cf760595d7c022cd04facd9ef81261953f53b5d8d18ca6cbe432f92fba3
  CHECKSUM(SHA256) upstream package : 29550cf760595d7c022cd04facd9ef81261953f53b5d8d18ca6cbe432f92fba3


Requires
--------
golang-github-dustinkirkland-petname (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

golang-github-dustinkirkland-petname-devel (rpmlib, GLIBC filtered):
    go-filesystem

golang-github-dustinkirkland-petname-debuginfo (rpmlib, GLIBC filtered):

golang-github-dustinkirkland-petname-debugsource (rpmlib, GLIBC filtered):



Provides
--------
golang-github-dustinkirkland-petname:
    golang-github-dustinkirkland-petname
    golang-github-dustinkirkland-petname(x86-64)

golang-github-dustinkirkland-petname-devel:
    golang(github.com/dustinkirkland/golang-petname)
    golang(github.com/dustinkirkland/golang-petname)(commit=8e5a1ed0cff0384869564ec1c086c6467a025667)
    golang-github-dustinkirkland-petname-devel
    golang-ipath(github.com/dustinkirkland/golang-petname)
    golang-ipath(github.com/dustinkirkland/golang-petname)(commit=8e5a1ed0cff0384869564ec1c086c6467a025667)

golang-github-dustinkirkland-petname-debuginfo:
    debuginfo(build-id)
    golang-github-dustinkirkland-petname-debuginfo
    golang-github-dustinkirkland-petname-debuginfo(x86-64)

golang-github-dustinkirkland-petname-debugsource:
    golang-github-dustinkirkland-petname-debugsource
    golang-github-dustinkirkland-petname-debugsource(x86-64)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1833511
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: fonts, Java, Ocaml, Python, SugarActivity, R, Perl, C/C++, Haskell, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Everything seems in order. Since this is now required for the haproxy dataplaneapi to build/work, I'm approving this review.

Comment 5 Gwyn Ciesla 2020-06-02 00:57:42 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-dustinkirkland-petname

Comment 6 Brandon Perkins 2020-06-05 15:29:19 UTC
CLOSED. In Rawhide (f33) and in progress for f32.

Comment 7 Brandon Perkins 2020-08-02 14:41:40 UTC
*** Bug 1331958 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.