Bug 1834414 - Allow enable mutual TLS in cluster logging Log Forwarding feature
Summary: Allow enable mutual TLS in cluster logging Log Forwarding feature
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Logging
Version: 4.4
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.7.0
Assignee: Alan Conway
QA Contact: Anping Li
URL:
Whiteboard: logging-core
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-11 16:43 UTC by Sergio G.
Modified: 2023-12-15 17:52 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-13 16:56:07 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1888943 0 urgent CLOSED ClusterLogForwarder with Output.Secret causes fluentd crash loop 2023-12-15 19:48:32 UTC
Red Hat Knowledge Base (Solution) 5091801 0 None None None 2020-08-27 16:16:13 UTC

Internal Links: 1888943

Description Sergio G. 2020-05-11 16:43:25 UTC
Description of problem:
It's impossible to use the plugin to configure the TLS forward properly.

The template used to create the forward configuration file has commented the line where the private key for the client is specified.

See current file for 4.4: https://github.com/openshift/cluster-logging-operator/blob/b04d1bc8c674111fe93e868e5dd84ac32a021974/pkg/generators/forwarding/fluentd/templates.go#L496


Version-Release number of selected component (if applicable):
OpenShift 4


Additional info:
As a workaround, the instance can be set to unmanaged, edit the line in the configmap to comment it out and the change will remain. But if the code has even the parameter substitution, why is the line commented?

Comment 2 Sergio G. 2020-05-11 19:42:55 UTC
Jeff, the documentation mentions the private key as part of the secret, the template includes the field (while it could just omit it), the code sets the variable in the proper line and there's a part of the test which sets the private key. 

It looks as easy as that somebody just forgot to remove the #. Actually that's the solution to make it work, remove the #.

There's nothing new to implement, just removing the # in the template which somebody forgot to remove. 

Is that an RFE? Please re-consider it.

Comment 3 Christian Heidenreich 2020-05-12 15:40:05 UTC
Sergio, can you point me to the documentation please.

Comment 4 Sergio G. 2020-05-12 15:51:02 UTC
@Christian: https://docs.openshift.com/container-platform/4.3/logging/config/cluster-logging-log-forwarding.html#cluster-logging-log-forwarding-about_cluster-logging-log-forwarding 

At the beginning of the page:
"An output supports TLS communication using a secret. Secrets must have keys of: tls.crt, tls.key, and ca-bundler.crt which point to the respective certificates for which they represent. Secrets must have the key shared_key for use when using forward in a secure manner."

Then, right after that part there's an example which shows how to configure a secured external log aggregator using the forward plug-in.

As tried to explain: the feature is already in place, actually if you check the code you will see that the key is filled in the template. We just need to remove the # to send the private key no matter if the other side will validate it or not.

That's why I think this is not an RFE but a bug. Someone forgot to remove the # for any reason.

Comment 9 Robert Bost 2020-08-27 16:26:29 UTC
Reopening since this still seems to affect 4.5 (and master branch)

Comment 10 Jeff Cantrill 2020-09-12 01:58:21 UTC
Moving to UpcomingSprint as unlikely to be addressed by EOD

Comment 11 Jeff Cantrill 2020-10-01 12:42:20 UTC
Moving to 4.7 to satisfy CF requirements for 4.6

Comment 12 Jeff Cantrill 2020-10-02 15:23:59 UTC
Marking UpcomingSprint as will not be merged or addressed by EOD

Comment 14 Jeff Cantrill 2020-10-23 15:20:03 UTC
Setting UpcomingSprint as unable to resolve before EOD

Comment 15 Alan Conway 2020-11-19 19:13:43 UTC
Will be fixed as part of https://bugzilla.redhat.com/show_bug.cgi?id=1888943

Comment 16 Alan Conway 2020-12-22 15:31:32 UTC
Fixed by PR https://github.com/openshift/cluster-logging-operator/pull/823 awaiting merge.

Comment 17 Jeff Cantrill 2021-01-13 16:56:07 UTC
Closing NEXT RELEASE as this will be fixed as indicated in #c16 in GA


Note You need to log in before you can comment on or make changes to this bug.