Bug 1834499 - Storage Class details page missing <dl> for proper structure
Summary: Storage Class details page missing <dl> for proper structure
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.5.0
Assignee: Jessie
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-11 19:58 UTC by Jessie
Modified: 2020-07-13 17:37 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:37:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Storage Class details page error (396.29 KB, image/png)
2020-05-11 20:11 UTC, Jessie
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 5399 0 None open Bug 1834499: Storage Class details page missing <dl> for proper structure 2020-06-24 02:20:28 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:37:48 UTC

Description Jessie 2020-05-11 19:58:23 UTC
Description of problem:
The storage class details page is missing a <dl> in the definition list structure. The parent dl element ensures the list follows the proper hierarchy. This help screen reader users know what they are listening to, and what to expect as they listen to definition lists with regard to the organizational relationship of parent and child items. (https://dequeuniversity.com/rules/axe/3.5/dlitem?application=AxeChrome)

It currently has the following axe error:
[
  {
    "data": null,
    "id": "dlitem",
    "impact": "serious",
    "message": "Description list item does not have a <dl> parent element",
    "relatedNodes": [
      {
        "html": "<dt><button class="pf-c-button pf-m-plain co-m-pane__details-popover-button" type="button" aria-expanded="false">Reclaim Policy</button></dt>"
      }
    ]
  },
  {
    "data": null,
    "id": "dlitem",
    "impact": "serious",
    "message": "Description list item does not have a <dl> parent element",
    "relatedNodes": [
      {
        "html": "<dd>Delete</dd>"
      }
    ]
  },
  {
    "data": null,
    "id": "dlitem",
    "impact": "serious",
    "message": "Description list item does not have a <dl> parent element",
    "relatedNodes": [
      {
        "html": "<dt>Default Class</dt>"
      }
    ]
  },
  {
    "data": null,
    "id": "dlitem",
    "impact": "serious",
    "message": "Description list item does not have a <dl> parent element",
    "relatedNodes": [
      {
        "html": "<dd>true</dd>"
      }
    ]
  },
  {
    "data": null,
    "id": "dlitem",
    "impact": "serious",
    "message": "Description list item does not have a <dl> parent element",
    "relatedNodes": [
      {
        "html": "<dt><button class="pf-c-button pf-m-plain co-m-pane__details-popover-button" type="button" aria-expanded="false">Volume Binding Mode</button></dt>"
      }
    ]
  },
  {
    "data": null,
    "id": "dlitem",
    "impact": "serious",
    "message": "Description list item does not have a <dl> parent element",
    "relatedNodes": [
      {
        "html": "<dd>WaitForFirstConsumer</dd>"
      }
    ]
  }

How reproducible:
You can see this error by using the Axe Chrome Extension.

Steps to Reproduce:
1. Go to a Storage Class details page, ex: http://localhost:9000/k8s/cluster/storageclasses/gp2
2. Open developer tools, go to the axe tab, press analyze
3. Click on the issue "<dt> and <dd> elements must be contained by a <dl>".


Actual results:
Invalid definition list structure

Expected results:
Valid structure that helps screen readers understand context

Comment 1 Jessie 2020-05-11 20:11:45 UTC
Created attachment 1687455 [details]
Storage Class details page error

Comment 4 shahan 2020-05-13 04:47:37 UTC
goto storage detail page, analyze the page with axe.  no "<dt> and <dd> elements must be contained by a <dl>" occured and pages works well
4.5.0-0.nightly-2020-05-12-191228

Comment 5 errata-xmlrpc 2020-07-13 17:37:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.