Bug 1834905 (rust-dotenv) - Review Request: rust-dotenv - `dotenv` implementation for Rust
Summary: Review Request: rust-dotenv - `dotenv` implementation for Rust
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-dotenv
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-12 16:00 UTC by Igor Raits
Modified: 2020-05-13 15:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-13 15:16:19 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Igor Raits 2020-05-12 16:00:11 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-dotenv.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-dotenv-0.15.0-1.fc33.src.rpm
Description:
`dotenv` implementation for Rust.
Fedora Account System Username: ignatenkobrain
Comment 1 Neal Gompa 2020-05-13 13:23:56 UTC 
Taking this review.
Comment 2 Neal Gompa 2020-05-13 13:24:18 UTC 
> # The /usr/bin/dotenv is already provided by other packages
> %global __cargo_is_bin() false

Why not just rename the binary and provide it anyway?
Comment 3 Igor Raits 2020-05-13 13:55:55 UTC 
(In reply to Neal Gompa from comment #2)
> > # The /usr/bin/dotenv is already provided by other packages
> > %global __cargo_is_bin() false
> 
> Why not just rename the binary and provide it anyway?

Well, I don't see much reasons in that. If peoplse use `dotenv` binary, they won't switch anything else. Especially if it is Fedora-specific.
Comment 4 Neal Gompa 2020-05-13 14:36:31 UTC 
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.
Comment 5 Igor Raits 2020-05-13 14:45:43 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dotenv
Note You need to log in before you can comment on or make changes to this bug.