Spec URL: http://oirase.annexia.org/reviews/honggfuzz/honggfuzz.spec SRPM URL: http://oirase.annexia.org/reviews/honggfuzz/honggfuzz-2.2-0.1.20200511gita299f3f.fc31.src.rpm Description: General-purpose, easy-to-use fuzzer Fedora Account System Username: rjones
rpmlint output is: honggfuzz.src: W: spelling-error Summary(en_US) fuzzer -> fuzzier, fuzzes, fuzzed honggfuzz.src: W: spelling-error %description -l en_US ptrace -> trace, p trace, pt race honggfuzz.src: W: strange-permission generate-tarball.sh 775 I think we can ignore this. honggfuzz.src: W: invalid-url Source0: honggfuzz-2.2.tar.gz honggfuzz.x86_64: W: spelling-error Summary(en_US) fuzzer -> fuzzier, fuzzes, fuzzed honggfuzz.x86_64: W: spelling-error %description -l en_US ptrace -> trace, p trace, pt race honggfuzz.x86_64: W: incoherent-version-in-changelog 2.2-0.1 ['2.2-0.1.20200511gita299f3f.fc31', '2.2-0.1.20200511gita299f3f'] honggfuzz.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/honggfuzz This is weird, but I guess an upstream issue. honggfuzz.x86_64: W: no-documentation I put all the documentation into the -devel subpackage, which seems appropriate. honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-cc honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-clang honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-clang++ honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-g++ honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-gcc honggfuzz.x86_64: W: no-manual-page-for-binary honggfuzz 5 packages and 0 specfiles checked; 1 errors, 14 warnings.
Note this was previously mostly-reviewed here: https://bugzilla.redhat.com/show_bug.cgi?id=1370064 I took the same spec file and simply updated it.
I will take this review.
I think you're missing a BuildRequires. Building for Rawhide fails: cc -o honggfuzz cmdline.o display.o fuzz.o honggfuzz.o input.o mangle.o report.o sanitizers.o socketfuzzer.o subproc.o linux/arch.o linux/bfd.o linux/perf.o linux/pt.o linux/trace.o linux/unwind.o libhfcommon/libhfcommon.a -pthread -lm -L/usr/local/include -lunwind-ptrace -lunwind-generic -lunwind -llzma -lopcodes -lbfd -lrt -ldl -lm -g -ggdb -g3 /usr/bin/ld: cannot find -llzma collect2: error: ld returned 1 exit status make: *** [Makefile:275: honggfuzz] Error 1 Also, the build log shows that Fedora's CFLAGS and LDFLAGS are not used.
Spec URL: http://oirase.annexia.org/reviews/honggfuzz/honggfuzz.spec SRPM URL: http://oirase.annexia.org/reviews/honggfuzz/honggfuzz-2.2-0.1.20200511gita299f3f.fc33.src.rpm Description: General-purpose, easy-to-use fuzzer Fedora Account System Username: rjones I added (most of) CFLAGS and fixed the BuildRequires. Here's a scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44446459
'Course that scratch build failed at the last minute. It seems as if the software needs to be ported to each architecture (see linux/trace.c) and it hasn't been ported to s390x, so I'll exclude that arch.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== Issues ===== - Remove "rm -rf $RPM_BUILD_ROOT" from the start of %install. See bullet 3: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections - Add %{?_isa} to the devel subpackage R on the main package; i.e., Requires: %{name}%{?_isa} = %{version}-%{release} See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package - After making you add a BR on xz-devel to satisfy -llzma passed to the linker by the Makefile, it turns out that liblzma is not actually needed by anything. If you wish to trim the BRs back down, you can remove -llzma from Makefile. - See the incoherent-version-in-changelog warning from rpmlint. The most recent changelog entry should read: * Tue May 12 2020 Richard W.M. Jones <rjones> 2.2-0.1.20200511gita299f3f - This is a non-issue: rpmlint issues a missing-call-to-setgroups-before-setuid warning due to the call to setresuid in nsEnter (libhfcommon/ns.c). The code is actually okay, but is written in a way that rpmlint does not understand. - Rpmlint says: honggfuzz.src: W: strange-permission generate-tarball.sh 775 Maybe it wants the permission to be 755? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0". 12953 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. It does in fact require an ExcludeArch tag, and has it. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 7 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in honggfuzz-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: honggfuzz-2.2-0.1.20200511gita299f3f.fc33.x86_64.rpm honggfuzz-devel-2.2-0.1.20200511gita299f3f.fc33.x86_64.rpm honggfuzz-debuginfo-2.2-0.1.20200511gita299f3f.fc33.x86_64.rpm honggfuzz-debugsource-2.2-0.1.20200511gita299f3f.fc33.x86_64.rpm honggfuzz-2.2-0.1.20200511gita299f3f.fc33.src.rpm honggfuzz.x86_64: W: spelling-error Summary(en_US) fuzzer -> fuzzier, fuzzes, fuzzed honggfuzz.x86_64: W: spelling-error %description -l en_US ptrace -> trace, p trace, pt race honggfuzz.x86_64: W: incoherent-version-in-changelog 2.2-0.1 ['2.2-0.1.20200511gita299f3f.fc33', '2.2-0.1.20200511gita299f3f'] honggfuzz.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/honggfuzz honggfuzz.x86_64: W: no-documentation honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-cc honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-clang honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-clang++ honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-g++ honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-gcc honggfuzz.x86_64: W: no-manual-page-for-binary honggfuzz honggfuzz.src: W: spelling-error Summary(en_US) fuzzer -> fuzzier, fuzzes, fuzzed honggfuzz.src: W: spelling-error %description -l en_US ptrace -> trace, p trace, pt race honggfuzz.src: W: strange-permission generate-tarball.sh 775 honggfuzz.src: W: invalid-url Source0: honggfuzz-2.2.tar.gz 5 packages and 0 specfiles checked; 1 errors, 14 warnings. Rpmlint (debuginfo) ------------------- Checking: honggfuzz-debuginfo-2.2-0.1.20200511gita299f3f.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- honggfuzz.x86_64: W: spelling-error Summary(en_US) fuzzer -> fuzzier, fuzzes, fuzzed honggfuzz.x86_64: W: spelling-error %description -l en_US ptrace -> trace, p trace, pt race honggfuzz.x86_64: W: incoherent-version-in-changelog 2.2-0.1 ['2.2-0.1.20200511gita299f3f.fc33', '2.2-0.1.20200511gita299f3f'] honggfuzz.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/honggfuzz honggfuzz.x86_64: W: no-documentation honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-cc honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-clang honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-clang++ honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-g++ honggfuzz.x86_64: W: no-manual-page-for-binary hfuzz-gcc honggfuzz.x86_64: W: no-manual-page-for-binary honggfuzz 4 packages and 0 specfiles checked; 1 errors, 10 warnings. Requires -------- honggfuzz (rpmlib, GLIBC filtered): clang compiler-rt gcc ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libunwind-x86_64.so.8()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) rtld(GNU_HASH) honggfuzz-devel (rpmlib, GLIBC filtered): honggfuzz honggfuzz-debuginfo (rpmlib, GLIBC filtered): honggfuzz-debugsource (rpmlib, GLIBC filtered): Provides -------- honggfuzz: honggfuzz honggfuzz(x86-64) honggfuzz-devel: honggfuzz-devel honggfuzz-devel(x86-64) honggfuzz-debuginfo: debuginfo(build-id) honggfuzz-debuginfo honggfuzz-debuginfo(x86-64) honggfuzz-debugsource: honggfuzz-debugsource honggfuzz-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1834964 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Ruby, Python, Java, Haskell, SugarActivity, Perl, fonts, R, PHP, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Here's the upstream lzma issue: https://github.com/google/honggfuzz/issues/332 > honggfuzz.src: W: strange-permission generate-tarball.sh 775 > Maybe it wants the permission to be 755? Yes that fixed it. > [!]: %check is present and all tests pass. This is a "should" item, but in any case I've checked upstream again and I can't see any tests. In AFL I made up a simple %check section: https://src.fedoraproject.org/rpms/american-fuzzy-lop/blob/master/f/american-fuzzy-lop.spec#_156 so I'll add something similar for this one.
Spec URL: http://oirase.annexia.org/reviews/honggfuzz/honggfuzz.spec SRPM URL: http://oirase.annexia.org/reviews/honggfuzz/honggfuzz-2.2-0.1.20200511gita299f3f.fc33.src.rpm Description: General-purpose, easy-to-use fuzzer Fedora Account System Username: rjones I believe this fixes all items revealed by the review.
Looks good. This package is APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/honggfuzz
FEDORA-2020-884e6f3e06 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-884e6f3e06
FEDORA-2020-884e6f3e06 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-884e6f3e06 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-884e6f3e06 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
ExcludeArch bug: https://bugzilla.redhat.com/show_bug.cgi?id=1836163
FEDORA-2020-884e6f3e06 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.