Bug 1835586 - ansible-runner-service.log is in /var/lib
Summary: ansible-runner-service.log is in /var/lib
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: ovirt-host-deploy-ansible
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.4.1
: 4.4.1.2
Assignee: Martin Necas
QA Contact: Pavol Brilla
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-14 06:23 UTC by Yedidyah Bar David
Modified: 2020-08-05 06:24 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine-4.4.1.2
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-05 06:24:52 UTC
oVirt Team: Infra
Embargoed:
pm-rhel: ovirt-4.4+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 109039 0 master MERGED runner: update logging config 2020-12-30 14:18:50 UTC

Description Yedidyah Bar David 2020-05-14 06:23:07 UTC
Description of problem:

ansible-runner-service.log is in /var/lib/ovirt-engine, although it's a log file and should probably be in /var/log/ovirt-engine, or /var/log/ovirt-engine/ansible-runner-service .

This breaks engine-backup if it's running while a host is being deployed, with:

tar: var/lib/ovirt-engine/ansible-runner-service.log: file changed as we read it

I currently pushed a patch to make engine-backup exclude it, but it makes sense to move it.

Comment 1 Martin Perina 2020-05-14 06:52:17 UTC
Unfortunately right now we have 2 logs:

 /var/lib/ovirt-engine/ansible-runner-service.log
 /var/log/httpd/ansible_runner_error_log

So we need to perform following actions:

1. Move ansible-runner-service.log from /var/lib/ovirt-engine to /var/log

2. Setup logrotate configuration on both logs

Comment 2 Pavol Brilla 2020-06-26 17:35:45 UTC
Verified parts:

# yum list ovirt-engine
Updating Subscription Management repositories.
Last metadata expiration check: 1:26:54 ago on Fri 26 Jun 2020 06:04:10 PM CEST.
Installed Packages
ovirt-engine.noarch                                                                                                4.4.1.5-0.17.el8ev                                                                                                 @rhvbuild
# find / -name "ansible-runner-service.log"
/var/log/ovirt-engine/ansible-runner-service.log
# grep -R ansible /etc/logrotate.*
/etc/logrotate.d/ovirt-engine:"/var/log/ovirt-engine/ansible"/*.log {
/etc/logrotate.d/ovirt-engine:"/var/log/ovirt-engine/ansible-runner-service.log" {

Failed_QE because missing logrotate for:  /var/log/httpd/ansible_runner_error_log - check #1 
# ls -l  /var/log/httpd/ansible_runner_error_log
-rw-r--r--. 1 root root 1394805 Jun 26 17:51 /var/log/httpd/ansible_runner_error_log

Comment 3 RHEL Program Management 2020-06-26 17:35:53 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 4 Martin Necas 2020-06-29 10:08:53 UTC
I have removed the logging to /var/log/httpd/ansible_runner_error_log so it is possible that you have it from the previous build.
Also, the httpd has it's own logrotate at /etc/logrotate.d/httpd

Comment 5 Pavol Brilla 2020-07-08 15:55:26 UTC
# cat /etc/logrotate.d/httpd 
/var/log/httpd/*log {
    missingok
    notifempty
    sharedscripts
    delaycompress
    postrotate
        /bin/systemctl reload httpd.service > /dev/null 2>/dev/null || true
    endscript
}

rest of verification is from coment#2

Comment 6 Sandro Bonazzola 2020-08-05 06:24:52 UTC
This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.