Bug 1836497 - audacity-2.4.2 is available
Summary: audacity-2.4.2 is available
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: audacity
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1807893
TreeView+ depends on / blocked
 
Reported: 2020-05-16 11:07 UTC by Upstream Release Monitoring
Modified: 2021-02-15 01:31 UTC (History)
9 users (show)

Fixed In Version: audacity-2.4.2-4.fc33
Clone Of:
Environment:
Last Closed: 2021-02-15 01:31:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
[patch] Update to 2.4.1 (#1836497) (1.02 KB, patch)
2020-05-21 09:23 UTC, Upstream Release Monitoring
no flags Details | Diff
[patch] Update to 2.4.2 (#1836497) (975 bytes, patch)
2020-06-26 14:34 UTC, Upstream Release Monitoring
no flags Details | Diff

Description Upstream Release Monitoring 2020-05-16 11:07:09 UTC
Latest upstream release: 2.4.0
Current version/release in rawhide: 2.3.3-5.fc33
URL: https://www.audacityteam.org/

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/139/

Comment 1 Upstream Release Monitoring 2020-05-16 11:07:16 UTC
An unexpected error occurred while creating the scratch build and has been automatically reported. Sorry!

Comment 2 Upstream Release Monitoring 2020-05-21 09:22:55 UTC
Latest upstream release: 2.4.1
Current version/release in rawhide: 2.3.3-5.fc33
URL: https://www.audacityteam.org/

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/139/

Comment 3 Upstream Release Monitoring 2020-05-21 09:23:00 UTC
Created attachment 1690566 [details]
[patch] Update to 2.4.1 (#1836497)

Comment 4 Upstream Release Monitoring 2020-05-21 09:27:52 UTC
the-new-hotness/release-monitoring.org's scratch build of audacity-2.4.1-1.fc30.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=44761777

Comment 5 David Timms 2020-05-22 10:31:06 UTC
Ian, from https://bugzilla.redhat.com/show_bug.cgi?id=1799177#c16:

Are you already working on this ? I don't have much experience with cmake/make.
If you aren't planning to take a look, let me know to avoid duplicating our efforts, cheers.

Comment 6 Upstream Release Monitoring 2020-06-26 14:34:46 UTC
Latest upstream release: 2.4.2
Current version/release in rawhide: 2.3.3-5.fc33
URL: https://www.audacityteam.org/

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/139/

Comment 7 Upstream Release Monitoring 2020-06-26 14:34:50 UTC
Created attachment 1698935 [details]
[patch] Update to 2.4.2 (#1836497)

Comment 8 Upstream Release Monitoring 2020-06-26 14:38:53 UTC
the-new-hotness/release-monitoring.org's scratch build of audacity-2.4.2-1.fc32.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=46207277

Comment 9 Brandon Nielsen 2021-01-04 04:00:42 UTC
I have 2.4.2 building on all supported Fedora platforms[0]. I can vouch for its stability in that I just used it to finish up a large-ish project. In the process, I cleaned up a lot of conditionals and variables in the specfile related to now unsupported Fedora versions. I have not gotten a chance to see if it still builds on RHEL.

[0] - https://copr.fedorainfracloud.org/coprs/nielsenb/audacity/

Comment 10 Gwyn Ciesla 2021-02-09 18:29:29 UTC
(In reply to Brandon Nielsen from comment #9)
> I have 2.4.2 building on all supported Fedora platforms[0]. I can vouch for
> its stability in that I just used it to finish up a large-ish project. In
> the process, I cleaned up a lot of conditionals and variables in the
> specfile related to now unsupported Fedora versions. I have not gotten a
> chance to see if it still builds on RHEL.
> 
> [0] - https://copr.fedorainfracloud.org/coprs/nielsenb/audacity/

If you'd like to submit the changes as a PR in Pagure, I'd be happy to review, test, approve, and build it.

Comment 11 Brandon Nielsen 2021-02-09 19:59:37 UTC
(In reply to Gwyn Ciesla from comment #10)
> If you'd like to submit the changes as a PR in Pagure, I'd be happy to
> review, test, approve, and build it.

I would love to, but I'm not a packager so I can't push changes to pagure so I can't open a PR. If I could that's where I would have started. Sorry!

Comment 12 Gwyn Ciesla 2021-02-09 20:22:52 UTC
Can you attach your spec and any patches?

Comment 13 Brandon Nielsen 2021-02-09 20:27:00 UTC
(In reply to Gwyn Ciesla from comment #12)
> Can you attach your spec and any patches?

Spec is available in copr[0]. I dropped all of the patches.

[0] - https://download.copr.fedorainfracloud.org/results/nielsenb/audacity/fedora-rawhide-armhfp/01853569-audacity/audacity.spec

Comment 14 Gwyn Ciesla 2021-02-09 20:29:41 UTC
Thank you so much! I couldn't find it, probably E_COFFEE.

Comment 15 Ian McInerney 2021-02-09 22:30:05 UTC
I just took a look and am curious as to why the patch to the audacity.desktop file has been dropped now. Those changes are ones that aren't upstreamable and at least the GDK_BACKEND part is due to the fact that we default to Wayland and Audacity has known issues with Wayland. I am afraid those bugs will reintroduce themselves without that patch.

Comment 16 Fedora Update System 2021-02-09 22:47:35 UTC
FEDORA-2021-5eedadbb5d has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5eedadbb5d

Comment 17 Germano Massullo 2021-02-09 23:15:24 UTC
(In reply to Fedora Update System from comment #16)
> FEDORA-2021-5eedadbb5d has been submitted as an update to Fedora 33.
> https://bodhi.fedoraproject.org/updates/FEDORA-2021-5eedadbb5d

Audacity complains about missing FFmpeg when opening a .ogg file. In Preferences->Libraries->FFmpeg "detect" seems to not be able to find FFmpeg

 dnf list installed | grep ffmpeg
ffmpeg.x86_64                                        4.3.1-16.fc33                          @rpmfusion-free-updates                                                
ffmpeg-debuginfo.x86_64                              4.3.1-11.fc33                          @rpmfusion-free-debuginfo                                              
ffmpeg-debugsource.x86_64                            4.3.1-11.fc33                          @rpmfusion-free-debuginfo                                              
ffmpeg-libs.x86_64                                   4.3.1-16.fc33                          @rpmfusion-free-updates                                                
ffmpeg-libs-debuginfo.x86_64                         4.3.1-11.fc33                          @rpmfusion-free-debuginfo                                              
kffmpegthumbnailer-debuginfo.x86_64                  1.1.0-19.fc33                          @rpmfusion-free-debuginfo                                              
kffmpegthumbnailer-debugsource.x86_64                1.1.0-19.fc33                          @rpmfusion-free-debuginfo

Comment 18 Brandon Nielsen 2021-02-09 23:16:06 UTC
(In reply to Ian McInerney from comment #15)
> I just took a look and am curious as to why the patch to the
> audacity.desktop file has been dropped now. Those changes are ones that
> aren't upstreamable and at least the GDK_BACKEND part is due to the fact
> that we default to Wayland and Audacity has known issues with Wayland. I am
> afraid those bugs will reintroduce themselves without that patch.

I authored the changes to the spec, link to upstream Wayland issues? The currently packaged version is terribly unstable, where I had no issues using the newer version even under a Wayland session.

Comment 19 Brandon Nielsen 2021-02-10 00:04:49 UTC
(In reply to Germano Massullo from comment #17)
> (In reply to Fedora Update System from comment #16)
> > FEDORA-2021-5eedadbb5d has been submitted as an update to Fedora 33.
> > https://bodhi.fedoraproject.org/updates/FEDORA-2021-5eedadbb5d
> 
> Audacity complains about missing FFmpeg when opening a .ogg file. In
> Preferences->Libraries->FFmpeg "detect" seems to not be able to find FFmpeg
> 
[Snip]

Ogg works for me without FFmpeg, though "-Daudacity_use_ogg=system" should probably be explicitly added.

I'm not sure as to why it can't detect FFmpeg, it seems to be looking for "libavformat.so.55" which isn't available anywhere. Though it may also be because FFmpeg support is explicitly disabled with "-Daudacity_use_fmmpeg=off".

Comment 20 Fedora Update System 2021-02-10 00:44:42 UTC
FEDORA-2021-fd5673905c has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-fd5673905c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-fd5673905c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 21 Gwyn Ciesla 2021-02-10 01:11:36 UTC
Likely, and it has to be, because we can't build in a dependency on something we can't ship in Fedora.

Comment 22 Ian McInerney 2021-02-10 09:09:29 UTC
> I authored the changes to the spec, link to upstream Wayland issues? The currently packaged version is terribly unstable, where I had no issues using the newer version even under a Wayland session.

There are several upstream issues including https://github.com/audacity/audacity/issues/471 and https://github.com/audacity/audacity/issues/459 that mention the Wayland incompatibility and the fact that GDK_BACKEND=x11 is needed in the launcher. There was even a bug report against the Audacity package recently (https://bugzilla.redhat.com/show_bug.cgi?id=1798987) that had the very same issues and was the reason I introduced the patch to the desktop file. The problem's don't manifest themselves on every install, but when they do they make it impossible to use - and the patch to the desktop file will not break anything and allow all installs to work properly.

Comment 23 Brandon Nielsen 2021-02-10 20:04:56 UTC
(In reply to Ian McInerney from comment #22)
> > I authored the changes to the spec, link to upstream Wayland issues? The currently packaged version is terribly unstable, where I had no issues using the newer version even under a Wayland session.
> 
> There are several upstream issues including
> https://github.com/audacity/audacity/issues/471 and
> https://github.com/audacity/audacity/issues/459 that mention the Wayland
> incompatibility and the fact that GDK_BACKEND=x11 is needed in the launcher.
> There was even a bug report against the Audacity package recently
> (https://bugzilla.redhat.com/show_bug.cgi?id=1798987) that had the very same
> issues and was the reason I introduced the patch to the desktop file. The
> problem's don't manifest themselves on every install, but when they do they
> make it impossible to use - and the patch to the desktop file will not break
> anything and allow all installs to work properly.

Thanks for those. Bug 1798987 (what the patch originally points to) in particular implies to me more guilt by association than an actual Wayland issue. The original reporters all mention it happens with both X11 and Wayland sessions. Forcing the GDK backend might "fix" it, but the issue likely lies elsewhere (probably GTK3, as noted in upstream 459[0]). I'm not saying that part of the patch shouldn't be reinstated, but I cannot reproduce the issue with 2.4.2, they even mention in 459 it may be fixed in 2.4.2[1]. If we don't reevaluate patches, they tend to get carried on forever. The rest of that patch explicitly adds some supported types (mpeg / mp3 which seem to be correctly listed now, and MIDI which does not seem to actually work for me, Audacity opens it correctly, but cannot play, possible bug?), and a fix for Fedora Studio (which no longer exists, is it somehow required by Fedora Jam?).

Either way, if the GDK backend part of the patch is reinstated, an explicit requires of "xorg-x11-server-Xwayland" should probably be added.

[0] - https://github.com/audacity/audacity/issues/459#issuecomment-649430962
[1] - https://github.com/audacity/audacity/issues/459#issuecomment-650398472

Comment 24 Brandon Nielsen 2021-02-10 20:53:22 UTC
I would definitely reinstate the GDK backend portion of the patch even though it seems to be more luck that it works than an actual fix.

Even though I can't get MIDI playback to actually produce sound, opening a long, complicated MIDI (I downloaded an almost certainly inappropriate to link here for copyright reasons Bohemian Rhapsody MIDI file) and pressing play will produce the issue described in bug 1798987 every time. Interesting that my big WAV projects do not produce the issue.

Comment 25 Brandon Nielsen 2021-02-11 00:09:15 UTC
It is not finding system lv2 or portmidi, the latter may be the reason why MIDI playback does not work. I have not tested runtime detection of lv2.

It also is not detecting system LAME, runtime detection seems to work so until that's fixed an explicit requires on LAME should be added.

Comment 26 Fedora Update System 2021-02-11 01:59:55 UTC
FEDORA-2021-dadbd49ece has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-dadbd49ece`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-dadbd49ece

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 27 Fedora Update System 2021-02-12 02:12:14 UTC
FEDORA-2021-8aaccdbb5f has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-8aaccdbb5f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8aaccdbb5f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 28 Fedora Update System 2021-02-15 01:31:07 UTC
FEDORA-2021-8aaccdbb5f has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.