Bug 1837638 - Multus admission controller not detecting syntax issues in pod and net-attach-def CRDs
Summary: Multus admission controller not detecting syntax issues in pod and net-attach...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.4
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.4.z
Assignee: Douglas Smith
QA Contact: Weibin Liang
URL:
Whiteboard: SDN-CI-IMPACT,SDN-BP,SDN-STALE
Depends On: 1758702
Blocks: 1782301
TreeView+ depends on / blocked
 
Reported: 2020-05-19 18:02 UTC by Douglas Smith
Modified: 2020-06-02 11:19 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1782301
Environment:
Last Closed: 2020-06-02 11:18:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:2310 0 None None None 2020-06-02 11:19:09 UTC

Comment 1 Douglas Smith 2020-05-19 18:08:36 UTC
Setting to ON_QA. I believe this should be fixed in 4.4

Comment 2 Weibin Liang 2020-05-20 20:50:44 UTC
Tested and verified in 4.4.0-0.nightly-2020-05-18-164758

[weliang@weliang FILE]$ oc get net-attach-def -o yaml
apiVersion: v1
items:
- apiVersion: k8s.cni.cncf.io/v1
  kind: NetworkAttachmentDefinition
  metadata:
    creationTimestamp: "2020-05-20T20:48:58Z"
    generation: 1
    name: macvlan-bridge
    namespace: test
    resourceVersion: "23440"
    selfLink: /apis/k8s.cni.cncf.io/v1/namespaces/test/network-attachment-definitions/macvlan-bridge
    uid: 7e4114c9-9162-42be-9e47-16f07b501e87
  spec:
    config: '{ "cniVersion": "0.3.0", "type": "macvlan", "master": "eth0", "mode":
      "bridge", "ipam": { "type": "dhcp" } }'
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""
[weliang@weliang FILE]$ oc patch networkattachmentdefinition.k8s.cni.cncf.io macvlan-bridge -p '{"spec":{"config":" " }}' --type=merge
Error from server: admission webhook "multus-validating-config.k8s.io" denied the request: configuration string is not in JSON format

[weliang@weliang FILE]$ oc patch networkattachmentdefinition.k8s.cni.cncf.io macvlan-bridge -p '{"spec":{"config":"{"cniVersion": "0.3.0", "type": "cvlan", "master": "eth", "mode": "bridge", "ipam": { "type": "dhcp" }}"}}' --type=merge
Error from server: Invalid JSON Patch
[weliang@weliang FILE]$

Comment 5 errata-xmlrpc 2020-06-02 11:18:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2310


Note You need to log in before you can comment on or make changes to this bug.