Bug 1837873 - [RFE] No warning/blocking when detaching storage domain when there are VMs with disk on the detached domain and second disk on other domain
Summary: [RFE] No warning/blocking when detaching storage domain when there are VMs wi...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: 4.3.10.3
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.4.2
: 4.4.2.1
Assignee: shani
QA Contact: Shir Fishbain
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-20 08:15 UTC by Petr Kubica
Modified: 2020-09-18 07:12 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.4.2.1
Clone Of:
Environment:
Last Closed: 2020-09-18 07:12:06 UTC
oVirt Team: Storage
Embargoed:
pm-rhel: ovirt-4.4+
mtessun: planning_ack+
tnisan: devel_ack+
pm-rhel: testing_ack+


Attachments (Terms of Use)
Confirmation popup - detaching SD (27.39 KB, image/png)
2020-07-08 15:13 UTC, shani
no flags Details
Suggested fix - Change datach SD popup (36.94 KB, image/png)
2020-07-19 10:33 UTC, shani
no flags Details
screenshot (120.36 KB, image/png)
2020-08-11 15:10 UTC, Shir Fishbain
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 110310 0 master MERGED webadmin: warn on detaching an SD having entities with disks on another SD 2020-09-17 12:17:29 UTC

Description Petr Kubica 2020-05-20 08:15:03 UTC
Description of problem:
The issue was triggered during testing migration between engines [1]

When user wants to migrate VMs from old environment to the new one, he needs to move all disks to storage domain which will be used for migration. But when the VM will have multiple disks and not all disks are not present on the migrated storage domain. There is no warning that user is breaking VM. So he can easily miss that he didn't move all necessary disks and he may found difficult to assign disks correctly to appropriate VMs on the new engine to fix his mistake.

(He notices his mistake only when he will try to start the VMs on the new engine)

I would imagine this operation should be blocked until resolving the problems or warning with approving via checkbox.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1700905 

Version-Release number of selected component (if applicable):
ovirt-engine-4.3.10.3-0.1.master.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. Have an environment with multiple storage domains, prepare one for migration between engines
2. Have a VM with two disks, one disk migrate to storage domain which should be migrated, second disk should be on different domain.
3. Detach the storage domain which should be migrated
- no warnings, no errors

Comment 1 Michal Skrivanek 2020-06-23 12:34:00 UTC
This request is not currently committed to 4.4.z, moving it to 4.5

Comment 3 shani 2020-07-08 15:13:45 UTC
Created attachment 1700324 [details]
Confirmation popup - detaching SD

@Laura,
There's currently a confirmation popup for detaching an SD.
Should the requested warning be on that same popup (which can be too crowded view), or on a separate popup that will show up after pressing OK on that popup (also a bit exhausting)?

Can you think about a creative one for that?

Comment 5 Laura Wright 2020-07-13 14:32:43 UTC
I would consolidate the messages into one that says something like:

Are you sure you want to detach storage domains from the following data center(s)? 

To migrate to a new environment you need to move all of your disks to the storage domains that will be used for the migration. 



I would use the yellow warning triangle inline message as the component for it.

Comment 6 shani 2020-07-14 08:34:11 UTC
Nice one!
Thanks, will work on it.

Comment 7 Laura Wright 2020-07-14 12:33:38 UTC
Sounds good thanks!

Comment 8 shani 2020-07-19 10:33:37 UTC
Created attachment 1701665 [details]
Suggested fix - Change datach SD popup

Comment 9 Shir Fishbain 2020-08-11 15:09:35 UTC
Verified 

Attached the screenshot of the "Detach storage" message.

ovirt-engine-4.4.2.1-0.15.el8ev.noarch
vdsm-4.40.24-1.el8ev.x86_64

Comment 10 Shir Fishbain 2020-08-11 15:10:29 UTC
Created attachment 1711089 [details]
screenshot

Comment 11 Sandro Bonazzola 2020-09-18 07:12:06 UTC
This bugzilla is included in oVirt 4.4.2 release, published on September 17th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.