RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1838233 - address coverity warnings
Summary: address coverity warnings
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: toolbox
Version: 8.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.3
Assignee: Jindrich Novy
QA Contact: Alex Jia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-20 17:12 UTC by Micah Abbott
Modified: 2021-05-18 15:33 UTC (History)
4 users (show)

Fixed In Version: toolbox-0.0.99-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-18 15:32:55 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Micah Abbott 2020-05-20 17:12:19 UTC
The Coverity scan on `toolbox-0.0.7-1.module+el8.2.1+6441+9a058ad8` raised some warnings that should be addressed.

1. Defect type: SHELLCHECK_WARNING
1. /usr/bin/toolbox:41:11: warning: Declare and assign separately to avoid masking return values. [SC2155]
#    39|       fi
#    40|   
#    41|->     local state=$(container_state)
#    42|       if [[ "$state" == configured ]] || [[ "$state" == exited ]] || [[ "$state" == stopped ]]; then
#    43|           container_start


2. Defect type: SHELLCHECK_WARNING
1. /usr/bin/toolbox:26:11: warning: Declare and assign separately to avoid masking return values. [SC2155]
#    24|       fi
#    25|   
#    26|->     local runlabel=$(image_runlabel)
#    27|       if ! container_exists; then
#    28|           echo "Spawning a container '$TOOLBOX_NAME' with image '$TOOLBOX_IMAGE'"


3. Defect type: SHELLCHECK_WARNING
1. /usr/bin/toolbox:16:16: warning: Can't follow non-constant source. Use a directive to specify location. [SC1090]
#    14|       if [ -f "${TOOLBOXRC}" ]; then
#    15|           echo ".toolboxrc file detected, overriding defaults..."
#    16|->         source "${TOOLBOXRC}"
#    17|       fi
#    18|       TOOLBOX_IMAGE="${REGISTRY}"/"${IMAGE}"

Comment 13 errata-xmlrpc 2021-05-18 15:32:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: container-tools:rhel8 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1796


Note You need to log in before you can comment on or make changes to this bug.