Description of problem: Creating a live snapshot with memory and having LiveSnapshotPerformFreezeInEngine set to true will result in VM that has the file system frozen upon previewing or commiting. Version-Release number of selected component (if applicable): 4.3.10 How reproducible: 100% Steps to Reproduce: 1. Set the LiveSnapshotPerformFreezeInEngine=true in engine config. 2. Create a VM with disk. 3. Create snapshot with memory. 4. Shutdown the VM. 5. Preview or preview+commit the snapshot with memory restore. 6. Start the VM. Actual results: The VM's file system will be frozen. Expected results: The VM should be restored without being frozen. Additional info: Workarounds: 1. Change the config of LiveSnapshotPerformFreezeInEngine to false. 2. Shutting down the VM and starting it again. 3. Doing preview, starting the VM(it will be frozen), shutting it down, commiting the snapshot and start. 4. Running: # vdsm-client VM thaw vmID=<uuid> on the host the VM is running and the FS is frozen. 5. Create the snapshot without memory.
We shouldn't call freeze or thaw when doing live snapshot with memory(the VM is paused during it - makes sure of data consistency). In this scenario when restoring it with memory the FS will be frozen and we can't do anything. The freeze/thaw calls should happen only when creating non-memory live snapshot in order to make the data consistent.
Sure, we still have time. Not so much a backport as just changing the milestone to whichever (4.4.1 or 4.4.2) fits once it merges
Verified with: ovirt-engine-4.3.11-0.1.el7.noarch Steps: 1. Set the LiveSnapshotPerformFreezeInEngine=true in engine config 2. Create a VM with disk. 3. Create snapshot with memory. 4. Shutdown the VM. 5. Preview+commit the snapshot with memory restore. 6. Start the VM. Result: 1. The VM is restored without being frozen.
Moving back to modified since this has been verified on ovirt-engine-4.3.11-0.1.el7.noarch before cloning to 4.3.
Verified with: ovirt-engine-4.4.1.5-0.17.el8ev.noarch Steps: 1. Set the LiveSnapshotPerformFreezeInEngine=true in engine config 2. Create a VM with disk. 3. Create snapshot with memory. 4. Shutdown the VM. 5. Preview+commit the snapshot with memory restore. 6. Start the VM. Result: 1. The VM is restored without being frozen.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: RHV Manager (ovirt-engine) 4.4 security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:3247