Bug 1839384 - Review Request: rust-widestring - A wide string FFI Rust library for converting to and from wide Unicode strings
Summary: Review Request: rust-widestring - A wide string FFI Rust library for converti...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2020-05-23 20:09 UTC by Michel Lind
Modified: 2021-07-27 00:45 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-07-27 00:45:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michel Lind 2020-05-23 20:09:17 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-widestring.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-widestring-0.4.0-1.fc32.src.rpm
Description: Wide string FFI library for converting to and from wide strings, such as those often used in Windows API or other FFI libraries.
Fedora Account System Username: salimma

Comment 1 Igor Raits 2020-05-23 21:16:29 UTC
> # tests are inlined and some of them require winapi

How hard would it be to make them work? usually this means that the bug is in upstream and the fix should be just few lines with some #[cfg(windows)] or similar.

Comment 2 Robert-André Mauchin 🐧 2020-06-25 18:40:02 UTC
 - Bump to 0.4.2

Seems a bug in upstream:

//! ```rust
//! # #[cfg(not(windows))]
//! # fn main() {}
//! # extern crate winapi;
//! # extern crate widestring;
//! # #[cfg(windows)]
//! # fn main() {

Try to send a patch upstream.


 - License ok
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 3 Robert-André Mauchin 🐧 2020-06-25 18:44:02 UTC
 - Add a comment explaining what you've patched out

# Initial patched metadata

Comment 4 Package Review 2021-06-26 00:45:24 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 5 Package Review 2021-07-27 00:45:25 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.