Bug 1839429 - Review Request: rust-bzip2-sys - Bindings to libbzip2 for bzip2 compression and decompression exposed as Reader/Writer streams
Summary: Review Request: rust-bzip2-sys - Bindings to libbzip2 for bzip2 compression a...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Stefano Figura
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1839430
TreeView+ depends on / blocked
 
Reported: 2020-05-24 03:18 UTC by Michel Lind
Modified: 2020-06-27 17:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-27 17:13:09 UTC
Type: ---
Embargoed:
stefano: fedora-review+
brandfbb: needinfo+


Attachments (Terms of Use)

Description Michel Lind 2020-05-24 03:18:39 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-bzip2-sys.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-bzip2-sys-0.1.8+1.0.8-1.fc32.src.rpm
Description: Bindings to libbzip2 for bzip2 compression and decompression exposed as Reader/Writer streams.
Fedora Account System Username: salimma

Comment 1 Breno 2020-06-02 00:57:15 UTC
Hi Michel,

Do you think we could have the text file of the licenses?  
E.g. %license LICENSE-APACHE LICENSE-MIT [1, 2]


What about having the latest version?
I see here the bzip2-sys-0.1.9 was released only ~ 5 days ago :( 


1 https://src.fedoraproject.org/rpms/rust-ripgrep/blob/master/f/rust-ripgrep.spec
2 https://src.fedoraproject.org/rpms/rust-dirs/blob/master/f/rust-dirs.spec

Apart from that, I think it's all good.

Comment 2 Michel Lind 2020-06-14 22:22:53 UTC
Good point, sorry for the late response - will update.

Comment 3 Michel Lind 2020-06-14 22:42:22 UTC
updated to 0.1.9

The license texts are not available in the crate, sadly, they are only in the main repo (bzip2-rs) instead of the subdirectory this is in (bzip2-rs/bzip2-sys).

I created a pull request and linked it in a comment in the spec file:

https://github.com/alexcrichton/bzip2-rs/pull/59

Comment 5 Breno 2020-06-25 20:07:22 UTC
LGTM

Comment 6 Michel Lind 2020-06-26 17:22:45 UTC
(In reply to Breno from comment #5)
> LGTM

thanks - could you set the fedora-review flag to + instead of the needinfo?

Comment 7 Michel Lind 2020-06-26 17:48:25 UTC
Thanks Stefano

Comment 8 Michel Lind 2020-06-26 17:59:19 UTC
❯ fedpkg request-repo rust-bzip2-sys 1839429     
https://pagure.io/releng/fedora-scm-requests/issue/26402

Comment 9 Gwyn Ciesla 2020-06-26 18:02:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bzip2-sys


Note You need to log in before you can comment on or make changes to this bug.