Bug 1839479 - Review Request: python-opencensus - A stats collection and distributed tracing framework
Summary: Review Request: python-opencensus - A stats collection and distributed tracin...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1839470 1839472 1839473 1839477
Blocks: 1830659 1834085 1839480
TreeView+ depends on / blocked
 
Reported: 2020-05-24 09:56 UTC by Mohamed El Morabity
Modified: 2020-06-26 01:07 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-26 00:46:21 UTC
Type: ---
Embargoed:
mail: fedora-review+


Attachments (Terms of Use)

Description Mohamed El Morabity 2020-05-24 09:56:07 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/melmorabity/python-azure-sdk-5/fedora-32-x86_64/01403781-python-opencensus/python-opencensus.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/melmorabity/python-azure-sdk-5/fedora-32-x86_64/01403781-python-opencensus/python-opencensus-0.7.7-1.fc32.src.rpm
Description:
OpenCensus provides a framework to measure a server's resource usage and collect
performance stats. This package contains Python related utilities and supporting
software needed by OpenCensus.
Fedora Account System Username: melmorabity

Comment 1 Fabian Affolter 2020-06-07 11:25:41 UTC
At the moment there is no binary eggs in the source but I suggest to add the removal to %prep in case in a future update ther eis one and not to forget it.

Missing link to upstream issue. Would be nice to have one but is not a blocker.

The removal of some extensions, is OK from my point of view. opencensus-ext-mysql is the only one that has its dependency present and perhaps could be enabled. 

- contrib/opencensus-ext-google-cloud-clientlibs
  Issue: >= 0.8.dev0, current 0.7.7
- contrib/opencensus-ext-mysql
  Dep: https://src.fedoraproject.org/rpms/python-PyMySQL
- contrib/opencensus-ext-postgresql
  Issue: >= 0.8.dev0, current 0.7.7
  Dep: https://src.fedoraproject.org/rpms/python-psycopg2, would require a patch for the setup.py
- contrib/opencensus-ext-stackdriver
  Deps not present


Package APPROVED.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package must not depend on deprecated() packages.
  Note: python3-pytest4 is deprecated, you must not depend on it.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/deprecating-packages/


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License (v2.0)",
     "Apache License (v2.0)". 173 files have unknown license. Detailed
     output of licensecheck in
     /home/fab/Documents/repos/reviews/1839479-python-
     opencensus/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.9/site-
     packages/opencensus/ext
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.9/site-
     packages/opencensus, /usr/lib/python3.9/site-packages/opencensus/ext,
     /usr/lib/python3.9/site-packages/opencensus/common
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 245760 bytes in 45 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-opencensus , python3-opencensus-context , python3-opencensus-
     correlation , python3-opencensus-ext-azure , python3-opencensus-ext-
     datadog , python3-opencensus-ext-dbapi , python3-opencensus-ext-django
     , python3-opencensus-ext-flask , python3-opencensus-ext-gevent ,
     python3-opencensus-ext-grpc , python3-opencensus-ext-httplib ,
     python3-opencensus-ext-jaeger , python3-opencensus-ext-logging ,
     python3-opencensus-ext-ocagent , python3-opencensus-ext-prometheus ,
     python3-opencensus-ext-pymongo , python3-opencensus-ext-pymysql ,
     python3-opencensus-ext-pyramid , python3-opencensus-ext-requests ,
     python3-opencensus-ext-sqlalchemy , python3-opencensus-ext-threading ,
     python3-opencensus-ext-zipkin
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-opencensus-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-context-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-correlation-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-azure-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-datadog-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-dbapi-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-django-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-flask-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-gevent-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-grpc-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-httplib-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-jaeger-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-logging-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-ocagent-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-prometheus-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-pymongo-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-pymysql-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-pyramid-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-requests-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-sqlalchemy-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-threading-0.7.7-1.fc33.noarch.rpm
          python3-opencensus-ext-zipkin-0.7.7-1.fc33.noarch.rpm
          python-opencensus-doc-0.7.7-1.fc33.noarch.rpm
          python-opencensus-0.7.7-1.fc33.src.rpm
24 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-context.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-logging.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-datadog.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-zipkin.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-correlation.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-threading.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-sqlalchemy.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-pymysql.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-ocagent.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-django.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-pymongo.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-gevent.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-dbapi.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-httplib.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-pyramid.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-jaeger.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-flask.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-prometheus.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-requests.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-azure.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-opencensus-ext-grpc.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python-opencensus-doc.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-python <urlopen error [Errno -2] Name or service not known>
23 packages and 0 specfiles checked; 0 errors, 23 warnings.



Source checksums
----------------
https://github.com/census-instrumentation/opencensus-python/archive/v0.7.7/opencensus-0.7.7.tar.gz :
  CHECKSUM(SHA256) this package     : 7783dcf1ade1b062482817c0ce816b50f96c6cc9a36bf4f1df550e2f22ed0109
  CHECKSUM(SHA256) upstream package : 7783dcf1ade1b062482817c0ce816b50f96c6cc9a36bf4f1df550e2f22ed0109


Requires
--------
python3-opencensus (rpmlib, GLIBC filtered):
    (python3.9dist(google-api-core) < 2 with python3.9dist(google-api-core) >= 1)
    python(abi)
    python3.9dist(opencensus-context)

python3-opencensus-context (rpmlib, GLIBC filtered):
    python(abi)

python3-opencensus-correlation (rpmlib, GLIBC filtered):
    python(abi)

python3-opencensus-ext-azure (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    python(abi)
    python3.9dist(psutil)
    python3.9dist(requests)

python3-opencensus-ext-datadog (rpmlib, GLIBC filtered):
    (python3.9dist(bitarray) < 2 with python3.9dist(bitarray) >= 1.0.1)
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7.6)
    python(abi)
    python3.9dist(requests)

python3-opencensus-ext-dbapi (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    python(abi)

python3-opencensus-ext-django (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    python(abi)
    python3.9dist(django)

python3-opencensus-ext-flask (rpmlib, GLIBC filtered):
    (python3.9dist(flask) < 2 with python3.9dist(flask) >= 0.12.3)
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7.1)
    python(abi)

python3-opencensus-ext-gevent (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    python(abi)
    python3.9dist(gevent)

python3-opencensus-ext-grpc (rpmlib, GLIBC filtered):
    (python3.9dist(grpcio) < 2 with python3.9dist(grpcio) >= 1)
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7.1)
    python(abi)

python3-opencensus-ext-httplib (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    python(abi)

python3-opencensus-ext-jaeger (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7.1)
    python(abi)
    python3.9dist(thrift)

python3-opencensus-ext-logging (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    python(abi)

python3-opencensus-ext-ocagent (rpmlib, GLIBC filtered):
    (python3.9dist(grpcio) < 2 with python3.9dist(grpcio) >= 1)
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7.1)
    (python3.9dist(opencensus-proto) < 1 with python3.9dist(opencensus-proto) >= 0.1)
    python(abi)

python3-opencensus-ext-prometheus (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    (python3.9dist(prometheus-client) < 1 with python3.9dist(prometheus-client) >= 0.5)
    python(abi)

python3-opencensus-ext-pymongo (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7.1)
    python(abi)
    python3.9dist(pymongo)

python3-opencensus-ext-pymysql (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    (python3.9dist(opencensus-ext-dbapi) < 1 with python3.9dist(opencensus-ext-dbapi) >= 0.1.2)
    (python3.9dist(pymysql) < 1 with python3.9dist(pymysql) >= 0.7.11)
    python(abi)

python3-opencensus-ext-pyramid (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    (python3.9dist(pyramid) < 2 with python3.9dist(pyramid) >= 1.9.1)
    python(abi)

python3-opencensus-ext-requests (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7.3)
    (python3.9dist(wrapt) < 2 with python3.9dist(wrapt) >= 1)
    python(abi)

python3-opencensus-ext-sqlalchemy (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    (python3.9dist(sqlalchemy) < 2 with python3.9dist(sqlalchemy) >= 1.1.14)
    python(abi)

python3-opencensus-ext-threading (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    python(abi)

python3-opencensus-ext-zipkin (rpmlib, GLIBC filtered):
    (python3.9dist(opencensus) < 1 with python3.9dist(opencensus) >= 0.7)
    python(abi)

python-opencensus-doc (rpmlib, GLIBC filtered):



Provides
--------
python3-opencensus:
    python-opencensus
    python3-opencensus
    python3.9-opencensus
    python3.9dist(opencensus)
    python3dist(opencensus)

python3-opencensus-context:
    python-opencensus-context
    python3-opencensus-context
    python3.9-opencensus-context
    python3.9dist(opencensus-context)
    python3dist(opencensus-context)

python3-opencensus-correlation:
    python-opencensus-correlation
    python3-opencensus-correlation
    python3.9-opencensus-correlation
    python3.9dist(opencensus-correlation)
    python3dist(opencensus-correlation)

python3-opencensus-ext-azure:
    python-opencensus-ext-azure
    python3-opencensus-ext-azure
    python3.9-opencensus-ext-azure
    python3.9dist(opencensus-ext-azure)
    python3dist(opencensus-ext-azure)

python3-opencensus-ext-datadog:
    python-opencensus-ext-datadog
    python3-opencensus-ext-datadog
    python3.9-opencensus-ext-datadog
    python3.9dist(opencensus-ext-datadog)
    python3dist(opencensus-ext-datadog)

python3-opencensus-ext-dbapi:
    python-opencensus-ext-dbapi
    python3-opencensus-ext-dbapi
    python3.9-opencensus-ext-dbapi
    python3.9dist(opencensus-ext-dbapi)
    python3dist(opencensus-ext-dbapi)

python3-opencensus-ext-django:
    python-opencensus-ext-django
    python3-opencensus-ext-django
    python3.9-opencensus-ext-django
    python3.9dist(opencensus-ext-django)
    python3dist(opencensus-ext-django)

python3-opencensus-ext-flask:
    python-opencensus-ext-flask
    python3-opencensus-ext-flask
    python3.9-opencensus-ext-flask
    python3.9dist(opencensus-ext-flask)
    python3dist(opencensus-ext-flask)

python3-opencensus-ext-gevent:
    python-opencensus-ext-gevent
    python3-opencensus-ext-gevent
    python3.9-opencensus-ext-gevent
    python3.9dist(opencensus-ext-gevent)
    python3dist(opencensus-ext-gevent)

python3-opencensus-ext-grpc:
    python-opencensus-ext-grpc
    python3-opencensus-ext-grpc
    python3.9-opencensus-ext-grpc
    python3.9dist(opencensus-ext-grpc)
    python3dist(opencensus-ext-grpc)

python3-opencensus-ext-httplib:
    python-opencensus-ext-httplib
    python3-opencensus-ext-httplib
    python3.9-opencensus-ext-httplib
    python3.9dist(opencensus-ext-httplib)
    python3dist(opencensus-ext-httplib)

python3-opencensus-ext-jaeger:
    python-opencensus-ext-jaeger
    python3-opencensus-ext-jaeger
    python3.9-opencensus-ext-jaeger
    python3.9dist(opencensus-ext-jaeger)
    python3dist(opencensus-ext-jaeger)

python3-opencensus-ext-logging:
    python-opencensus-ext-logging
    python3-opencensus-ext-logging
    python3.9-opencensus-ext-logging
    python3.9dist(opencensus-ext-logging)
    python3dist(opencensus-ext-logging)

python3-opencensus-ext-ocagent:
    python-opencensus-ext-ocagent
    python3-opencensus-ext-ocagent
    python3.9-opencensus-ext-ocagent
    python3.9dist(opencensus-ext-ocagent)
    python3dist(opencensus-ext-ocagent)

python3-opencensus-ext-prometheus:
    python-opencensus-ext-prometheus
    python3-opencensus-ext-prometheus
    python3.9-opencensus-ext-prometheus
    python3.9dist(opencensus-ext-prometheus)
    python3dist(opencensus-ext-prometheus)

python3-opencensus-ext-pymongo:
    python-opencensus-ext-pymongo
    python3-opencensus-ext-pymongo
    python3.9-opencensus-ext-pymongo
    python3.9dist(opencensus-ext-pymongo)
    python3dist(opencensus-ext-pymongo)

python3-opencensus-ext-pymysql:
    python-opencensus-ext-pymysql
    python3-opencensus-ext-pymysql
    python3.9-opencensus-ext-pymysql
    python3.9dist(opencensus-ext-pymysql)
    python3dist(opencensus-ext-pymysql)

python3-opencensus-ext-pyramid:
    python-opencensus-ext-pyramid
    python3-opencensus-ext-pyramid
    python3.9-opencensus-ext-pyramid
    python3.9dist(opencensus-ext-pyramid)
    python3dist(opencensus-ext-pyramid)

python3-opencensus-ext-requests:
    python-opencensus-ext-requests
    python3-opencensus-ext-requests
    python3.9-opencensus-ext-requests
    python3.9dist(opencensus-ext-requests)
    python3dist(opencensus-ext-requests)

python3-opencensus-ext-sqlalchemy:
    python-opencensus-ext-sqlalchemy
    python3-opencensus-ext-sqlalchemy
    python3.9-opencensus-ext-sqlalchemy
    python3.9dist(opencensus-ext-sqlalchemy)
    python3dist(opencensus-ext-sqlalchemy)

python3-opencensus-ext-threading:
    python-opencensus-ext-threading
    python3-opencensus-ext-threading
    python3.9-opencensus-ext-threading
    python3.9dist(opencensus-ext-threading)
    python3dist(opencensus-ext-threading)

python3-opencensus-ext-zipkin:
    python-opencensus-ext-zipkin
    python3-opencensus-ext-zipkin
    python3.9-opencensus-ext-zipkin
    python3.9dist(opencensus-ext-zipkin)
    python3dist(opencensus-ext-zipkin)

python-opencensus-doc:
    python-opencensus-doc



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1839479
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: Java, Ocaml, C/C++, Perl, R, Haskell, PHP, fonts, SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 2 Mohamed El Morabity 2020-06-15 13:39:32 UTC
Many thanks for this review ;)

(In reply to Fabian Affolter from comment #1)
> At the moment there is no binary eggs in the source but I suggest to add the
> removal to %prep in case in a future update ther eis one and not to forget
> it.
And you're right ;). This will be fixed at import, as usual ;).


> The removal of some extensions, is OK from my point of view.
> opencensus-ext-mysql is the only one that has its dependency present and
> perhaps could be enabled.
Good catch, I enabled the extension on my side, by fixing the corresponding setup.py, and it seems to work.
> - contrib/opencensus-ext-postgresql
>   Issue: >= 0.8.dev0, current 0.7.7
>   Dep: https://src.fedoraproject.org/rpms/python-psycopg2, would require a
> patch for the setup.py
It works also, as for the mysql extension (by fixing requirement to psycopg2).

Comment 3 Gwyn Ciesla 2020-06-15 17:52:49 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-opencensus

Comment 4 Fedora Update System 2020-06-17 22:37:23 UTC
FEDORA-2020-8a0be5567f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8a0be5567f

Comment 5 Fedora Update System 2020-06-18 13:41:42 UTC
FEDORA-2020-c5ebbc6add has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-c5ebbc6add \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-c5ebbc6add

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-06-18 14:14:35 UTC
FEDORA-2020-8a0be5567f has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8a0be5567f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8a0be5567f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-06-26 00:46:21 UTC
FEDORA-2020-8a0be5567f has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2020-06-26 01:07:52 UTC
FEDORA-2020-c5ebbc6add has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.