Bug 1839616 - os-autoinst: FTBFS in Fedora rawhide
Summary: os-autoinst: FTBFS in Fedora rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: os-autoinst
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adam Williamson
QA Contact: Fedora Extras Quality Assurance
URL: https://koschei.fedoraproject.org/pac...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-25 03:59 UTC by Orion Poplawski
Modified: 2020-05-25 20:43 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-25 20:42:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Orion Poplawski 2020-05-25 03:59:15 UTC
Description of problem:
Package os-autoinst fails to build from source in Fedora rawhide.

Version-Release number of selected component (if applicable):
4.6-8.20190205git63af2f4.fc33

Steps to Reproduce:
koji build --scratch f33 os-autoinst-4.6-8.20190205git63af2f4.fc33.src.rpm

Additional info:
This package is tracked by Koschei. See:
https://koschei.fedoraproject.org/package/os-autoinst

Looks like an opencv change:

fatal error: opencv2/core/core.hpp: No such file or directory

Comment 1 Adam Williamson 2020-05-25 17:00:40 UTC
I think probably caused by the changes discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1830266 . -6 failed to build, so the change didn't actually show up until -7 which appeared on 2020-05-21 .

Comment 2 Adam Williamson 2020-05-25 19:06:27 UTC
OK, it is caused by that in a sense, but it's really a bug in os-autoinst that we weren't noticing before - it's not using the opencv CFLAGS correctly, but this was hidden because there was a straight up /usr/include/opencv2 before. Now there is /usr/include/opencv4/opencv2 , and this should be fine because we should use -I/usr/include/opencv4 , but it wasn't working because Makefile.am has this:

videoencoder_CFLAGS = -O2 -Wall -W $(OPENCV_CFLAGS)

when it should be this, because videoencoder is built as C++, not C:

videoencoder_CPPFLAGS = -O2 -Wall -W $(OPENCV_CFLAGS)

with that change in place it works fine.

Comment 3 Orion Poplawski 2020-05-25 19:56:20 UTC
Those really aren't C pre-processor flags.  I think you really want to define videoencoder_CXXFLAGS.

Comment 4 Adam Williamson 2020-05-25 20:42:54 UTC
OK, fixed, build done: https://koji.fedoraproject.org/koji/taskinfo?taskID=44965205

Comment 5 Adam Williamson 2020-05-25 20:43:23 UTC
Orion: oh, that's probably right, but os-autoinst sets CPPFLAGS in two other places too, so I followed that. It probably is a thinko for CXXFLAGS, yes.


Note You need to log in before you can comment on or make changes to this bug.