Bug 1839659 - Warning VM Clone modal is inconsistent with warnings in other modal dialogs
Summary: Warning VM Clone modal is inconsistent with warnings in other modal dialogs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.5
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.5.0
Assignee: Yaacov Zamir
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-25 08:16 UTC by Radim Hrazdil
Modified: 2020-07-13 17:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:41:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshots (117.13 KB, application/zip)
2020-05-25 08:16 UTC, Radim Hrazdil
no flags Details
screenshot (72.39 KB, image/png)
2020-05-27 10:04 UTC, Radim Hrazdil
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 5582 0 None open Bug 1839659: Warning VM Clone modal is inconsistent with warnings in other modals 2020-06-24 03:19:41 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:41:39 UTC

Description Radim Hrazdil 2020-05-25 08:16:40 UTC
Created attachment 1691737 [details]
screenshots

Description of problem:
Clone VM dialog contains a warning when the cloned VM is running (see screenshot).

This warning seems to be too close to the first input field.
Additionally, there is a shadow around the warning, which is not the case for warnings found in other modal dialogs (for example scheduling related ones).

Another thing that seems inconsistent is the location.
In Cloning dialog the warning is at the top, but in scheduling dialogs, warning is displayed at the bottom.

@Matt could you please advise what should be the design of the warning?
Should it be displayed at the top/bottom
with/without shadow


Version-Release number of selected component (if applicable):
4.5

How reproducible:
100%

Comment 1 Matt 2020-05-25 12:11:25 UTC
yes this should be an inline alert not a toast alert and placed at the bottom.
https://www.patternfly.org/v4/documentation/core/components/alert#inline-types

Comment 4 Radim Hrazdil 2020-05-27 10:04:30 UTC
Verified, release-4.5

Comment 5 Radim Hrazdil 2020-05-27 10:04:50 UTC
Created attachment 1692633 [details]
screenshot

Comment 6 errata-xmlrpc 2020-07-13 17:41:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.