Spec URL: https://www.flyn.org/SRPMS/python-angr.spec SRPM URL: https://www.flyn.org/SRPMS/python-angr-8.20.1.7-1.fc32.src.rpm Description: angr is a platform-agnostic binary analysis framework with the ability to perform dynamic symbolic execution and various static analyses on binaries. Fedora Account System Username: mikep
I am still working through some packaging issues, namely a reliance on modified dependencies. Requires: https://bugzilla.redhat.com/show_bug.cgi?id=1839885 https://bugzilla.redhat.com/show_bug.cgi?id=1839886 https://bugzilla.redhat.com/show_bug.cgi?id=1839887 https://bugzilla.redhat.com/show_bug.cgi?id=1839888
*** Bug 1817721 has been marked as a duplicate of this bug. ***
- Build issue + CFLAGS='-O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' + LDFLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld' + /usr/bin/python3 setup.py build '--executable=/usr/bin/python3 -s' WARNING: The pip package is not available, falling back to EasyInstall for handling setup_requires/test_requires; this is deprecated and will be removed in a future version. Download error on https://pypi.org/simple/pyvex/: [Errno -2] Name or service not known -- Some packages may not be found! - Latest release is 8.20.6.8 - "%{pypi_source}" could be used instead of URL for Source0:
Spec URL: https://www.flyn.org/SRPMS/python-angr.spec SRPM URL: https://www.flyn.org/SRPMS/python-angr-8.20.6.8-1.fc32.src.rpm Description: angr is a platform-agnostic binary analysis framework with the ability to perform dynamic symbolic execution and various static analyses on binaries. Fedora Account System Username: mikep - New upstream version - BuildRequires gcc-c++ - Use pypi_source macro I am not yet sure what is causing the PyPI error.
Spec URL: https://www.flyn.org/SRPMS/python-angr.spec SRPM URL: https://www.flyn.org/SRPMS/python-angr-8.20.6.8-2.fc32.src.rpm Description: angr is a platform-agnostic binary analysis framework with the ability to perform dynamic symbolic execution and various static analyses on binaries. Fedora Account System Username: mikep - Add some BuildRequires This should fix the build problems.
- python-ailment, python-archinfo and python-claripy were updated to 8.20.6.8. It will require that python-cle and python-pyvex are updated as well to allow the installation as upstream is pinning the releases. - The license check also mention Apache Software License 2.0 Can you please check the licensing part before the import? Package APPROVED Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 2-clause "Simplified" License", "Unknown or generated", "Apache License (v2.0)". 687 files have unknown license. Detailed output of licensecheck in /home/fab/Documents/repos/reviews/1839889-python-angr/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [!]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 2.3 starting (python version = 3.7.7)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.3 INFO: Mock Version: 2.3 Finish: chroot init INFO: installing package(s): /home/fab/Documents/repos/reviews/1839889-python-angr/results/python3-angr-8.20.6.8-2.fc33.x86_64.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 33 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/fab/Documents/repos/reviews/1839889-python-angr/results/python3-angr-8.20.6.8-2.fc33.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: python3-angr-8.20.6.8-2.fc33.x86_64.rpm python-angr-8.20.6.8-2.fc33.src.rpm python3-angr.x86_64: W: unstripped-binary-or-object /usr/lib/python3.9/site-packages/angr/lib/angr_native.so python3-angr.x86_64: W: no-soname /usr/lib/python3.9/site-packages/angr/lib/angr_native.so python3-angr.x86_64: W: shared-lib-calls-exit /usr/lib/python3.9/site-packages/angr/lib/angr_native.so exit.5 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Unversioned so-files -------------------- python3-angr: /usr/lib/python3.9/site-packages/angr/lib/angr_native.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/angr/angr-8.20.6.8.tar.gz : CHECKSUM(SHA256) this package : 641b8b429b57ddbc3b6e6a0e9d73eca96797893e3ccf48fb09f14c2d84fb29cd CHECKSUM(SHA256) upstream package : 641b8b429b57ddbc3b6e6a0e9d73eca96797893e3ccf48fb09f14c2d84fb29cd Requires -------- python3-angr (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libpyvex.so()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libunicorn.so.1()(64bit) python(abi) python3.9dist(ailment) python3.9dist(archinfo) python3.9dist(cachetools) python3.9dist(capstone) python3.9dist(cffi) python3.9dist(claripy) python3.9dist(cle) python3.9dist(dpkt) python3.9dist(gitpython) python3.9dist(itanium-demangler) python3.9dist(mulpyplexer) python3.9dist(networkx) python3.9dist(progressbar2) python3.9dist(protobuf) python3.9dist(psutil) python3.9dist(pycparser) python3.9dist(pyvex) python3.9dist(rpyc) python3.9dist(sortedcontainers) python3.9dist(unicorn) rtld(GNU_HASH) Provides -------- python3-angr: python-angr python3-angr python3-angr(x86-64) python3.9-angr python3.9dist(angr) python3dist(angr) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1839889 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api, Python Disabled plugins: PHP, Perl, R, fonts, Java, SugarActivity, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thank you! I just requested builds of new python-cle and python-pyvex 8.20.6.8 packages, I added the licensing notes to the .spec, and added the corresponding license files to the package.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-angr