Bug 1840014 (rust-path-absolutize) - Review Request: rust-path-absolutize - Get an absolute path without dots in `Path` and `PathBuf`
Summary: Review Request: rust-path-absolutize - Get an absolute path without dots in `...
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-path-absolutize
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-26 08:59 UTC by Igor Raits
Modified: 2020-05-26 10:04 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-05-26 10:04:03 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Igor Raits 2020-05-26 08:59:08 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-path-absolutize.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-path-absolutize-1.2.1-1.fc33.src.rpm
Description:
Library for extending `Path` and `PathBuf` in order to get an absolute path and remove the containing dots.
Fedora Account System Username: ignatenkobrain

Comment 1 Fabio Valentini 2020-05-26 09:17:38 UTC
Taking this one.

Comment 2 Fabio Valentini 2020-05-26 09:38:37 UTC
Package was generated with rust2rpm, simplifying the review process.

- package builds and installs correctly on rawhide
- license is valid, correct, and acceptable
- latest version is packaged
- all unit tests are run and pass
- only sources are installed

Comment 3 Fabio Valentini 2020-05-26 09:39:08 UTC
You might want to add a comment why you're running the tests with --test-threads=1.

Comment 4 Igor Raits 2020-05-26 09:50:32 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-path-absolutize

Comment 5 Igor Raits 2020-05-26 10:04:03 UTC
(In reply to Fabio Valentini from comment #3)
> You might want to add a comment why you're running the tests with
> --test-threads=1.

Some leftover. Fixed.


Note You need to log in before you can comment on or make changes to this bug.