Bug 1840144 - [csi-driver-manila] Manila pv should not display fsType
Summary: [csi-driver-manila] Manila pv should not display fsType
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Storage
Version: 4.5
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.6.0
Assignee: Mike Fedosin
QA Contact: Wei Duan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-26 13:06 UTC by Wei Duan
Modified: 2020-10-27 16:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 16:01:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:01:13 UTC

Description Wei Duan 2020-05-26 13:06:32 UTC
Description of problem:
From manila share end user in OCP, it's just a manila NFS back end, but not show fsType as ext4(can be set to others like xfs by sc) in pv output which seems confusing as below.

Version-Release number of selected component (if applicable):
[wduan@MINT manila]$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.5.0-0.nightly-2020-05-24-104524   True        False         42h     Cluster version is 4.5.0-0.nightly-2020-05-24-104524

How reproducible:
Always

Steps to Reproduce:
1. Install csi-driver-manila-driver
2. create pvc with manila sc
3. oc get pv -o yaml

Actual results:
pv contain info like spec.csi.fsType: ext4

Expected results:
fsType should not be displayed here


Master Log:

Node Log (of failed PODs):

PV Dump:
[wduan@MINT manila]$ oc get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                     STORAGECLASS      REASON   AGE
pvc-9b9c9047-a1c0-4d15-90ff-96a57fdb9b57   1Gi        RWX            Delete           Bound    manila-csi/mypvc-manila   csi-manila-ceph            2m30s

[wduan@MINT manila]$ oc get pv pvc-9b9c9047-a1c0-4d15-90ff-96a57fdb9b57 -o yaml
apiVersion: v1
kind: PersistentVolume
metadata:
  annotations:
    pv.kubernetes.io/provisioned-by: manila.csi.openstack.org
  creationTimestamp: "2020-05-26T10:05:19Z"
  finalizers:
  - kubernetes.io/pv-protection
  name: pvc-9b9c9047-a1c0-4d15-90ff-96a57fdb9b57
  resourceVersion: "883590"
  selfLink: /api/v1/persistentvolumes/pvc-9b9c9047-a1c0-4d15-90ff-96a57fdb9b57
  uid: 007b7a67-cef1-4305-ac76-61a99808d75c
spec:
  accessModes:
  - ReadWriteMany
  capacity:
    storage: 1Gi
  claimRef:
    apiVersion: v1
    kind: PersistentVolumeClaim
    name: mypvc-manila
    namespace: manila-csi
    resourceVersion: "883563"
    uid: 9b9c9047-a1c0-4d15-90ff-96a57fdb9b57
  csi:
    driver: manila.csi.openstack.org
    fsType: ext4
    nodePublishSecretRef:
      name: csi-manila-secrets
      namespace: manila-csi
    nodeStageSecretRef:
      name: csi-manila-secrets
      namespace: manila-csi
    volumeAttributes:
      cephfs-mounter: fuse
      shareAccessID: 71c21611-2602-4719-95e6-2cced82d9aac
      shareID: 35739e9e-2c0a-49ab-80c9-ae2a0a31d9fc
      storage.kubernetes.io/csiProvisionerIdentity: 1590487024997-8081-manila.csi.openstack.org
    volumeHandle: 35739e9e-2c0a-49ab-80c9-ae2a0a31d9fc
  persistentVolumeReclaimPolicy: Delete
  storageClassName: csi-manila-ceph
  volumeMode: Filesystem
status:
  phase: Bound

  
PVC Dump:
[wduan@MINT manila]$ oc get pvc -o yaml
apiVersion: v1
items:
- apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    annotations:
      pv.kubernetes.io/bind-completed: "yes"
      pv.kubernetes.io/bound-by-controller: "yes"
      volume.beta.kubernetes.io/storage-provisioner: manila.csi.openstack.org
    creationTimestamp: "2020-05-26T10:05:14Z"
    finalizers:
    - kubernetes.io/pvc-protection
    name: mypvc-manila
    namespace: manila-csi
    resourceVersion: "883593"
    selfLink: /api/v1/namespaces/manila-csi/persistentvolumeclaims/mypvc-manila
    uid: 9b9c9047-a1c0-4d15-90ff-96a57fdb9b57
  spec:
    accessModes:
    - ReadWriteMany
    resources:
      requests:
        storage: 1Gi
    storageClassName: csi-manila-ceph
    volumeMode: Filesystem
    volumeName: pvc-9b9c9047-a1c0-4d15-90ff-96a57fdb9b57
  status:
    accessModes:
    - ReadWriteMany
    capacity:
      storage: 1Gi
    phase: Bound
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

StorageClass Dump (if StorageClass used by PV/PVC):
[wduan@MINT manila]$ oc get sc csi-manila-ceph -o yaml
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  creationTimestamp: "2020-05-26T09:56:42Z"
  name: csi-manila-ceph
  resourceVersion: "880318"
  selfLink: /apis/storage.k8s.io/v1/storageclasses/csi-manila-ceph
  uid: 679d85ed-8c7c-4bc4-8e3e-e3dc17fb186b
parameters:
  csi.storage.k8s.io/node-publish-secret-name: csi-manila-secrets
  csi.storage.k8s.io/node-publish-secret-namespace: manila-csi
  csi.storage.k8s.io/node-stage-secret-name: csi-manila-secrets
  csi.storage.k8s.io/node-stage-secret-namespace: manila-csi
  csi.storage.k8s.io/provisioner-secret-name: csi-manila-secrets
  csi.storage.k8s.io/provisioner-secret-namespace: manila-csi
  type: ceph
provisioner: manila.csi.openstack.org
reclaimPolicy: Delete
volumeBindingMode: Immediate

Additional info:

Comment 1 Jan Safranek 2020-09-30 12:26:30 UTC
This has been fixed by rebase to Kubernetes 1.19 sidecars - new external-provisioner does not fill pv.spec.fsType for Manila PVs.
Tested with: 4.6.0-0.nightly-2020-09-30-052433

Comment 4 Wei Duan 2020-10-09 07:20:22 UTC
Verified pass on 4.6.0-0.nightly-2020-10-08-210814, spec.csi.fsType did not exist any more.



[wduan@MINT 01_general]$ oc get pv pvc-689168d2-8a4f-4c11-8345-3f447c780faf -o yaml
apiVersion: v1
kind: PersistentVolume
metadata:
  annotations:
    pv.kubernetes.io/provisioned-by: manila.csi.openstack.org
  creationTimestamp: "2020-10-09T03:46:42Z"
  finalizers:
  - kubernetes.io/pv-protection
  name: pvc-689168d2-8a4f-4c11-8345-3f447c780faf
  resourceVersion: "43142"
  selfLink: /api/v1/persistentvolumes/pvc-689168d2-8a4f-4c11-8345-3f447c780faf
  uid: 505a46aa-0715-4199-bb54-07f55682568f
spec:
  accessModes:
  - ReadWriteMany
  capacity:
    storage: 1Gi
  claimRef:
    apiVersion: v1
    kind: PersistentVolumeClaim
    name: mypvc02
    namespace: default
    resourceVersion: "43115"
    uid: 689168d2-8a4f-4c11-8345-3f447c780faf
  csi:
    driver: manila.csi.openstack.org
    nodePublishSecretRef:
      name: csi-manila-secrets
      namespace: openshift-manila-csi-driver
    nodeStageSecretRef:
      name: csi-manila-secrets
      namespace: openshift-manila-csi-driver
    volumeAttributes:
      cephfs-mounter: fuse
      shareAccessID: 5a70fee0-596d-48a3-ba54-d0f2bc7feafe
      shareID: 6cae17ef-95b3-4449-810c-57d650f5226a
      storage.kubernetes.io/csiProvisionerIdentity: 1602210797377-8081-manila.csi.openstack.org
    volumeHandle: 6cae17ef-95b3-4449-810c-57d650f5226a
  persistentVolumeReclaimPolicy: Delete
  storageClassName: csi-manila-ceph
  volumeMode: Filesystem
status:
  phase: Bound

Comment 6 errata-xmlrpc 2020-10-27 16:01:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196


Note You need to log in before you can comment on or make changes to this bug.