Description of problem: If you will compare list of all images mentioned anywhere in the /manifests/4.4.0-437.ci/ocs-operator.v4.4.0-437.ci.clusterserviceversion.yaml file (for version 4.4.0-437.ci) with the images mentioned just in the relatedImages section of the file, the ose-csi-external-resizer-rhel7 image is mentioned as ROOK_CSI_RESIZER_IMAGE, but not in the relatedImages section. podman run --rm --entrypoint /usr/bin/cat quay.io/rhceph-dev/ocs-olm-operator@sha256:b2201851368352c757e8f5f0e819aaa9e66f95fd25ec91add01a5b82122f4bed /manifests/4.4.0-437.ci/ocs-operator.v4.4.0-437.ci.clusterserviceversion.yaml Version of all relevant components (if applicable): ocs-olm-operator:4.4.0-437.ci Does this issue impact your ability to continue to work with the product? This is necessary for working in restricted network environments. Is there any workaround available to the best of your knowledge? No Rate from 1 - 5 the complexity of the scenario you performed that caused this bug (1 - very simple, 5 - very complex)? 1 Can this issue reproducible? Yes Can this issue reproduce from the UI? No If this is a regression, please provide more details to justify this: No Steps to Reproduce: 1. Get ocs-operator.v4.4.0-*.ci.clusterserviceversion.yaml file: $ podman run --rm --entrypoint /usr/bin/cat \ quay.io/rhceph-dev/ocs-olm-operator:4.4.0-437.ci \ /manifests/4.4.0-437.ci/ocs-operator.v4.4.0-437.ci.clusterserviceversion.yaml \ > ocs-operator.v4.4.0-437.ci.clusterserviceversion.yaml 2. Find all images in csv file (following command might not be 100% accurate!) $ cat ocs-operator.v4.4.0-437.ci.clusterserviceversion.yaml | grep sha256 | \ sed 's/^[ -]*\(image\|value\): *//' | sort -u 3. Select all images from relatedImages section (following command might not be 100% accurate!) $ cat ocs-operator.v4.4.0-437.ci.clusterserviceversion.yaml | \ grep -A 30 relatedImages: | \ grep sha256 | sed 's/^[ -]*\(image\|value\): *//' | sort -u 4. Compare the list of images from previous two steps. Actual results: The list of all mentioned images in csv is not the same as images mentioned in the relatedImages section. Expected results: All images mentioned in the csv should be also in the relatedImages section. Additional info: See also https://bugzilla.redhat.com/show_bug.cgi?id=1798052.
Even though resizing is not supported at OCS 4.4, there was no ACK to remove it from the release CSV. So, its interesting is that how this went missing. We had a Bugzilla discussion to disable it in OCS 4.4, but got NACK https://bugzilla.redhat.com/show_bug.cgi?id=1821635 Jose/Umanga, can you check this from OCS operator side, why it went missing?
(In reply to umanga from comment #2) > We added flag to provide resizer image built by us instead of the upstream > one but missed adding it to CSV. > > https://github.com/openshift/ocs-operator/pull/534 takes care of that. Yeah, noticed that PR in between in the OCS operator repo. > > I don't understand the state of this BZ. If this is required for 4.4 > (Disconnected Install), why is the flag set for 4.5? > Do we have a separate BZ for 4.4? or do we ack this for 4.4 and request for > backport of the fix? Unfortunately, this is a regression and ideally should be fixed in OCS 4.4 builds too. Raz, Anat, Michael, we need an action plan here for OCS 4.4. That said, the upstream PR has to be merged and we have to backport this to downstream ocs operator build. Considering OCS 4.4 is planned GA tomorrow, we need an immediate action here. ps # I am also changing the component to ocs operator.
RelatedImages in the CSV if needed only for mirroring of the images for disconnected environment which will be part of OCP 4.5. Do we really need to do another build for this issue for 4.4. IIUC that it will affect only disconnected deployment and mirroring of the images but maybe I am missing something. Does it affect something else? Thanks
(In reply to Humble Chirammal from comment #1) > Even though resizing is not supported at OCS 4.4, there was no ACK to remove > it from the release CSV. So, its interesting is that how this went missing. > > We had a Bugzilla discussion to disable it in OCS 4.4, but got NACK > https://bugzilla.redhat.com/show_bug.cgi?id=1821635 Right, we decided to not disable the resizer sidecar. I am also trying to understand what is the impact of this BZ? Does it effect in disconnected not working? We already sacrificed disconnected by re-introducing lib-bucked-provisioner. So does this make the situation any worse? If no, then we don't need to do anything for 4.4 here... @Raz?
I think it only affect mirroring of the images (used for disconnected env) and nothing else. From my POV it should be targeted to OCS 4.5 and no AI needed for 4.4 .
removing needino based on Petr's reply
This is already fixed in release-4.5. I believe folks are correct in that we dropped disconnected install from OCS 4.4. The presence of lib-bucket-provisioner doesn't make it impossible to install in a disconnected environment, Annette has found out how to work around it just, but it is a manual workaround so we still don't get one-button installation for OCS in a disconnected environment. Still, backporting this would make it even easier to do as a support exception or something, so I'm fine with it. I'm giving devel_ack+.
Already fixed for 4.5 --> POST
Assigning to danny who wrote the patch. Do we actually NEED this in 4.4.z? Or is 4.5 enough?
(In reply to Michael Adam from comment #17) > Assigning to danny who wrote the patch. > > Do we actually NEED this in 4.4.z? > Or is 4.5 enough? I believe 4.5 is good enough as there's already some manual effort required in 4.4.z for disconnected install. But, it'd be good to have in 4.4.z as well. Not a blocker.
Because 4.5 PR is merged now and 4.4.2 is open for check-in, please provide devel_ack if we are planning to include this in 4.4.2
(In reply to Michael Adam from comment #17) > Assigning to danny who wrote the patch. > > Do we actually NEED this in 4.4.z? > Or is 4.5 enough? sorry for the late reply. is more information still needed?
Why is this BZ stuck in POST for so long?
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days