Bug 1840752

adcli-0.8.1-13.el7.x86_64


Description of problem:

In our AD environment we've been using the following command to delete computer objects without issue.

$ adcli delete-computer --verbose --domain=ad.gatech.edu --login-ccache=FILE:/path/to/krb5cc HOST
 ! Couldn't enumerate keytab: (null): Permission denied
adcli: couldn't lookup domain info from keytab: Couldn't enumerate keytab: (null): Permission denied


When it was working the command would continue. Here is an example. I don't know what should be considered private so I just replaced the stuff specific to us with placeholders. The host I ran this command on was "math30192".


$ adcli delete-computer --verbose --domain=ad.gatech.edu --login-ccache=FILE:/path/to/krb5cc math-thisistest.math.gatech.edu
 ! Couldn't enumerate keytab: (null): Permission denied
 * Using domain name: ad.gatech.edu
 * Calculated computer account name from fqdn: MATH30192
 * Calculated domain realm from name: AD.GATECH.EDU
 * Discovering domain controllers: _ldap._tcp.ad.gatech.edu
 * Sending netlogon pings to domain controller: cldap://SOME_IP
 * Sending netlogon pings to domain controller: ldap://SOME_IP
 * Sending netlogon pings to domain controller: cldap://SOME_IP
 * Sending netlogon pings to domain controller: ldap://SOME_IP
 * Sending netlogon pings to domain controller: cldap://SOME_IP
 ! Couldn't perform discovery search: Can't contact LDAP server
 ! Couldn't perform discovery search: Can't contact LDAP server
 * Received NetLogon info from: SOME_AD_SERVER
 * Wrote out krb5.conf snippet to /tmp/adcli-krb5-I1U1w4/krb5.d/adcli-krb5-conf-uTTwzH
 * Looked up short domain name: AD
 * Looked up domain SID: SOME_SID
 * Using fully qualified name: math30192.math.gatech.edu
 * Using domain name: ad.gatech.edu
 * Using computer account name: MATH30192
 * Using domain realm: ad.gatech.edu
 * Using fully qualified name: math-thisistest.math.gatech.edu
 * Truncated computer account name from fqdn: MATH-THISISTEST
 * Computer account for MATH-THISISTEST$ does not exist
 ! No computer account for MATH-THISISTEST$ exists
adcli: deleting math-thisistest.math.gatech.edu in ad.gatech.edu domain failed: No computer account for MATH-THISISTEST$ exists


The most recent version of adcli (adcli-0.8.1-13.el7.x86_64) breaks this workflow. After some debugging of the source RPMs I've narrowed it down to the following patch files:


In both -9 and -13:
0001-delete-use-keytab-data-to-determine-realm-and-NetBIO.patch
0001-tools-remove-errx-from-computer-commands.patch

Only in -13:
0001-Fix-for-issues-found-by-Coverity.patch


The first patch attempts to do something and if it fails prints an error message. The second patch extends this to exiting the program if there is an error.

The third patch "fixes" the function that's called in the first patch (load_host_keytab called by adcli_enroll_load) so that it returns "res" rather than "ADCLI_SUCCESS" at the end. This is great and all, but it breaks the program. As we now exit when this fails, even though it doesn't need to "succeed" for the delete command to work properly.