Description of problem:
Coverity identified a problem in a load_cache() warning branch when a specific type of inconsistency is found in the cache metadata: the "images" variable used to report the error is incorrect and should be "image_id":


commit d788f82746826d091abcdf76b5f4884c22e3b7de
Author: Bryn M. Reeves <bmr>
Date:   Wed May 20 15:14:27 2020 +0100

    boom.cache: use correct variable in load_cache() warning branch
    
    Signed-off-by: Bryn M. Reeves <bmr>

diff --git a/boom/cache.py b/boom/cache.py
index 1dc5e07..cf7de47 100644
--- a/boom/cache.py
+++ b/boom/cache.py
@@ -238,7 +238,7 @@ def load_cache(verify=True, digests=False):
     images = cachedata["images"]
     for image_id in images.keys():
         if image_id not in ids:
-            _log_warn("Found orphan image_id '%s'" % image)
+            _log_warn("Found orphan image_id '%s'" % image_id)
             # clean up?
 
     _log_debug("Loaded %d cache paths and %d images" %


Version-Release number of selected component (if applicable):
1.1-1.el8

How reproducible:
100%

Steps to Reproduce:
1. Create at least one cache entry by using 'boom create --backup'
2. Use "boom cache list" to identify any image_id, e.g.:

# boom cache list
Path                                   ImageID Timestamp  State   
/vmlinuz-4.16.11-100.fc26.x86_64       0c703b0 1588366186 CACHED  
/vmlinuz-3.10.1-1.el7                  ee3e6f8 1588366186 CACHED  
/initramfs-3.10.1-1.el7.img            0f61425 1588366186 RESTORED
/initramfs-4.16.11-100.fc26.x86_64.img 77dc54e 1588366186 CACHED
  
3. Delete the cache image file for the corresponding image_id:

# rm /boot/boom/cache/0c703b0*.img

4. Run "boom cache list" (or any command that loads the boom cache)

Actual results:
$ boom cache list
WARNING - Image identifier '0c703b03017edda8296b2208f3742e90d0494b76' not found in cache
ERROR - Command failed: global name 'image' is not defined
WARNING - Image identifier '0c703b03017edda8296b2208f3742e90d0494b76' not found in cache
ERROR - Could not clean boot image cache: global name 'image' is not defined

$ boom cache list --debug=all
WARNING - Image identifier '0c703b03017edda8296b2208f3742e90d0494b76' not found in cache
Traceback (most recent call last):
  File "/home/breeves/src/git/boom/bin/boom", line 7, in <module>
    r = main(sys.argv)
  File "/home/breeves/src/git/boom/boom/command.py", line 3231, in main
    status = command[1](cmd_args, select, opts, identifier)
  File "/home/breeves/src/git/boom/boom/command.py", line 2804, in _list_cache_cmd
    print_fn)
  File "/home/breeves/src/git/boom/boom/command.py", line 2154, in _generic_list_cmd
    expand=cmd_args.expand_variables)
  File "/home/breeves/src/git/boom/boom/command.py", line 1776, in print_cache
    output_fields=output_fields, sort_keys=sort_keys)
  File "/home/breeves/src/git/boom/boom/command.py", line 1752, in _print_cache
    ces = find_fn(selection=selection)
  File "/home/breeves/src/git/boom/boom/cache.py", line 718, in find_cache_paths
    matches = _find_cache_entries(selection=selection, images=False)
  File "/home/breeves/src/git/boom/boom/cache.py", line 672, in _find_cache_entries
    load_cache()
  File "/home/breeves/src/git/boom/boom/cache.py", line 241, in load_cache
    _log_warn("Found orphan image_id '%s'" % image)
NameError: global name 'image' is not defined

Expected results:
$ boom cache list
WARNING - Image identifier '0c703b03017edda8296b2208f3742e90d0494b76' not found in cache
WARNING - Found orphan image_id '0c703b03017edda8296b2208f3742e90d0494b76'
Path                                   ImageID Timestamp  State   
/vmlinuz-4.16.11-100.fc26.x86_64       0c703b0 1588366186 BROKEN  
/vmlinuz-3.10.1-1.el7                  ee3e6f8 1588366186 CACHED  
/initramfs-3.10.1-1.el7.img            0f61425 1588366186 RESTORED
/initramfs-4.16.11-100.fc26.x86_64.img 77dc54e 1588366186 CACHED  

Additional info: