Bug 1840914 - Review Request: mpsolve - Multiprecision polynomial solver
Summary: Review Request: mpsolve - Multiprecision polynomial solver
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Erich Eickmeyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-27 21:21 UTC by Jerry James
Modified: 2020-06-11 22:56 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-06-11 22:56:56 UTC
Type: ---
Embargoed:
erich: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2020-05-27 21:21:08 UTC
Spec URL: https://jjames.fedorapeople.org/mpsolve/mpsolve.spec
SRPM URL: https://jjames.fedorapeople.org/mpsolve/mpsolve-3.1.8-1.fc33.src.rpm
Fedora Account System Username: jjames
Description: MPSolve stands for Multiprecision Polynomial SOLVEr.  It aims to provide an easy to use universal blackbox for solving polynomials and secular equations.

Its features include:
- Arbitrary precision approximation.
- Guaranteed inclusion radii for the results.
- Exploiting of polynomial structures: it can take advantage of sparsity
  as well as coefficients in a particular domain (i.e. integers or
  rationals).
- It can be specialized for specific classes of polynomials.  As an
  example, the roots of the Mandelbrot polynomial of degree 2,097,151
  were computed in about 10 days on a dual Xeon server.

Comment 1 Erich Eickmeyer 2020-05-28 19:40:08 UTC
I have found the following (possible) issues:

- mpsolve-libs.x86_64: E: library-not-linked-against-libc /usr/lib64/libmps-fortran.so.0.0.1
  * I'm not 100% sure if this is a false-positive, but it was found by RPM lint.
- mpsolve.src: E: specfile-error warning: line 141: Possible unexpanded macro in: Requires:       octave(api) = %{octave_api}
  * Again, not 100% positive on this one here.
- Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mpsolve-
  libs , mpsolve-devel , xmpsolve , python3-mpsolve , octave-mpsolve
  * This is a spot where I'm not 100% confident in what's going on here.
    From what I can see, there are spots where this is happening?

Other than that, if these aren't actual issues, LGTM.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "FSF All Permissive License", "Expat
     License", "GPL (v3 or later)", "FSF Unlimited License (with Retention)
     GNU General Public License (v2)", "FSF Unlimited License (with
     Retention)", "Mozilla Public License 1.1", "*No copyright* GNU General
     Public License (v3)". 527 files have unknown license. Detailed output
     of licensecheck in
     /home/erich/Dev/~Reviewdir/mpsolve/1840914-mpsolve/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mpsolve-
     libs , mpsolve-devel , xmpsolve , python3-mpsolve , octave-mpsolve
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Scriptlets must be sane, if used.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: mpsolve-3.1.8-1.fc33.x86_64.rpm
          mpsolve-libs-3.1.8-1.fc33.x86_64.rpm
          mpsolve-doc-3.1.8-1.fc33.noarch.rpm
          mpsolve-devel-3.1.8-1.fc33.x86_64.rpm
          xmpsolve-3.1.8-1.fc33.x86_64.rpm
          python3-mpsolve-3.1.8-1.fc33.noarch.rpm
          octave-mpsolve-3.1.8-1.fc33.x86_64.rpm
          mpsolve-debuginfo-3.1.8-1.fc33.x86_64.rpm
          mpsolve-debugsource-3.1.8-1.fc33.x86_64.rpm
          mpsolve-3.1.8-1.fc33.src.rpm
mpsolve.x86_64: W: spelling-error Summary(en_US) Multiprecision -> Multiprocessing
mpsolve.x86_64: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
mpsolve.x86_64: W: no-manual-page-for-binary root_of_unity
mpsolve-libs.x86_64: W: spelling-error Summary(en_US) Multiprecision -> Multiprocessing
mpsolve-libs.x86_64: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
mpsolve-libs.x86_64: E: library-not-linked-against-libc /usr/lib64/libmps-fortran.so.0.0.1
mpsolve-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libmps.so.3.0.1 exit.5
mpsolve-doc.noarch: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
xmpsolve.x86_64: W: spelling-error Summary(en_US) mpsolve -> mp solve, mp-solve, solve
xmpsolve.x86_64: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
xmpsolve.x86_64: W: spelling-error %description -l en_US mpsolve -> mp solve, mp-solve, solve
python3-mpsolve.noarch: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
python3-mpsolve.noarch: W: no-documentation
octave-mpsolve.x86_64: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
octave-mpsolve.x86_64: W: dangerous-command-in-%preun mv
mpsolve.src: W: spelling-error Summary(en_US) Multiprecision -> Multiprocessing
mpsolve.src: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
mpsolve.src: E: specfile-error warning: line 141: Possible unexpanded macro in: Requires:       octave(api) = %{octave_api}
10 packages and 0 specfiles checked; 2 errors, 16 warnings.




Rpmlint (debuginfo)
-------------------
Checking: mpsolve-debuginfo-3.1.8-1.fc33.x86_64.rpm
          mpsolve-libs-debuginfo-3.1.8-1.fc33.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
xmpsolve.x86_64: W: spelling-error Summary(en_US) mpsolve -> mp solve, mp-solve, solve
xmpsolve.x86_64: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
xmpsolve.x86_64: W: spelling-error %description -l en_US mpsolve -> mp solve, mp-solve, solve
xmpsolve.x86_64: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-mpsolve.noarch: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
python3-mpsolve.noarch: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
python3-mpsolve.noarch: W: no-documentation
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
mpsolve-devel.x86_64: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
mpsolve-doc.noarch: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
mpsolve-doc.noarch: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
octave-mpsolve.x86_64: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
octave-mpsolve.x86_64: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
octave-mpsolve.x86_64: W: dangerous-command-in-%preun mv
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
mpsolve.x86_64: W: spelling-error Summary(en_US) Multiprecision -> Multiprocessing
mpsolve.x86_64: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
mpsolve.x86_64: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
mpsolve.x86_64: W: no-manual-page-for-binary root_of_unity
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
mpsolve-libs-debuginfo.x86_64: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
mpsolve-debuginfo.x86_64: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
mpsolve-debugsource.x86_64: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
mpsolve-libs.x86_64: W: spelling-error Summary(en_US) Multiprecision -> Multiprocessing
mpsolve-libs.x86_64: W: spelling-error %description -l en_US blackbox -> black box, black-box, blackboard
mpsolve-libs.x86_64: W: invalid-url URL: https://numpi.dm.unipi.it/software/mpsolve <urlopen error [Errno -2] Name or service not known>
mpsolve-libs.x86_64: E: library-not-linked-against-libc /usr/lib64/libmps-fortran.so.0.0.1
mpsolve-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libmps.so.3.0.1 exit.5
10 packages and 0 specfiles checked; 1 errors, 24 warnings.



Source checksums
----------------
https://raw.githubusercontent.com/robol/MPSolve/master/doc/doxygen/doxygen.css :
  CHECKSUM(SHA256) this package     : e5187b44ad710eb418c32a8e8dd41307543864ba3d64652eb1e420204adbc1fe
  CHECKSUM(SHA256) upstream package : e5187b44ad710eb418c32a8e8dd41307543864ba3d64652eb1e420204adbc1fe
https://raw.githubusercontent.com/robol/MPSolve/master/examples/octave/octave_support.h :
  CHECKSUM(SHA256) this package     : d88d5e982b11512e7e2af82db89f0481759d9c50c27d9c8261220bd1b508f136
  CHECKSUM(SHA256) upstream package : d88d5e982b11512e7e2af82db89f0481759d9c50c27d9c8261220bd1b508f136
https://raw.githubusercontent.com/robol/MPSolve/master/examples/octave/mps_polyeig.m :
  CHECKSUM(SHA256) this package     : a587cf303d95c1b3237286e8275bc3c92e457adb0cc35714a085637ea05864e1
  CHECKSUM(SHA256) upstream package : a587cf303d95c1b3237286e8275bc3c92e457adb0cc35714a085637ea05864e1
https://raw.githubusercontent.com/robol/MPSolve/master/examples/octave/DESCRIPTION :
  CHECKSUM(SHA256) this package     : 9976181bbe24bed90af6792401c2b92965c3540ced5c44104dd440e391bc9bea
  CHECKSUM(SHA256) upstream package : 9976181bbe24bed90af6792401c2b92965c3540ced5c44104dd440e391bc9bea
https://numpi.dm.unipi.it/_media/software/mpsolve/mpsolve-3.1.8.tar.bz2 :
  CHECKSUM(SHA256) this package     : 53c39890a1cf4bfe505c5e4835b4b3f2aa56794b17ac59c018f1226f0acd323b
  CHECKSUM(SHA256) upstream package : 53c39890a1cf4bfe505c5e4835b4b3f2aa56794b17ac59c018f1226f0acd323b


Requires
--------
mpsolve (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libgdk-3.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmp.so.10()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-3.so.0()(64bit)
    libm.so.6()(64bit)
    libmps.so.3()(64bit)
    libpthread.so.0()(64bit)
    mpsolve-libs(x86-64)
    rtld(GNU_HASH)

mpsolve-libs (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgmp.so.10()(64bit)
    libgmpxx.so.4()(64bit)
    libm.so.6()(64bit)
    libmps.so.3()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

mpsolve-doc (rpmlib, GLIBC filtered):

mpsolve-devel (rpmlib, GLIBC filtered):
    gmp-devel(x86-64)
    libmps-fortran.so.0()(64bit)
    libmps.so.3()(64bit)
    mpsolve-libs(x86-64)

xmpsolve (rpmlib, GLIBC filtered):
    hicolor-icon-theme
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.14)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Qml.so.5()(64bit)
    libQt5Qml.so.5(Qt_5)(64bit)
    libQt5Quick.so.5()(64bit)
    libQt5Quick.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgmp.so.10()(64bit)
    libm.so.6()(64bit)
    libmps.so.3()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    mpsolve-libs(x86-64)
    rtld(GNU_HASH)
    shared-mime-info(x86-64)

python3-mpsolve (rpmlib, GLIBC filtered):
    mpsolve-libs
    python(abi)

octave-mpsolve (rpmlib, GLIBC filtered):
    /bin/sh
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmps.so.3()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    mpsolve-libs(x86-64)
    octave
    octave(api)
    rtld(GNU_HASH)

mpsolve-debuginfo (rpmlib, GLIBC filtered):

mpsolve-debugsource (rpmlib, GLIBC filtered):



Provides
--------
mpsolve:
    mpsolve
    mpsolve(x86-64)

mpsolve-libs:
    libmps-fortran.so.0()(64bit)
    libmps.so.3()(64bit)
    mpsolve-libs
    mpsolve-libs(x86-64)

mpsolve-doc:
    mpsolve-doc

mpsolve-devel:
    mpsolve-devel
    mpsolve-devel(x86-64)

xmpsolve:
    application()
    application(xmpsolve.desktop)
    mimehandler(application/x-mpsolve)
    xmpsolve
    xmpsolve(x86-64)

python3-mpsolve:
    python-mpsolve
    python3-mpsolve
    python3.8-mpsolve

octave-mpsolve:
    octave-mpsolve
    octave-mpsolve(x86-64)

mpsolve-debuginfo:
    debuginfo(build-id)
    mpsolve-debuginfo
    mpsolve-debuginfo(x86-64)

mpsolve-debugsource:
    mpsolve-debugsource
    mpsolve-debugsource(x86-64)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1840914
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic, Python
Disabled plugins: SugarActivity, Java, PHP, Perl, R, fonts, Ocaml, Haskell
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 2 Jerry James 2020-05-28 20:47:11 UTC
Thanks for the review, Erich.

(In reply to Erich Eickmeyer from comment #1)
> I have found the following (possible) issues:
> 
> - mpsolve-libs.x86_64: E: library-not-linked-against-libc
> /usr/lib64/libmps-fortran.so.0.0.1

Yes, that's the fortran interface, and it doesn't need the C library.  The resulting shared object doesn't have any unresolved symbols, which is evidence that it really doesn't need libc.

>   * I'm not 100% sure if this is a false-positive, but it was found by RPM
> lint.
> - mpsolve.src: E: specfile-error warning: line 141: Possible unexpanded
> macro in: Requires:       octave(api) = %{octave_api}

I'm not sure what to do about this.  The octave_api macro is apparently not defined when the source RPM is created.  However, it is defined at build time.  After doing a Rawhide build, for example:

$ rpm -q --requires -p octave-mpsolve-3.1.8-1.fc33.x86_64.rpm
...
octave(api) = api-v53
...

So I don't think this is an actual problem.


>   * Again, not 100% positive on this one here.
> - Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mpsolve-
>   libs , mpsolve-devel , xmpsolve , python3-mpsolve , octave-mpsolve
>   * This is a spot where I'm not 100% confident in what's going on here.
>     From what I can see, there are spots where this is happening?

This is kind of a complex package.  It probably wasn't fair of me to ask you to review it.  There is a library (which is actually the only part I really need), there are command line tools, a GUI, and interfaces to the library from octave and python.  All of these have to go into separate subpackages, to manage the dependencies.  When a package has both a library and one or more binaries linked to that library, two forms of organization are common:

- Make the main package contain the library and a subpackage contain the binaries.  You might have a package named libfoo, for example, and the binaries go into libfoo-tools.
- Make the main package contain the binaries and a subpackage contain the library.  You might have a package named foo, for example, and the library goes into foo-libs.

I have chosen the second approach in this case, because the main package name is also the name of one of the binaries, so I thought that would lead to less confusion.  This means that everything except mpsolve-libs (and mpsolve-doc) has to depend on mpsolve-libs, rather than on mpsolve, the main package.  Look for "Requires: %{name}-libs%{?_isa} = %{version}-%{release}"; you'll find it in the main package, and the devel xmpsolve, python3-mpsolve, and octave-mpsolve subpackages.  The mpsolve-doc package doesn't need any dependencies at all, because it is just documentation.

If you are going to sign on as the official reviewer here, then up top where it says "Assignee", click on the "take" button.  Go to the right of that where it says "Flags", and click on "set flags", then change the fedora-review flag to "?" to mark the review as in progress.  You will change that to "+" when you think the package should be approved.  At the bottom, find "Status" and change it from "NEW" to "ASSIGNED".  If you already knew all this, pardon me for mansplaining.

Comment 3 Erich Eickmeyer 2020-05-28 21:01:03 UTC
> If you are going to sign on as the official reviewer here, then up top where it says "Assignee", click on the "take" button.
> Go to the right of that where it says "Flags", and click on "set flags", then change the fedora-review flag to "?" to mark the
> review as in progress.  You will change that to "+" when you think the package should be approved.  At the bottom, find "Status"
> and change it from "NEW" to "ASSIGNED".  If you already knew all this, pardon me for mansplaining.

Yep, I knew all of this, but it simply won't let me. Not sure why. Bugzilla is... bugizlla.

Other than that, I feel like you justified everything, but I don't feel qualified to approve this complex of a package. I guess since I've done most of the legwork, someone more qualified will have a ton less to do. :)

Comment 4 Jerry James 2020-05-28 21:23:07 UTC
Have you been sponsored into the packager group?

Comment 5 Jerry James 2020-05-28 21:27:37 UTC
Yes, you have.  Okay, let's get the attention of somebody who can fix things for you.

Comment 6 Jerry James 2020-05-28 21:44:37 UTC
See https://pagure.io/fedora-infrastructure/issue/8963

Comment 7 Jerry James 2020-06-01 14:36:56 UTC
Erich, you should have reviewer privileges now.  If you feel comfortable acting in the role of reviewer for this bug, then please proceed.  If you don't, please let me know and I will get somebody else to do the full review.  Thank you for what you have done so far.

Comment 8 Erich Eickmeyer 2020-06-01 15:45:02 UTC
Hi Jerry,  I feel as though you justified everything, even though I don't quite understand it.


This package is APPROVED.

Comment 9 Jerry James 2020-06-02 14:38:14 UTC
Thank you, Erich.  Let me know if you need more reviews.

Comment 10 Gwyn Ciesla 2020-06-02 17:20:56 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mpsolve

Comment 11 Fedora Update System 2020-06-02 20:27:20 UTC
FEDORA-2020-dd910447e5 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-dd910447e5

Comment 12 Fedora Update System 2020-06-03 03:12:08 UTC
FEDORA-2020-dd910447e5 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-dd910447e5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-dd910447e5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2020-06-11 22:56:56 UTC
mpsolve-3.1.8-1.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.