Description of problem:
If a user provides an interrupt (CTRL + C) when selecting vSphere platform options from the survey:
1. the survey does not stop
2. a panic occurs
How reproducible: always
Steps to Reproduce:
$ ./openshift-install create install-config --dir int
? SSH Public Key <none>
? Platform vsphere
? vCenter [? for help] (PRESS CTRL + C)
? Username [? for help] (PRESS CTRL + C)
? Password [? for help] (PRESS CTRL + C)
INFO Connecting to vCenter
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x198f047]
goroutine 1 [running]:
github.com/openshift/installer/pkg/types/vsphere.CreateVSphereClients(0xd954cc0, 0xc00012f3e0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
The installer should handle the interrupts gracefully.
This is due to the fact that the vSphere survey does not have error handling.
The bug is verified with nightly build: 4.5.0-0.nightly-2020-05-31-230932.
”Ctrl+Z" can interrupt the installation and exit from survey with vsphere platform option.
# ./openshift-install create cluster --dir install_ipitest
? SSH Public Key /root/.ssh/openshift-qe.pub
? Platform vsphere
? vCenter vcsa2-qe.vmware.devcluster.openshift.com
? Username Administrator@e2e.local
? Password [? for help] ************
INFO Connecting to vCenter vcsa2-qe.vmware.devcluster.openshift.com
INFO Defaulting to only available datacenter: dc1
INFO Defaulting to only available cluster: devel
? Default Datastore 10TB-GOLD
? Network Disconnected
? Virtual IP Address for API 188.8.131.52
? Virtual IP Address for Ingress 184.108.40.206
? Base Domain qe.devcluster.openshift.com
? Cluster Name test
? Pull Secret [? for help]
FATAL failed to fetch Metadata: failed to fetch dependency of "Metadata": failed to fetch dependency of "Cluster ID": failed to fetch dependency of "Install Config": failed to generate asset "Pull Secret": interrupt
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.