Bug 1841119 - Get rid of config patches and pass flags directly to kcm
Summary: Get rid of config patches and pass flags directly to kcm
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: kube-controller-manager
Version: 4.6
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.7.0
Assignee: Maciej Szulik
QA Contact: zhou ying
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-28 12:27 UTC by Maciej Szulik
Modified: 2021-02-24 15:13 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-24 15:12:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-kube-controller-manager-operator pull 471 0 None closed Bug 1841119: Apply extendedArguments directly to kcm 2021-01-18 10:36:37 UTC
Github openshift cluster-kube-controller-manager-operator pull 492 0 None closed Bug 1841119: apply extendedArguments directly to kcm in bootstrap 2021-01-19 06:21:00 UTC
Github openshift kubernetes pull 415 0 None closed Bug 1841119: UPSTREAM: <carry>: kube-controller-manager: allow running bare kube-controller-manager 2021-01-18 10:36:38 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:13:02 UTC

Description Maciej Szulik 2020-05-28 12:27:00 UTC
Currently kcm has a following patch: https://github.com/openshift/kubernetes/commit/cf44fdb6ac91a8bb8775f729318c695f1e6195e5 which parses openshift-config and passes extraArguments as flags but inside the code. This was recently fixed in https://github.com/openshift/origin/pull/25037

We need to get rid of this carry patch and pass flags directly, instead.

Comment 1 Maciej Szulik 2020-06-18 10:16:32 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

Comment 2 Maciej Szulik 2020-07-09 11:07:13 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

Comment 3 Maciej Szulik 2020-08-21 14:11:42 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

Comment 4 Michal Fojtik 2020-09-08 09:10:35 UTC
This bug hasn't had any activity in the last 30 days. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're marking this bug as "LifecycleStale" and decreasing the severity/priority. If you have further information on the current state of the bug, please update it, otherwise this bug can be closed in about 7 days. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. Additionally, you can add LifecycleFrozen into Keywords if you think this bug should never be marked as stale. Please consult with bug assignee before you do that.

Comment 5 Maciej Szulik 2020-09-08 09:37:21 UTC
It's still being worked on.

Comment 6 Maciej Szulik 2020-09-11 10:49:36 UTC
This requires a significant amount of work, and we won't be able to address that in 4.6, moving to 4.7

Comment 7 Maciej Szulik 2020-10-01 14:48:42 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

Comment 8 Michal Fojtik 2020-10-11 11:12:05 UTC
This bug hasn't had any activity in the last 30 days. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're marking this bug as "LifecycleStale" and decreasing the severity/priority. If you have further information on the current state of the bug, please update it, otherwise this bug can be closed in about 7 days. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. Additionally, you can add LifecycleFrozen into Keywords if you think this bug should never be marked as stale. Please consult with bug assignee before you do that.

Comment 9 Maciej Szulik 2020-10-12 09:43:14 UTC
This is actively being worked one, like just now :-)

Comment 10 Maciej Szulik 2020-11-13 10:58:00 UTC
This is waiting in the queue for green CI and reviews.

Comment 11 Maciej Szulik 2020-12-04 16:26:28 UTC
PR in the queue.

Comment 12 Maciej Szulik 2020-12-09 12:32:10 UTC
I've marked this as blocker b/c having this included will allow us to simplify k8s upgrades. 
We're moving the configuration of kube-controller-manager from openshift/kubernetes to
the operator. The operator bits already merged https://github.com/openshift/cluster-kube-controller-manager-operator/pull/471
and https://github.com/openshift/kubernetes/pull/415 changes are waiting for k8s bump to land
and will merge right afterwards.

Comment 13 Maciej Szulik 2021-01-15 12:03:35 UTC
PR in the queue.

Comment 18 errata-xmlrpc 2021-02-24 15:12:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.