Bug 1841870 - Suggestions for openfortivpn.spec
Summary: Suggestions for openfortivpn.spec
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: openfortivpn
Version: 32
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-29 16:55 UTC by Dimitri Papadopoulos
Modified: 2020-06-18 01:22 UTC (History)
2 users (show)

Fixed In Version: openfortivpn-1.14.1-1.fc31 openfortivpn-1.14.1-1.fc32 openfortivpn-1.14.1-1.el7 openfortivpn-1.14.1-1.el8
Clone Of:
Environment:
Last Closed: 2020-06-11 18:58:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Dimitri Papadopoulos 2020-05-29 16:55:47 UTC
Description of problem:

The .spec file should change from:
BuildRequires:  openssl-devel
BuildRequires:  systemd-devel
to:
BuildRequires:  pkgconfig(openssl)
BuildRequires:  pkgconfig(systemd)

See discussion here:
https://fedoraproject.org/wiki/PackagingDrafts/PkgConfigBuildRequires


Also, the upstream package contains two license files:
* LICENSE which contains the GPLv3 with OpenSSL exception,
* LICENSE.OpenSSL which contains the OpenSSL license.

Shouldn't we have both files in the RPM?
%license LICENSE LICENSE.OpenSSL
Alternatively is LICENSE.OpenSSL really required in upstream package?


Finally could we add the systemd service file to %files?
%{_unitdir}/openfortivpn@.service

Comment 1 Adrien Vergé 2020-06-01 06:11:24 UTC
Thank you Dimitri, I just applied these 3 changes to the package.

About the LICENSE.OpenSSL file, I'm not sure. If there is a doubt, I'm for keeping it.

Comment 2 Fedora Update System 2020-06-01 06:12:39 UTC
FEDORA-EPEL-2020-fd77107a21 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-fd77107a21

Comment 3 Fedora Update System 2020-06-01 06:12:40 UTC
FEDORA-EPEL-2020-121fd593f9 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-121fd593f9

Comment 4 Fedora Update System 2020-06-01 06:12:40 UTC
FEDORA-2020-6e12ce6fdf has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e12ce6fdf

Comment 5 Fedora Update System 2020-06-02 03:56:27 UTC
FEDORA-EPEL-2020-fd77107a21 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-fd77107a21

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-06-02 04:00:31 UTC
FEDORA-2020-a1072e0f3a has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-a1072e0f3a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a1072e0f3a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-06-02 04:51:17 UTC
FEDORA-EPEL-2020-121fd593f9 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-121fd593f9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-06-02 05:03:29 UTC
FEDORA-2020-6e12ce6fdf has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-6e12ce6fdf`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e12ce6fdf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-06-11 18:58:48 UTC
openfortivpn-1.14.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2020-06-11 22:56:17 UTC
openfortivpn-1.14.1-1.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2020-06-18 00:33:41 UTC
FEDORA-EPEL-2020-121fd593f9 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2020-06-18 01:22:03 UTC
FEDORA-EPEL-2020-fd77107a21 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.