Bug 1842844
| Summary: | Samba should use TLS priority lists from crypto policies | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Ondrej Moriš <omoris> |
| Component: | samba | Assignee: | Andreas Schneider <asn> |
| Status: | CLOSED ERRATA | QA Contact: | sssd-qe <sssd-qe> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 8.2 | CC: | abokovoy, asn, asosedki, dkarpele, dueno, gdeschner, iboukris, jarrpa |
| Target Milestone: | rc | Flags: | pm-rhel:
mirror+
|
| Target Release: | 8.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | samba-4.12.3-6.el8.3 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-04 01:59:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1842847 | ||
|
Description
Ondrej Moriš
2020-06-02 07:50:45 UTC
The bug report is misleading. It talks about OpenSSL and functions that aren't even exist in Samba source code. In reality, the issue is with GnuTLS gnutls_priority_set_direct() calls. According to Fedora documentation, the following applies: https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ ... GnuTLS applications: If the application provides a configuration file that allows to modify the cipher priority string, the shipped file contains "@SYSTEM" as default. In that case no further action is required. If the application doesn’t have a configuration file, ensure that it uses gnutls_set_default_priority(), or that the default priority string is "@SYSTEM". That is, check the source code for gnutls_priority_set_direct(), gnutls_priority_init(); if they are not present and gnutls_set_default_priority() is used, nothing needs to be done. Otherwise check the strings provided by the application. If it contains PSK or SRP do nothing (these applications are not currently covered by the default policy). If not, then replace gnutls_priority_set_direct() with gnutls_set_default_priority(). If gnutls_priority_init() is used instead with a fixed string, replace the string with "@SYSTEM". Samba defaults to 'NORMAL:-VERS-SSL3.0' for 'tls priority' setting. I'd suggest we change default configuration on Fedora and RHEL to use '@SYSTEM' instead. Thanks for clarification Alexander. Sorry about misleading description, it was generated automatically and this one gnutls application slipped to the openssl applications list. The most important is the "Actual result" part which is thankfully correct. Anyway, your analysis is perfect description of the problem, thanks. The reality is that this doesn't seem to be working correctly in GnuTLS. See https://gitlab.com/gnutls/gnutls/-/issues/1046 We will revert to NORMAL:-VERS-SSL3.0 which is working correctly. (In reply to Andreas Schneider from comment #5) > The reality is that this doesn't seem to be working correctly in GnuTLS. Andreas, could you be more specific? Does it mean that setting @SYSTEM does not work for samba? Ondrej, it doesn't work as expected as the fallbacks don't work as expected. Samba is running on other systems which are not only RHEL so we had to revert this upstream. We need GnuTLS to support this correctly first. However the code calls gnutls_set_default_priority() first now. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (samba bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2020:4543 |