Bug 1843327 - [vsphere]Machine status should be "Failed" with an invalid configuration
Summary: [vsphere]Machine status should be "Failed" with an invalid configuration
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.5
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.6.0
Assignee: Alexander Demicev
QA Contact: sunzhaohua
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-03 03:39 UTC by sunzhaohua
Modified: 2020-10-27 16:05 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 16:04:37 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift machine-api-operator pull 605 0 None closed Bug 1843327: [vSphere] Improve provider spec validation 2020-08-24 17:49:59 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:04:59 UTC

Description sunzhaohua 2020-06-03 03:39:46 UTC
Description of problem:
IPI vsphere, machine status should be "Failed" when creating a machine with invalid configuration

Version-Release number of selected component (if applicable):
4.5.0-0.nightly-2020-06-01-165039

How reproducible:
Always

Steps to Reproduce:
1. Creating a machine with invalid template
      template: pmali-shared-62-vgkj5-rhcos-invalid
2. Check machines and logs
  
Actual results:
Machine stuck in Provisioning status

$ oc get machine
NAME                                         PHASE          TYPE   REGION   ZONE   AGE
pmali-shared-62-vgkj5-master-0               Running                               24h
pmali-shared-62-vgkj5-master-1               Running                               24h
pmali-shared-62-vgkj5-master-2               Running                               24h
pmali-shared-62-vgkj5-worker-fjngh           Running                               24h
pmali-shared-62-vgkj5-worker-fjngh-invalid   Provisioning                          7m58s
pmali-shared-62-vgkj5-worker-gxfnm           Running                               24h
pmali-shared-62-vgkj5-worker-z2lv8           Running                               24h

status:
  lastUpdated: "2020-06-03T02:23:04Z"
  phase: Provisioning
  providerStatus:
    conditions:
    - lastProbeTime: "2020-06-03T02:23:04Z"
      lastTransitionTime: "2020-06-03T02:23:04Z"
      message: vm 'pmali-shared-62-vgkj5-rhcos-invalid' not found
      reason: MachineCreationFailed
      status: "False"
      type: MachineCreation

I0603 02:23:14.489029       1 controller.go:169] pmali-shared-62-vgkj5-worker-fjngh-invalid: reconciling Machine
I0603 02:23:14.489063       1 actuator.go:80] pmali-shared-62-vgkj5-worker-fjngh-invalid: actuator checking if machine exists
I0603 02:23:14.516886       1 session.go:113] Find template by instance uuid: de04c0d1-07a7-4d32-b9d8-cc0be95151f6
I0603 02:23:14.559999       1 reconciler.go:155] pmali-shared-62-vgkj5-worker-fjngh-invalid: does not exist
I0603 02:23:14.561709       1 controller.go:313] pmali-shared-62-vgkj5-worker-fjngh-invalid: reconciling machine triggers idempotent create
I0603 02:23:14.561764       1 actuator.go:59] pmali-shared-62-vgkj5-worker-fjngh-invalid: actuator creating machine
I0603 02:23:15.235366       1 session.go:113] Find template by instance uuid: de04c0d1-07a7-4d32-b9d8-cc0be95151f6
I0603 02:23:15.269202       1 reconciler.go:83] pmali-shared-62-vgkj5-worker-fjngh-invalid: cloning
I0603 02:23:15.269253       1 session.go:110] Invalid UUID for VM "pmali-shared-62-vgkj5-rhcos-invalid": , trying to find by name
I0603 02:23:15.311890       1 reconciler.go:653] pmali-shared-62-vgkj5-worker-fjngh-invalid: Updating provider status
I0603 02:23:15.311915       1 machine_scope.go:101] pmali-shared-62-vgkj5-worker-fjngh-invalid: patching machine
E0603 02:23:15.360326       1 actuator.go:50] pmali-shared-62-vgkj5-worker-fjngh-invalid error: vm 'pmali-shared-62-vgkj5-rhcos-invalid' not found
W0603 02:23:15.360392       1 controller.go:315] pmali-shared-62-vgkj5-worker-fjngh-invalid: failed to create machine: vm 'pmali-shared-62-vgkj5-rhcos-invalid' not found


Expected results:
The machine phase is set "Failed"

Additional info:

Comment 3 sunzhaohua 2020-07-07 08:44:34 UTC
Verified
clusterversion: 4.6.0-0.nightly-2020-07-06-202123
Creating a machine with invalid template
$ oc get machine
NAME                                PHASE     TYPE   REGION   ZONE   AGE
zhsun77vsphere-fjzdv-worker-2d9dn   Running                          30m
zhsun77vsphere-fjzdv-worker-hk8jd   Failed                           4s

Comment 5 errata-xmlrpc 2020-10-27 16:04:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196


Note You need to log in before you can comment on or make changes to this bug.