Description of problem: In the Cockpit unit tests we check [1] that udisks properly cleans up /etc/fstab and /etc/crypttab for volumes which have the track-parents option set. This does not work properly any more in recent RHEL 8.3 with udisks 2.9.0.


Version-Release number of selected component (if applicable):

udisks2-2.9.0-1.el8.x86_64

How reproducible: Always


Steps to Reproduce:
1. Create a VG with an LV. Cockpit does the following D-Bus calls:

  ["/org/freedesktop/UDisks2/Manager","org.freedesktop.UDisks2.Manager.LVM2","VolumeGroupCreate",["TEST",["/org/freedesktop/UDisks2/block_devices/sda"],{}]]

  ["/org/freedesktop/UDisks2/lvm/TEST","org.freedesktop.UDisks2.VolumeGroup","CreatePlainVolume",["lvol",50331648,{}]]

That part should also work with plain CLI commands:

  modprobe scsi_debug dev_size_mb=50  # should create /dev/sda
  busctl call org.freedesktop.UDisks2 /org/freedesktop/UDisks2/Manager org.freedesktop.UDisks2.Manager EnableModules b true

  # create VG with the scsi-debug device:
  busctl call org.freedesktop.UDisks2 /org/freedesktop/UDisks2/Manager org.freedesktop.UDisks2.Manager.LVM2 VolumeGroupCreate 'saoa{sv}' TEST 1 /org/freedesktop/UDisks2/block_devices/sda 0

  # create LV
  busctl call org.freedesktop.UDisks2 /org/freedesktop/UDisks2/lvm/TEST org.freedesktop.UDisks2.VolumeGroup CreatePlainVolume 'sta{sv}' lvol 50000000 0


2. Create an encrypted (LUKS) ext4 file system, and assign a mount point "/run/mount1" in /etc/fstab. That's the D-Bus call:

  ["/org/freedesktop/UDisks2/block_devices/dm_2d2","org.freedesktop.UDisks2.Block","Format",["ext4",{"tear-down":{"t":"b","v":true},"label":{"t":"s","v":"FS"},"encrypt.passphrase":{"t":"s","v":"einszweidrei"},"config-items":{"t":"a(sa{sv})","v":[["crypttab",{"options":{"t":"ay","v":"bXktY3J5cHRvLXRhZwA="},"track-parents":{"t":"b","v":true},"passphrase-contents":{"t":"ay","v":"AA=="}}],["fstab",{"dir":{"t":"ay","v":"L3J1bi9tb3VudDEA"},"type":{"t":"ay","v":"YXV0bwA="},"opts":{"t":"ay","v":"bm9hdXRvAA=="},"freq":{"t":"i","v":0},"passno":{"t":"i","v":0},"track-parents":{"t":"b","v":true}}]]}}]]


Trying to cram that into a busctl call made my head explode. This can be done easily in Cockpit, and for a test case this will likely require a reproducer in Python or whatever your tests currently use :-)

3. Make things a little harder for udisks by locking the LUKS volume:

  ["/org/freedesktop/UDisks2/block_devices/dm_2d2","org.freedesktop.UDisks2.Encrypted","Lock",[{}]]

4. And even harder by deactivating the LV:

  ["/org/freedesktop/UDisks2/lvm/TEST/lvol","org.freedesktop.UDisks2.LogicalVolume","Deactivate",[{}]]

That is the crucial step -- without that, cleanup still works fine.

5. Delete the VG, with the tear-down option to clean up:

  ["/org/freedesktop/UDisks2/lvm/TEST","org.freedesktop.UDisks2.VolumeGroup","Delete",[true,{"tear-down":{"t":"b","v":true}}]]

Actual results: crypttab gets cleaned, but fstab still has the mount point, even though it has correct x-parents:

UUID=8756620a-81df-4a18-82ff-e8b944018cb0 /run/mount1 auto noauto,x-parent=869695f6-440a-4462-8a84-73fd6171af69,x-parent=2fOHyX-Cbez-M3L7-bvl1-li1O-VbzB-E1mWLg 0 0



Expected results: /run/mount1 mount point gets cleaned from fstab.


Additional info:

[1] https://github.com/cockpit-project/cockpit/blob/master/test/verify/check-storage-hidden#L95