Bug 1843652 - new logo is not displayed in Operator Hub
Summary: new logo is not displayed in Operator Hub
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: OLM
Version: 4.4
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: 4.6.0
Assignee: Nick Hale
QA Contact: Tom Buskey
URL:
Whiteboard:
Depends On: 1844588
Blocks: 1846194
TreeView+ depends on / blocked
 
Reported: 2020-06-03 17:51 UTC by Samuel Padgett
Modified: 2020-10-27 16:05 UTC (History)
18 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Upon Icon subresource request, package-server would return the icon from the first channel declared in a package. Consequence: The OpenShift Console could show icons for channels other than the default channel, which would sometimes be different than the latest icon published to the package. Fix: Package-server gets icons from the default channel for icon subresource requests. Result: Console only displays icons from default package/channels.
Clone Of: 1810046
Environment:
Last Closed: 2020-10-27 16:04:47 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
CNV new logo in OperatorHub (1.60 MB, image/gif)
2020-06-07 19:18 UTC, Oren Cohen 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Github operator-framework operator-lifecycle-manager pull 1579 0 None closed Bug 1843652: fix(package-server): get icons from default channel 2020-11-30 16:17:35 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:05:18 UTC

Comment 1 Samuel Padgett 2020-06-03 17:58:07 UTC 
I notice some of the URL is cut off in the screenshot. This is what we're requesting:

/apis/packages.operators.coreos.com/v1/namespaces/openshift-marketplace/packagemanifests/kubevirt-hyperconverged/icon?resourceVersion=kubevirt-hyperconverged.2.3.kubevirt-hyperconverged-operator.v2.3.0
Comment 2 Oren Cohen 2020-06-07 19:17:54 UTC 
(In reply to Samuel Padgett from comment #15)
> I suspect a workaround is to change the order of the channels in the CSV so
> that the newest channel is first.

You are right.
If the new channel (with the new logo) is first on the PackageManifest, then OperatorHub displays the new logo. See gif attachment in my next comment.

The caveat is that the bundle-image builder automatically sorts the channels alphabetically, so we can't put channel "2.4" first in the list, before "2.1", "2.2" and "2.3".
For this demonstration I built the bundle image with the new logo channel renamed to "2..4" to be first in list (because its alphabetical order is lower than other channels).

Clearly this is not a workaround, and we need OLM to display the logo of the channel specified in the "defaultChannel" entry.
Comment 3 Oren Cohen 2020-06-07 19:18:47 UTC 
Created attachment 1695902 [details]
CNV new logo in OperatorHub
Comment 5 Samuel Padgett 2020-06-08 13:43:34 UTC 
(In reply to Oren Cohen from comment #2)

> Clearly this is not a workaround, and we need OLM to display the logo of the
> channel specified in the "defaultChannel" entry.

This problem has already been fixed in master and is targeted for 4.5.z with https://github.com/openshift/console/pull/5685
Comment 6 Fabian Deutsch 2020-06-08 13:48:21 UTC 
Sam, that's awesome - is there also a z-stream clone of this bug tracking this fix coming up in 4.5.z?
Comment 7 Samuel Padgett 2020-06-08 13:49:26 UTC 
(In reply to Fabian Deutsch from comment #6)
> Sam, that's awesome - is there also a z-stream clone of this bug tracking
> this fix coming up in 4.5.z?

Yes: https://bugzilla.redhat.com/show_bug.cgi?id=1844588
Comment 8 Fabian Deutsch 2020-06-08 14:19:01 UTC 
Thanks! Cool, thus we should see the fix rather soon. Thanks
Comment 13 Bowen Song 2020-06-09 17:48:32 UTC 
This is not a backport bug.
Comment 20 errata-xmlrpc 2020-10-27 16:04:47 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196
Note You need to log in before you can comment on or make changes to this bug.