Bug 1843867 - Satellite-installer failed with argument error while upgrading the satellite from 6.7 to 6.8
Summary: Satellite-installer failed with argument error while upgrading the satellite ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Installation
Version: 6.8.0
Hardware: x86_64
OS: All
unspecified
high
Target Milestone: 6.8.0
Assignee: satellite6-bugs
QA Contact: Devendra Singh
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-04 10:44 UTC by Devendra Singh
Modified: 2020-10-27 13:03 UTC (History)
3 users (show)

Fixed In Version: foreman-2.1.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 13:03:08 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 29906 0 Normal Closed foreman-installer --reset fails at `stop_services` 2020-12-19 14:02:51 UTC
Red Hat Product Errata RHSA-2020:4366 0 None None None 2020-10-27 13:03:19 UTC

Description Devendra Singh 2020-06-04 10:44:01 UTC
Description of problem: Satellite-installer failed with argument error while upgrading the satellite from 6.7 to 6.8 

Version-Release number of selected component (if applicable):
6.8

How reproducible:
always

Steps to Reproduce:
1. Prepared the environment to perform the satellite-upgrade from 6.7 to 6.8 
2. Configure all the repository
3. Execute the pre-check and it has completed successfully.

# foreman-maintain upgrade run --whitelist="disk-performance,repositories-validate, repositories-setup" --target-version 6.8 -y
Checking for new version of satellite-maintain...
Nothing to update, can't find new version of satellite-maintain.
Running Checks before upgrading to Satellite 6.8
================================================================================
Skipping pre_upgrade_checks phase as it was already run before.
To enforce to run the phase, use `upgrade run --phase pre_upgrade_checks`



Running Procedures before migrating to Satellite 6.8
================================================================================
disable active sync plans: 
\ Total 0 sync plans are now disabled.                                [OK]      
--------------------------------------------------------------------------------
Add maintenance_mode chain to iptables:                               [OK]
--------------------------------------------------------------------------------
Stop applicable services: 

Stopping the following service(s):
rh-mongodb34-mongod, postgresql, qdrouterd, qpidd, squid, pulp_celerybeat, pulp_resource_manager, pulp_streamer, pulp_workers, smart_proxy_dynflow_core, tomcat, dynflowd, elasticsearch, httpd, puppetserver, foreman-proxy
\ All services stopped                                                [OK]      
--------------------------------------------------------------------------------


Running preparation steps required to run the next scenarios
================================================================================
Check if tooling for package locking is installed:                    [OK]
--------------------------------------------------------------------------------


Running Migration scripts to Satellite 6.8
================================================================================
Setup repositories:                                                   [SKIPPED]
--------------------------------------------------------------------------------
Unlock packages:                                                      [OK]
--------------------------------------------------------------------------------
Update package(s) :                                                   [OK]
--------------------------------------------------------------------------------
Procedures::Installer::Upgrade:                                       [FAIL]
Failed executing LANG=en_US.utf-8 satellite-installer, exit status 1:
 Executing: foreman-maintain packages -h
Executing: foreman-maintain packages is-locked --assumeyes
Executing: foreman-maintain service start --only=postgresql
could not change directory to "/root"
/usr/share/foreman-installer/hooks/boot/03-foreman-maintain-extensions.rb:25:in `stop_services': wrong number of arguments (given 0, expected 1) (ArgumentError)
	from /usr/share/foreman-installer/hooks/pre/30-el7_upgrade_postgresql.rb:4:in `postgresql_12_upgrade'
	from /usr/share/foreman-installer/hooks/pre/30-el7_upgrade_postgresql.rb:20:in `block (4 levels) in load'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/hooking.rb:34:in `instance_eval'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/hooking.rb:34:in `block (4 levels) in load'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/hook_context.rb:16:in `instance_exec'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/hook_context.rb:16:in `execute'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/hooking.rb:51:in `block in execute'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/hooking.rb:49:in `each'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/hooking.rb:49:in `execute'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/kafo_configure.rb:424:in `run_installation'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/kafo_configure.rb:155:in `execute'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/clamp-1.1.2/lib/clamp/command.rb:63:in `run'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/kafo_configure.rb:118:in `run'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/clamp-1.1.2/lib/clamp/command.rb:132:in `run'
	from /opt/theforeman/tfm/root/usr/share/gems/gems/kafo-4.1.0/lib/kafo/kafo_configure.rb:162:in `run'
	from /usr/sbin/satellite-installer:8:in `<main>'
--------------------------------------------------------------------------------
Scenario [Migration scripts to Satellite 6.8] failed.



Actual results:
Upgrade failed.

Expected results:
upgrade should complete successfully.

Additional info:

Comment 5 Kavita 2020-06-05 07:08:36 UTC
Hello Brad,

Fix is expected in foreman-installer component from a attached upstream ticket.
So moving it under foreman-installer.

Comment 6 Devendra Singh 2020-06-15 10:00:27 UTC
Verified on 6.8 Snap4.

Comment 9 errata-xmlrpc 2020-10-27 13:03:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.8 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4366


Note You need to log in before you can comment on or make changes to this bug.