RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1843869 - boom: fix --backup image reference counting
Summary: boom: fix --backup image reference counting
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: boom-boot
Version: 8.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.0
Assignee: LVM and device-mapper development team
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-04 10:52 UTC by Bryn M. Reeves
Modified: 2021-09-06 15:19 UTC (History)
7 users (show)

Fixed In Version: boom-boot-1.2-2.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-04 01:57:39 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:4532 0 None None None 2020-11-04 01:57:48 UTC

Description Bryn M. Reeves 2020-06-04 10:52:11 UTC 
Description of problem:
The boom cache uses a reference count scheme to determine if a cache or backup image is in use: images are automatically removed once all entries that reference them have been deleted.

There are two related bugs in the reference counting in boom-1.1: foreign boot entries (e.g. system managed BLS entries) should not contribute to the use count, since they are outside of the boom image caching mechanism, and a side-effect of the original implementation of --backup in the boom.command module causes a spurious warning message to be emitted when backing up an image that is already used by another boot entry:

# boom create --backup --title "TEST" --rootlv rhel/root
WARNING - Uncaching path '/initramfs-4.18.0-167.el8.x86_64.img' used by 1 boot entries
WARNING - Uncaching path '/vmlinuz-4.18.0-167.el8.x86_64' used by 2 boot entries
Created entry with boot_id a3ca19c:
  title TEST
  machine-id b49e623f993c4fd7b200c5e350f9cacc
  version 4.18.0-167.el8.x86_64
  linux /vmlinuz-4.18.0-167.el8.x86_64.boom0
  initrd /initramfs-4.18.0-167.el8.x86_64.img.boom0
  options root=/dev/rhel/root ro rd.lvm.lv=rhel/root rhgb quiet
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel

The warning is seen whenever a system managed boot entry for the backup image exists (since these entries incorrectly contribute to the use count in boom-1.1).

Version-Release number of selected component (if applicable):
boom-1.1-2.el8

How reproducible:
100%

Steps to Reproduce:
1. boom create --backup --title test --rootlv ...

Actual results:
Warning message emitted.

Expected results:
No warnings.

Additional info:
Comment 1 Bryn M. Reeves 2020-06-24 14:50:01 UTC 
Fixed upstream in boom-1.2.
Comment 5 Roman Bednář 2020-09-16 12:50:21 UTC 
Verified, boom no longer emits warning when system managed BLS entries are present.

BEFORE FIX:

# kernel-install add $(uname -r) /lib/modules/$(uname -r)/vmlinuz

# boom create --backup --title test --rootlv rhel_virt-157/root
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
WARNING - Uncaching path '/vmlinuz-4.18.0-236.el8.x86_64' used by 1 boot entries
Created entry with boot_id ea0604f:
  title test
  machine-id dd5d79a5c09d4161a912a671ea395d25
  version 4.18.0-236.el8.x86_64
  linux /vmlinuz-4.18.0-236.el8.x86_64.boom0
  initrd /initramfs-4.18.0-236.el8.x86_64.img.boom0
  options root=/dev/rhel_virt-157/root ro rd.lvm.lv=rhel_virt-157/root

# rpm -qa | grep boom
boom-boot-conf-1.1-2.el8.noarch
boom-boot-1.1-2.el8.noarch
boom-boot-grub2-1.1-2.el8.noarch
python3-boom-1.1-2.el8.noarch

AFTER FIX:

# boom create --backup --title test --rootlv rhel_virt-157/root
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
Created entry with boot_id a68b617:
  title test
  machine-id dd5d79a5c09d4161a912a671ea395d25
  version 4.18.0-236.el8.x86_64
  linux /vmlinuz-4.18.0-236.el8.x86_64.boom0
  initrd /initramfs-4.18.0-236.el8.x86_64.img.boom0
  options root=/dev/rhel_virt-157/root ro rd.lvm.lv=rhel_virt-157/root rhgb quiet
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel

# rpm -qa | grep boom
python3-boom-1.2-2.el8.noarch
boom-boot-1.2-2.el8.noarch
boom-boot-grub2-1.2-2.el8.noarch
boom-boot-conf-1.2-2.el8.noarch
Comment 8 errata-xmlrpc 2020-11-04 01:57:39 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (boom-boot bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4532
Note You need to log in before you can comment on or make changes to this bug.