Bug 1844092

Hi Gal, I tried to verify with openshift-install-linux-4.5.0-0.nightly-2020-06-08-113210. According to GH, your PR was merged on June 7 07:08 GMT+2. Therefore the mentioned build should for sure include your fix. However, when running openshift-install create install-config, I was asked for DNS VIP and could not proceed without supplying it. See here:

./openshift-install create install-config
? SSH Public Key /root/.ssh/id_rsa.pub
? Platform ovirt
? oVirt cluster golden_env_mixed_2
? oVirt storage domain iscsi_0
? oVirt network ovirtmgmt
? Internal API virtual IP <censored>
X Sorry, your reply was invalid: Value is required
? Internal DNS virtual IP [? for help] 

Seems like a failed verification but I wanto to double-check that I'm not using a wrong openshift-install build.

(In reply to Jan Zmeskal from comment #3)
> Hi Gal, I tried to verify with
> openshift-install-linux-4.5.0-0.nightly-2020-06-08-113210. According to GH,
> your PR was merged on June 7 07:08 GMT+2. Therefore the mentioned build
> should for sure include your fix. However, when running openshift-install
> create install-config, I was asked for DNS VIP and could not proceed without
> supplying it. See here:
> 
> ./openshift-install create install-config
> ? SSH Public Key /root/.ssh/id_rsa.pub
> ? Platform ovirt
> ? oVirt cluster golden_env_mixed_2
> ? oVirt storage domain iscsi_0
> ? oVirt network ovirtmgmt
> ? Internal API virtual IP <censored>
> X Sorry, your reply was invalid: Value is required
> ? Internal DNS virtual IP [? for help] 
> 
> Seems like a failed verification but I wanto to double-check that I'm not
> using a wrong openshift-install build.

No, you just didn't understand the fix :)
We didn't change the installer here, so users will still be asked for it and so on,
This is a fix for the MCO so the DNS VIP is never used (but at the moment we still ask for it :D)
There is a PR [1] that removes it from the installer.
So I think that you can just leave it empty or give a random one for now.
 
[1] https://github.com/openshift/installer/pull/3692

Hi Gal,

I see. In that case, I'm glad I asked. :-) What confused me is that the Component of this BZ is Installer. Keep in mind that I don't really read the code, so base my verification on what is written in the BZ. However, upon inspecting the PR, I found out, that the fix is actually in MCO. Now there's probably no big point in changing the Component, but let's keep this in mind for future. When I see that the fix in Installer, I expect not to encounter it in openshift-install. Let me verify with this new knowledge.

(In reply to Jan Zmeskal from comment #5)
> Hi Gal,
> 
> I see. In that case, I'm glad I asked. :-) What confused me is that the
> Component of this BZ is Installer. Keep in mind that I don't really read the
> code, so base my verification on what is written in the BZ. However, upon
> inspecting the PR, I found out, that the fix is actually in MCO. Now there's
> probably no big point in changing the Component, but let's keep this in mind
> for future. When I see that the fix in Installer, I expect not to encounter
> it in openshift-install. Let me verify with this new knowledge.

Make sense, noted, not sure why I opened it on the installer

Verified with: openshift-install-linux-4.5.0-0.nightly-2020-06-08-113210

Verification steps: 
Run installation using prepared install-config while providing "1.2.3.4" as dns_vip.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409